From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay15.mail.gandi.net (relay15.mail.gandi.net [217.70.178.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94B22BEC27 for ; Thu, 3 Jul 2025 23:28:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.178.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585327; cv=none; b=JIYKMpPz/fEbD9JxMcNPs+L5qgzXeHeeTZIhqwrhJ/5nn8J0ljd+KhER/Si2caqxh1Wv5HnTahG7ww2y3VGApXqNiJN0MQjvvImpIKYi6m5CYTNRm37uuMd3Fs/Wn+OAc1yOBOzBzdEtccLVU18dDjbWlHY6q1yfoXyhiysN9Ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751585327; c=relaxed/simple; bh=L91LWGB2e/i1UuvO9OsfZ3aiH2w/mgqxOz84be2hQwc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=X4fgMkTcjOR9mHoEsGneg6JP0PqIze1aMUWx7Qx9UioY8bZo5Zb/JKjZrD79kY/MhdiA7JHvxQncpAODouMVwhXhKcIJLHu109VyOdQzJRSvQoHAWp9nPmVyypXMoHRYlGqmxfOXLj817UKAT9/qlgdquRqjs4Oy42aOJIuZpf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=T7xaFHaf; arc=none smtp.client-ip=217.70.178.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="T7xaFHaf" Received: by mail.gandi.net (Postfix) with ESMTPSA id 3273343136; Thu, 3 Jul 2025 23:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1751585322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kDAyEWIe7XZYwJv1nN64rJP4O70drfI1NJYvVOMt1W4=; b=T7xaFHafxQ6BjR7gj9MQ9EzG7tgapk+U44Gh/FwUnRXh0Y7X4BPUKwSo2Htg7Aue55gvAj Ld2AvMscsr6HYTS8NxJRhkX/dAV/By15AinNgLtEK7cezHyieFkw3OLnGrbOZir6zZkk2d XGINi9GUEwAsekLLLIaCEDqLW7ENeBV9o5MhOyenZ60183ZrxBiWCIGzDtIzx42s/m1GHU VJy/rY/H/XHK2Ok/JidGfxQgPYPYZ29SObirWxlr+h/nUi+PKMsYvG532+9dETYG7yVeay CVgPuBbOWPctC0q0cQt9BW6EsvnFYZX6/r+O2w/JXkd8W7yXx++tJZWK34Jf6Q== Date: Fri, 4 Jul 2025 01:28:25 +0200 From: Luca Ceresoli To: "Colin King (gmail)" Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: tc358767: fix uninitialized variable regression Message-ID: <20250704012825.206a720b@booty> In-Reply-To: References: <20250703-drm-bridge-alloc-fix-tc358767-regression-v1-1-8f224cd063c4@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddvudeitdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfohfogggtgfesthejredtredtvdenucfhrhhomhepnfhutggrucevvghrvghsohhlihcuoehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpedtleejjeduvddutefftdduleefudfgudeltdeuffeuudefgfdugeekgedtieehudenucffohhmrghinhepkhgvrhhnvghlrdhorhhgpdgsohhothhlihhnrdgtohhmnecukfhppeehuddrudejledruddtfedrheehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthephedurddujeelrddutdefrdehhedphhgvlhhopegsohhothihpdhmrghilhhfrhhomheplhhutggrrdgtvghrvghsohhlihessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudejpdhrtghpthhtoheptgholhhinhdrihdrkhhinhhgsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprghnughriigvjhdrhhgrjhgurgesihhnthgvlhdrtghomhdprhgtphhtthhopehnvghilhdrrghrmhhsthhrohhngheslhhinhgrrhhordhorhhgpdhrtghpthhtoheprhhfohhssheskhgvrhhnvghlrdhorhhgpdhrtghpt hhtohepnfgruhhrvghnthdrphhinhgthhgrrhhtsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhopehjohhnrghssehkfihisghoohdrshgvpdhrtghpthhtohepjhgvrhhnvghjrdhskhhrrggsvggtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepmhgrrghrthgvnhdrlhgrnhhkhhhorhhstheslhhinhhugidrihhnthgvlhdrtghomh On Thu, 3 Jul 2025 19:00:44 +0100 "Colin King (gmail)" wrote: > On 03/07/2025 17:32, Luca Ceresoli wrote: > > Commit a59a27176914 ("drm/bridge: tc358767: convert to > > devm_drm_bridge_alloc() API") split tc_probe_bridge_endpoint() in two > > functions, thus duplicating the loop over the endpoints in each of those > > functions. However it missed duplicating the of_graph_parse_endpoint() call > > which initializes the struct of_endpoint, resulting in an uninitialized > > read. > > > > Fixes: a59a27176914 ("drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API") > > Reported-by: Colin King (gmail) > > Closes: https://lore.kernel.org/all/056b34c3-c1ea-4b8c-9672-c98903ffd012@gmail.com056b34c3-c1ea-4b8c-9672-c98903ffd012@gmail.com Dang, broken URL. I could not check it because lore was down when I sent the patch. Ignore this patch, sending v2. > Reviewed-by: Colin Ian King Thanks, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com