Re: [PATCH 4/7] firmware: arm_scmi: imx: Support getting silicon info of MISC protocol

Sudeep Holla
2025-07-04T09:32:39Z

On Fri, Jul 04, 2025 at 06:20:57PM +0800, Peng Fan wrote:
> On Wed, Jul 02, 2025 at 04:22:11PM +0100, Sudeep Holla wrote:
> >On Fri, Jun 27, 2025 at 02:03:47PM +0800, Peng Fan wrote:
> >> MISC protocol supports getting the silicon information including revision
> >> number, part number and etc. Add the API for user to retrieve the
> >> information from SM.
> >>
> >> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >> ---
> >> .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 34 ++++++++++++++++++++++
> >> include/linux/scmi_imx_protocol.h | 8 +++++
> >> 2 files changed, 42 insertions(+)
> >>
> >> diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> >> index 8ce4bf92e6535af2f30d72a34717678613b35049..d5b24bc4d4ca6c19f4cddfaea6e9d9b32a4c92f7 100644
> >> --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> >> +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> >> @@ -26,6 +26,7 @@ enum scmi_imx_misc_protocol_cmd {
> >> SCMI_IMX_MISC_CTRL_SET = 0x3,
> >> SCMI_IMX_MISC_CTRL_GET = 0x4,
> >> SCMI_IMX_MISC_DISCOVER_BUILDINFO = 0x6,
> >> + SCMI_IMX_MISC_SI_INFO = 0xB,
> >
> >Again, this seem to have slipped through in my initial review. How is this
> >different from SMCCC SOC_ID interface. I am OK to have it as part of your
> >vendor extensions and be here in the kernel documentation. But I won't
> >accept any users of this within the kernel. Please provide justification
> >as why you can't use the standard SMCCC SOC_ID.
> >
> >So, clear NACK for adding this support in the kernel for now.
>
> What I do here is just wanna to let
> linux could print similar information as what SM shows in its console:
>

Sure you can dump whatever you want on the console. The main concern is
another user interface for very similar information that can be obtained
by SOC_ID or soc_device in the kernel. Just kernel internal use should
be fine.

> >$ info
> SM Version = Build 677, Commit 49a36aaf
> SM Config = mx95evk, mSel=0
> Board = i.MX95 EVK, attr=0x00000000
> Silicon = i.MX95 B0
> Boot mode = normal
> Boot device = SD2
> Boot stage = primary
> Boot set = 1
> ECID = 0x7BADEECC000001D40001300963E636F1
> PMIC 0 (0x08) = 0x20, 0x09, 0x20, 0x00, 0x01
> PMIC 1 (0x2A) = 0x54, 0x22, 0x00, 0x0B
> PMIC 2 (0x29) = 0x55, 0x22, 0x00, 0x0A
> Compiler = gcc 14.2.1 20241119
>
> With soc_device_register, dumping the silicon information needs use the
> other sysfs interface.

So what ?

> Here with this patchset, reading one sysfs file could dump all the information.
>

That goes completely again the sysfs policy. Single file single value.
Convince Greg otherwise, I will consider elsewhere not for this SOC_ID
for sure.

> But anyway, ok to drop this patch.
>

Thanks!

--
Regards,
Sudeep