Re: [PATCH net 2/2] rxrpc: Fix bug due to prealloc collision

David Howells
2025-07-08T19:57:45Z

Jakub Kicinski <kuba@kernel.org> wrote:

> On Mon, 7 Jul 2025 11:24:34 +0100 David Howells wrote:
> > + rxrpc_prefail_call(call, RXRPC_CALL_LOCAL_ERROR, -EBADSLT);
> > + __set_bit(RXRPC_CALL_RELEASED, &call->flags);
>
> is the __set_bit() needed / intentional here?
> Looks like rxrpc_prefail_call() does:
>
> WARN_ON_ONCE(__test_and_set_bit(RXRPC_CALL_RELEASED, &call->flags));

Actually, it shouldn't be. I added that first, then realised that wasn't
sufficient.

I also realised there should be a third patch I failed to restack onto the git
branch.

Can you take the first patch and I'll alter this and repost this patch and add
the lost one? Or should I just repost all three?

David