From: Jakub Kicinski <kuba@kernel.org>
To: Song Yoong Siang <yoong.siang.song@intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next 0/2] Clarify and Enhance XDP Rx Metadata Handling
Date: Mon, 7 Jul 2025 13:55:07 -0700 [thread overview]
Message-ID: <20250707135507.29cb55be@kernel.org> (raw)
In-Reply-To: <20250701042940.3272325-1-yoong.siang.song@intel.com>
On Tue, 1 Jul 2025 12:29:38 +0800 Song Yoong Siang wrote:
> |<---sizeof(xdp_meta)--|
> | |
> struct xdp_meta rx_desc->address
> ^ ^
> | |
> +----------+----------------------+------------+------+
> | headroom | custom metadata | reserved | data |
> +----------+----------------------+------------+------+
> ^ ^ ^
> | | |
> struct xdp_meta xdp_buff->data_meta xdp_buff->data
> | |
> |<---sizeof(xdp_meta)--|
Huh. Did AF_XDP maintainers explicitly sign off on this or it's just how
IGC implementation works and nobody noticed?
For normal XDP my understanding is that its the driver's responsibility
to move the "reserved" stuff out of place before presenting the frame to
program.
next prev parent reply other threads:[~2025-07-07 20:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 4:29 [PATCH bpf-next 0/2] Clarify and Enhance XDP Rx Metadata Handling Song Yoong Siang
2025-07-01 4:29 ` [PATCH bpf-next 1/2] doc: clarify XDP Rx metadata layout and bpf_xdp_adjust_meta usage Song Yoong Siang
2025-07-01 4:29 ` [PATCH bpf-next 2/2] selftests/bpf: Enhance XDP Rx Metadata Handling Song Yoong Siang
2025-07-01 16:31 ` Stanislav Fomichev
2025-07-02 2:23 ` Song, Yoong Siang
2025-07-02 3:55 ` Song, Yoong Siang
2025-07-02 15:18 ` Stanislav Fomichev
2025-07-02 15:56 ` Song, Yoong Siang
2025-07-02 16:04 ` Stanislav Fomichev
2025-07-02 16:17 ` Song, Yoong Siang
2025-07-07 20:55 ` Jakub Kicinski [this message]
2025-07-08 1:34 ` [PATCH bpf-next 0/2] Clarify and " Song, Yoong Siang
2025-07-08 1:44 ` Jakub Kicinski
2025-07-08 2:06 ` Song, Yoong Siang
2025-07-08 2:17 ` Jakub Kicinski
2025-07-08 2:32 ` Song, Yoong Siang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707135507.29cb55be@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).