From: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>,
devicetree@vger.kernel.org,
Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>,
Lucca Fachinetti <luccafachinetti@gmail.com>
Subject: [PATCH v3 0/3] Add support for is31fl3236a LED controller
Date: Tue, 08 Jul 2025 15:59:44 +0100 [thread overview]
Message-ID: <20250708-leds-is31fl3236a-v3-0-d68979b042dd@thegoodpenguin.co.uk> (raw)
This series of patches adds support for the is31fl3236a led
controller. The main difference between this IC and the
is31fl3236 is that there is a new parameter/register that
moves the operating frequency of the PWM outputs out of
the audible range.
To support the new register a property was added in the dt-bindings,
as this property is at the board layout level ie. not all
boards will have analog audio and have to worry about it.
To add the new property the old .txt binding documentation was
ported to .yaml format. There was a previous attempt to do this
in 2024 but the original author has never acted on the feedback
given [1]. So I have implemented changes requested in that
review and added his Signed-off-by.
The new functionality was tested by scoping the PWM signal. Out of
reset the IC is in 3kHz mode, thus action is taken only if the new
boolean value is set to true in the device tree.
[1] https://lore.kernel.org/linux-leds/20240701-overview-video-34f025ede104@spud/
Changes in v2:
- Added cover letter
- Ported dt-binding to yaml
- Refactored driver module
- Link to v1: https://lore.kernel.org/linux-leds/CAA6zWZ+TbcHrZaZ0ottm0s1mhCLa8TXASii47WKSLn2_zV95bw@mail.gmail.com/T/#t
Changes in v3:
- Aligned/refactored code properly in C module
- Refactored dt-bindings yml file
- Link to v2: https://lore.kernel.org/r/20250627-leds-is31fl3236a-v2-0-f6ef7495ce65@thegoodpenguin.co.uk
Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
---
Lucca Fachinetti (1):
dt-bindings: leds: is31fl32xx: convert the binding to yaml
Pawel Zalewski (2):
leds/leds-is31fl32xx: add support for is31fl3236a
dt-bindings: leds: issi,is31fl3236: add issi,22kHz-pwm property
.../devicetree/bindings/leds/issi,is31fl3236.yaml | 104 +++++++++++++++++++++
.../devicetree/bindings/leds/leds-is31fl32xx.txt | 52 -----------
drivers/leds/leds-is31fl32xx.c | 35 +++++++
3 files changed, 139 insertions(+), 52 deletions(-)
---
base-commit: 52da431bf03b5506203bca27fe14a97895c80faf
change-id: 20250625-leds-is31fl3236a-39cf52f969c7
Best regards,
--
Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
next reply other threads:[~2025-07-08 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 14:59 Pawel Zalewski [this message]
2025-07-08 14:59 ` [PATCH v3 1/3] leds/leds-is31fl32xx: add support for is31fl3236a Pawel Zalewski
2025-07-09 8:12 ` Krzysztof Kozlowski
2025-07-14 9:09 ` Pawel Zalewski
2025-07-14 9:35 ` Krzysztof Kozlowski
2025-07-08 14:59 ` [PATCH v3 2/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml Pawel Zalewski
2025-07-09 8:17 ` Krzysztof Kozlowski
2025-07-14 9:16 ` Pawel Zalewski
2025-07-14 9:36 ` Krzysztof Kozlowski
2025-07-09 8:18 ` Krzysztof Kozlowski
2025-07-08 14:59 ` [PATCH v3 3/3] dt-bindings: leds: issi,is31fl3236: add issi,22kHz-pwm property Pawel Zalewski
2025-07-09 8:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708-leds-is31fl3236a-v3-0-d68979b042dd@thegoodpenguin.co.uk \
--to=pzalewski@thegoodpenguin.co.uk \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=luccafachinetti@gmail.com \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).