From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jason A . Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH] lib/crypto: sha256: Add tests for HMAC-SHA224 and HMAC-SHA256
Date: Mon, 7 Jul 2025 20:26:05 -0700 [thread overview]
Message-ID: <20250708032605.GA3821@sol> (raw)
In-Reply-To: <CAMj1kXHGgYCEmQDs4CDUDqqK5QO3o2B9NmRfmQ9N-sC-Hu1yOw@mail.gmail.com>
On Tue, Jul 08, 2025 at 01:09:17PM +1000, Ard Biesheuvel wrote:
> On Wed, 25 Jun 2025 at 17:12, Eric Biggers <ebiggers@kernel.org> wrote:
> >
> > Now that there's a library API for HMAC-SHA224 and HMAC-SHA256, update
> > sha224_kunit and sha256_kunit to test it. This mirrors the tests for
> > HMAC-SHA384 and HMAC-SHA512 in sha384_kunit and sha512_kunit. The test
> > vectors were generated using scripts/crypto/gen-hash-testvecs.py.
> >
> > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > ---
> >
>
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
Thanks! FYI, the latest version of the tests is in
"[PATCH v4 0/4] KUnit tests for SHA-2 and Poly1305"
(https://lore.kernel.org/linux-crypto/20250706232817.179500-1-ebiggers@kernel.org/).
Sorry for the confusion -- this was an incremental patch, which was
superseded when I started a series for the tests from a clean state.
- Eric
prev parent reply other threads:[~2025-07-08 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 7:11 [PATCH] lib/crypto: sha256: Add tests for HMAC-SHA224 and HMAC-SHA256 Eric Biggers
2025-07-08 3:09 ` Ard Biesheuvel
2025-07-08 3:26 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708032605.GA3821@sol \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).