From: Tao Chen <chen.dylane@linux.dev>
To: daniel@iogearbox.net, razor@blackwall.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ast@kernel.org, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, mattbobrowski@google.com, rostedt@goodmis.org,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
horms@kernel.org, willemb@google.com, jakub@cloudflare.com,
pablo@netfilter.org, kadlec@netfilter.org, hawk@kernel.org
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
Tao Chen <chen.dylane@linux.dev>
Subject: [PATCH bpf-next v4 7/7] netkit: Remove location field in netkit_link
Date: Thu, 10 Jul 2025 11:20:38 +0800 [thread overview]
Message-ID: <20250710032038.888700-8-chen.dylane@linux.dev> (raw)
In-Reply-To: <20250710032038.888700-1-chen.dylane@linux.dev>
Use attach_type in bpf_link to replace the location field, and
remove location field in netkit_link.
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Tao Chen <chen.dylane@linux.dev>
---
drivers/net/netkit.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/netkit.c b/drivers/net/netkit.c
index 5928c99eac7..492be60f2e7 100644
--- a/drivers/net/netkit.c
+++ b/drivers/net/netkit.c
@@ -32,7 +32,6 @@ struct netkit {
struct netkit_link {
struct bpf_link link;
struct net_device *dev;
- u32 location;
};
static __always_inline int
@@ -733,8 +732,8 @@ static void netkit_link_fdinfo(const struct bpf_link *link, struct seq_file *seq
seq_printf(seq, "ifindex:\t%u\n", ifindex);
seq_printf(seq, "attach_type:\t%u (%s)\n",
- nkl->location,
- nkl->location == BPF_NETKIT_PRIMARY ? "primary" : "peer");
+ link->attach_type,
+ link->attach_type == BPF_NETKIT_PRIMARY ? "primary" : "peer");
}
static int netkit_link_fill_info(const struct bpf_link *link,
@@ -749,7 +748,7 @@ static int netkit_link_fill_info(const struct bpf_link *link,
rtnl_unlock();
info->netkit.ifindex = ifindex;
- info->netkit.attach_type = nkl->location;
+ info->netkit.attach_type = link->attach_type;
return 0;
}
@@ -776,7 +775,6 @@ static int netkit_link_init(struct netkit_link *nkl,
{
bpf_link_init(&nkl->link, BPF_LINK_TYPE_NETKIT,
&netkit_link_lops, prog, attr->link_create.attach_type);
- nkl->location = attr->link_create.attach_type;
nkl->dev = dev;
return bpf_link_prime(&nkl->link, link_primer);
}
--
2.48.1
next prev parent reply other threads:[~2025-07-10 3:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 3:20 [PATCH bpf-next v4 0/7] Move attach_type into bpf_link Tao Chen
2025-07-10 3:20 ` [PATCH bpf-next v4 1/7] bpf: Add attach_type in bpf_link Tao Chen
2025-07-11 17:50 ` Andrii Nakryiko
2025-07-10 3:20 ` [PATCH bpf-next v4 2/7] bpf: Remove attach_type in bpf_cgroup_link Tao Chen
2025-07-10 3:20 ` [PATCH bpf-next v4 3/7] bpf: Remove attach_type in sockmap_link Tao Chen
2025-07-11 17:39 ` John Fastabend
2025-07-10 3:20 ` [PATCH bpf-next v4 4/7] bpf: Remove location field in tcx_link Tao Chen
2025-07-11 17:37 ` John Fastabend
2025-07-10 3:20 ` [PATCH bpf-next v4 5/7] bpf: Remove attach_type in bpf_netns_link Tao Chen
2025-07-10 3:20 ` [PATCH bpf-next v4 6/7] bpf: Remove attach_type in bpf_tracing_link Tao Chen
2025-07-10 3:20 ` Tao Chen [this message]
2025-07-11 18:00 ` [PATCH bpf-next v4 0/7] Move attach_type into bpf_link patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710032038.888700-8-chen.dylane@linux.dev \
--to=chen.dylane@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mattbobrowski@google.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox