* [PATCH] phy: qcom: fix error code in snps_eusb2_hsphy_probe()
@ 2025-07-10 17:24 Harshit Mogalapalli
2025-07-15 15:18 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Harshit Mogalapalli @ 2025-07-10 17:24 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Abel Vesa, linux-phy,
linux-kernel
Cc: dan.carpenter, kernel-janitors, error27, harshit.m.mogalapalli
When phy->ref_clk is NULL PTR_ERR(NULL) will be a success. Fix this by
using -ENOENT when phy->ref_clk is NULL instead.
Fixes: 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aDCbeuCTy9zyWJAM@stanley.mountain/
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
This is based on static-analysis, only compile tested.
---
drivers/phy/phy-snps-eusb2.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c
index 87f323e758d6..5e19532bef3a 100644
--- a/drivers/phy/phy-snps-eusb2.c
+++ b/drivers/phy/phy-snps-eusb2.c
@@ -568,9 +568,11 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
}
}
- if (IS_ERR_OR_NULL(phy->ref_clk))
- return dev_err_probe(dev, PTR_ERR(phy->ref_clk),
+ if (IS_ERR_OR_NULL(phy->ref_clk)) {
+ ret = phy->ref_clk ? PTR_ERR(phy->ref_clk) : -ENOENT;
+ return dev_err_probe(dev, ret,
"failed to get ref clk\n");
+ }
num = ARRAY_SIZE(phy->vregs);
for (i = 0; i < num; i++)
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] phy: qcom: fix error code in snps_eusb2_hsphy_probe()
2025-07-10 17:24 [PATCH] phy: qcom: fix error code in snps_eusb2_hsphy_probe() Harshit Mogalapalli
@ 2025-07-15 15:18 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2025-07-15 15:18 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Abel Vesa, linux-phy, linux-kernel,
Harshit Mogalapalli
Cc: dan.carpenter, kernel-janitors, error27
On Thu, 10 Jul 2025 10:24:02 -0700, Harshit Mogalapalli wrote:
> When phy->ref_clk is NULL PTR_ERR(NULL) will be a success. Fix this by
> using -ENOENT when phy->ref_clk is NULL instead.
>
>
Applied, thanks!
[1/1] phy: qcom: fix error code in snps_eusb2_hsphy_probe()
commit: b7acfeab8af9ee661c933522132f3d1d92ed12d6
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-15 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-10 17:24 [PATCH] phy: qcom: fix error code in snps_eusb2_hsphy_probe() Harshit Mogalapalli
2025-07-15 15:18 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).