From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, Andre Edich <andre.edich@microchip.com>,
Lukas Wunner <lukas@wunner.de>
Subject: [PATCH net v3 0/3] net: phy: smsc: use IRQ + relaxed polling to fix missed link-up
Date: Fri, 11 Jul 2025 11:49:06 +0200 [thread overview]
Message-ID: <20250711094909.1086417-1-o.rempel@pengutronix.de> (raw)
This series makes the SMSC LAN8700 (as used in LAN9512 and similar USB
adapters) reliable again in configurations where it is forced to 10 Mb/s
and the link partner still advertises autonegotiation.
In this scenario, the PHY may miss the final link-up interrupt, causing
the network interface to remain down even though a valid link is
present.
To address this:
Patch 1 – phylib: Enable polling if the driver implements
get_next_update_time(). This ensures the state machine is active even
without update_stats().
Patch 2 – phylib: Allow drivers to return PHY_STATE_IRQ to explicitly
disable polling.
Patch 3 – smsc: Implement get_next_update_time() with adaptive 1 Hz
polling for up to 30 seconds after the last interrupt in the affected
10M autoneg-off mode. All other configurations rely on IRQs only.
Testing:
The LAN9512 (LAN8700 core) was tested against an Intel I350 NIC using
baseline, parallel-detection, and advertisement test suites. All
relevant tests passed.
Changes in v3:
- handle conflicting configuration if update_stats are supported
Changes in v2:
- Introduced explicit disable polling via PHY_STATE_IRQ
- Changed the workaround logic to apply 1 Hz polling only for 30 seconds
after the last IRQ
- Dropped relaxed 30s polling while link is up
- Reworded commit messages and comments to reflect updated logic
- Split core changes into two separate patches for clarity
Thanks,
Oleksij Rempel
Oleksij Rempel (3):
net: phy: enable polling when driver implements get_next_update_time
net: phy: allow drivers to disable polling via get_next_update_time()
net: phy: smsc: recover missed link-up IRQs on LAN8700 with adaptive
polling
drivers/net/phy/phy.c | 27 ++++++++++++++++++++-------
drivers/net/phy/smsc.c | 40 ++++++++++++++++++++++++++++++++++++++++
include/linux/phy.h | 17 +++++++++++++++--
3 files changed, 75 insertions(+), 9 deletions(-)
--
2.39.5
next reply other threads:[~2025-07-11 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 9:49 Oleksij Rempel [this message]
2025-07-11 9:49 ` [PATCH net v3 1/3] net: phy: enable polling when driver implements get_next_update_time Oleksij Rempel
2025-07-11 9:49 ` [PATCH net v3 2/3] net: phy: allow drivers to disable polling via get_next_update_time() Oleksij Rempel
2025-07-12 13:18 ` Simon Horman
2025-07-14 9:53 ` Oleksij Rempel
2025-07-11 9:49 ` [PATCH net v3 3/3] net: phy: smsc: recover missed link-up IRQs on LAN8700 with adaptive polling Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711094909.1086417-1-o.rempel@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andre.edich@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).