From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
bpf@vger.kernel.org, kernel-team@meta.com,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v6 3/3] selftests: net: add netpoll basic functionality test
Date: Fri, 11 Jul 2025 10:14:15 -0700 [thread overview]
Message-ID: <20250711101415.6ae42daf@kernel.org> (raw)
In-Reply-To: <20250711-netpoll_test-v6-3-130465f286a8@debian.org>
On Fri, 11 Jul 2025 09:05:11 -0700 Breno Leitao wrote:
> + rxq = ethtool_result["rx"]
> + txq = ethtool_result["tx"]
Most HW NICs will actually use the "combined" channels (which have both
rx and tx ring on one NAPI).
> + logging.debug("calling: ethtool %s", cmdline)
ksft_pr() ?
We had a plan to add a verbose() helper which would still be
TAP-compatible, but never finished the patches.
Either way, would you mind respinning the series (without the 24h wait)?
It conflicts with another series which adds a bpftool() helper.
I applied that patch so you should see a trivial conflict when rebasing.
next prev parent reply other threads:[~2025-07-11 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 16:05 [PATCH net-next v6 0/3] selftest: net: Add selftest for netpoll Breno Leitao
2025-07-11 16:05 ` [PATCH net-next v6 1/3] selftests: drv-net: add helper/wrapper for bpftrace Breno Leitao
2025-07-11 16:05 ` [PATCH net-next v6 2/3] selftests: drv-net: Strip '@' prefix from bpftrace map keys Breno Leitao
2025-07-11 16:05 ` [PATCH net-next v6 3/3] selftests: net: add netpoll basic functionality test Breno Leitao
2025-07-11 17:14 ` Jakub Kicinski [this message]
2025-07-14 9:52 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711101415.6ae42daf@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).