linux-next: build warning after merge of the iommufd tree

linux-next: build warning after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:

include/uapi/linux/iommufd.h:277: warning: Cannot understand  * @size: sizeof(struct iommu_option)

Introduced by commit

  5a013b3b3b2f ("iommufd: IOCTLs for the io_pagetable")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:

drivers/iommu/iommufd/device.c:674: warning: Excess function parameter 'ioas_id' description in 'iommufd_access_create'

Introduced by commits

  7540af571dc7 ("iommufd: Create access in vfio_iommufd_emulated_bind()")
  8003e9a6c169 ("vfio-iommufd: Make vfio_iommufd_emulated_bind() return iommufd_access ID")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/userspace-api/iommufd:184: drivers/iommu/iommufd/device.c:613: WARNING: Definition list ends without a blank line; unexpected unindent.

Introduced by commit

  e8b57a50334c ("iommufd: Add iommufd_device_replace()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the iommufd tree

[Nicolin Chen]

Thanks for reporting.

On Fri, Mar 31, 2023 at 03:31:46PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> drivers/iommu/iommufd/device.c:674: warning: Excess function parameter 'ioas_id' description in 'iommufd_access_create'
> 
> Introduced by commits
> 
>   7540af571dc7 ("iommufd: Create access in vfio_iommufd_emulated_bind()")

Should have dropped that line from kdoc in this commit.

diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
index fca09bb4e839..d791ab5830b4 100644
--- a/drivers/iommu/iommufd/device.c
+++ b/drivers/iommu/iommufd/device.c
@@ -795,7 +795,6 @@ void iommufd_access_destroy_object(struct iommufd_object *obj)
 /**
  * iommufd_access_create - Create an iommufd_access
  * @ictx: iommufd file descriptor
- * @ioas_id: ID for a IOMMUFD_OBJ_IOAS
  * @ops: Driver's ops to associate with the access
  * @data: Opaque data to pass into ops functions
  *

Re: linux-next: build warning after merge of the iommufd tree

[Jason Gunthorpe]

On Thu, Mar 30, 2023 at 10:09:38PM -0700, Nicolin Chen wrote:
> Thanks for reporting.
> 
> On Fri, Mar 31, 2023 at 03:31:46PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the iommufd tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > drivers/iommu/iommufd/device.c:674: warning: Excess function parameter 'ioas_id' description in 'iommufd_access_create'
> > 
> > Introduced by commits
> > 
> >   7540af571dc7 ("iommufd: Create access in vfio_iommufd_emulated_bind()")
> 
> Should have dropped that line from kdoc in this commit.
> 
> diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
> index fca09bb4e839..d791ab5830b4 100644
> --- a/drivers/iommu/iommufd/device.c
> +++ b/drivers/iommu/iommufd/device.c
> @@ -795,7 +795,6 @@ void iommufd_access_destroy_object(struct iommufd_object *obj)
>  /**
>   * iommufd_access_create - Create an iommufd_access
>   * @ictx: iommufd file descriptor
> - * @ioas_id: ID for a IOMMUFD_OBJ_IOAS
>   * @ops: Driver's ops to associate with the access
>   * @data: Opaque data to pass into ops functions
>   *

Got it thanks

Jason

Re: linux-next: build warning after merge of the iommufd tree

[Jason Gunthorpe]

On Fri, Mar 31, 2023 at 03:41:02PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/userspace-api/iommufd:184: drivers/iommu/iommufd/device.c:613: WARNING: Definition list ends without a blank line; unexpected unindent.
> 
> Introduced by commit
> 
>   e8b57a50334c ("iommufd: Add iommufd_device_replace()")

Got it, thanks

Jason 

linux-next: build warning after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/userspace-api/iommufd:323: include/uapi/linux/iommufd.h:1033: CRITICAL: Unexpected section title or transition.

------------------------------------------------------------------------- [docutils]
WARNING: kernel-doc 'scripts/kernel-doc -rst -enable-lineno include/uapi/linux/iommufd.h' processing failed with: Documentation/userspace-api/iommufd:323: include/uapi/linux/iommufd.h:1033: (SEVERE/4) Unexpected section title or transition.

-------------------------------------------------------------------------

Introduced by commit

  50c842dd6cd3 ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

vmlinux.o: warning: objtool: iommu_dma_get_msi_page() falls through to next function __iommu_dma_unmap()

I have no idea where that came from.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the iommufd tree

[Jason Gunthorpe]

On Fri, Mar 21, 2025 at 07:36:00PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the iommufd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> vmlinux.o: warning: objtool: iommu_dma_get_msi_page() falls through to next function __iommu_dma_unmap()
> 
> I have no idea where that came from.

Me too, I've been ignoring weird objtool things because I don't know
what to do with them :\

Jason

Re: linux-next: build warning after merge of the iommufd tree

[Valdis Klētnieks]

On Fri, 21 Mar 2025 08:39:32 -0300, Jason Gunthorpe said:
> On Fri, Mar 21, 2025 at 07:36:00PM +1100, Stephen Rothwell wrote:

> > vmlinux.o: warning: objtool: iommu_dma_get_msi_page() falls through to next function __iommu_dma_unmap()
> > 
> > I have no idea where that came from.
>
> Me too, I've been ignoring weird objtool things because I don't know
> what to do with them :\

It's particularly annoying if you turned on the recently added CONFIG_OBJTOOL_WERROR=y

\0\0\0\0\0\0\0\0

Re: linux-next: build warning after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

Hi all,

On Tue, 18 Mar 2025 21:33:59 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/userspace-api/iommufd:323: include/uapi/linux/iommufd.h:1033: CRITICAL: Unexpected section title or transition.
> 
> ------------------------------------------------------------------------- [docutils]
> WARNING: kernel-doc 'scripts/kernel-doc -rst -enable-lineno include/uapi/linux/iommufd.h' processing failed with: Documentation/userspace-api/iommufd:323: include/uapi/linux/iommufd.h:1033: (SEVERE/4) Unexpected section title or transition.
> 
> -------------------------------------------------------------------------
> 
> Introduced by commit
> 
>   50c842dd6cd3 ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC")

Any progress on this?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the iommufd tree

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

On Fri, Mar 28, 2025 at 05:57:45PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 18 Mar 2025 21:33:59 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the iommufd tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > Documentation/userspace-api/iommufd:323: include/uapi/linux/iommufd.h:1033: CRITICAL: Unexpected section title or transition.
> > 
> > ------------------------------------------------------------------------- [docutils]
> > WARNING: kernel-doc 'scripts/kernel-doc -rst -enable-lineno include/uapi/linux/iommufd.h' processing failed with: Documentation/userspace-api/iommufd:323: include/uapi/linux/iommufd.h:1033: (SEVERE/4) Unexpected section title or transition.
> > 
> > -------------------------------------------------------------------------
> > 
> > Introduced by commit
> > 
> >   50c842dd6cd3 ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC")
> 
> Any progress on this?

Should've been fixed by [1].

Thanks.

[1]: https://lore.kernel.org/linux-doc/20250328114654.55840-1-bagasdotme@gmail.com/

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

linux-next: build warning after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/userspace-api/iommufd:335: include/uapi/linux/iommufd.h:1272: ERROR: Unexpected indentation. [docutils]

Introduced by commit

  c4e9e9b4227e ("iommufd/viommu: Add IOMMUFD_CMD_HW_QUEUE_ALLOC ioctl")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced this warning:

include/uapi/linux/iommufd.h:607: warning: cannot understand function prototype: 'struct iommu_hw_info_tegra241_cmdqv '

Introduced by commit

  b135de24cfc0 ("iommu/tegra241-cmdqv: Add user-space use support")

You forgot the "struct" in the kerneldoc comment.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the iommufd tree

[Jason Gunthorpe]

On Fri, Jul 11, 2025 at 06:25:01PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/userspace-api/iommufd:335: include/uapi/linux/iommufd.h:1272: ERROR: Unexpected indentation. [docutils]
> 
> Introduced by commit
> 
>   c4e9e9b4227e ("iommufd/viommu: Add IOMMUFD_CMD_HW_QUEUE_ALLOC ioctl")

I fixed this with:

--- a/include/uapi/linux/iommufd.h
+++ b/include/uapi/linux/iommufd.h
@@ -1175,7 +1175,8 @@ enum iommu_hw_queue_type {
  * and @length.
  *
  * A vIOMMU can allocate multiple queues, but it must use a different @index per
- * type to separate each allocation, e.g.
+ * type to separate each allocation, e.g::
+ *
  *     Type1 HW queue0, Type1 HW queue1, Type2 HW queue0, ...
  */
 struct iommu_hw_queue_alloc {

Thanks,
Jason 

Re: linux-next: build warning after merge of the iommufd tree

[Jason Gunthorpe]

On Fri, Jul 11, 2025 at 06:35:26PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> include/uapi/linux/iommufd.h:607: warning: cannot understand function prototype: 'struct iommu_hw_info_tegra241_cmdqv '
> 
> Introduced by commit
> 
>   b135de24cfc0 ("iommu/tegra241-cmdqv: Add user-space use support")
> 
> You forgot the "struct" in the kerneldoc comment.

I fixed it with this:

--- a/include/uapi/linux/iommufd.h
+++ b/include/uapi/linux/iommufd.h
@@ -592,8 +592,9 @@ struct iommu_hw_info_arm_smmuv3 {
 };
 
 /**
- * iommu_hw_info_tegra241_cmdqv - NVIDIA Tegra241 CMDQV Hardware Information
- *                                (IOMMU_HW_INFO_TYPE_TEGRA241_CMDQV)
+ * struct iommu_hw_info_tegra241_cmdqv - NVIDIA Tegra241 CMDQV Hardware
+ *         Information (IOMMU_HW_INFO_TYPE_TEGRA241_CMDQV)
+ *
  * @flags: Must be 0
  * @version: Version number for the CMDQ-V HW for PARAM bits[03:00]
  * @log2vcmdqs: Log2 of the total number of VCMDQs for PARAM bits[07:04]


Thanks,
Jason