* [PATCH] vfio/pds: Fix missing detach_ioas op
@ 2025-07-02 16:37 Brett Creeley
2025-07-03 6:44 ` Tian, Kevin
2025-07-11 22:51 ` Alex Williamson
0 siblings, 2 replies; 3+ messages in thread
From: Brett Creeley @ 2025-07-02 16:37 UTC (permalink / raw)
To: jgg, yishaih, shameerali.kolothum.thodi, kevin.tian,
alex.williamson, kvm, linux-kernel
Cc: brett.creeley
When CONFIG_IOMMUFD is enabled and a device is bound to the pds_vfio_pci
driver, the following WARN_ON() trace is seen and probe fails:
WARNING: CPU: 0 PID: 5040 at drivers/vfio/vfio_main.c:317 __vfio_register_dev+0x130/0x140 [vfio]
<...>
pds_vfio_pci 0000:08:00.1: probe with driver pds_vfio_pci failed with error -22
This is because the driver's vfio_device_ops.detach_ioas isn't set.
Fix this by using the generic vfio_iommufd_physical_detach_ioas
function.
Fixes: 38fe3975b4c2 ("vfio/pds: Initial support for pds VFIO driver")
Signed-off-by: Brett Creeley <brett.creeley@amd.com>
---
drivers/vfio/pci/pds/vfio_dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c
index 76a80ae7087b..f6e0253a8a14 100644
--- a/drivers/vfio/pci/pds/vfio_dev.c
+++ b/drivers/vfio/pci/pds/vfio_dev.c
@@ -204,6 +204,7 @@ static const struct vfio_device_ops pds_vfio_ops = {
.bind_iommufd = vfio_iommufd_physical_bind,
.unbind_iommufd = vfio_iommufd_physical_unbind,
.attach_ioas = vfio_iommufd_physical_attach_ioas,
+ .detach_ioas = vfio_iommufd_physical_detach_ioas,
};
const struct vfio_device_ops *pds_vfio_ops_info(void)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] vfio/pds: Fix missing detach_ioas op
2025-07-02 16:37 [PATCH] vfio/pds: Fix missing detach_ioas op Brett Creeley
@ 2025-07-03 6:44 ` Tian, Kevin
2025-07-11 22:51 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Tian, Kevin @ 2025-07-03 6:44 UTC (permalink / raw)
To: Brett Creeley, jgg@ziepe.ca, yishaih@nvidia.com,
shameerali.kolothum.thodi@huawei.com, alex.williamson@redhat.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
> From: Brett Creeley <brett.creeley@amd.com>
> Sent: Thursday, July 3, 2025 12:38 AM
>
> When CONFIG_IOMMUFD is enabled and a device is bound to the
> pds_vfio_pci
> driver, the following WARN_ON() trace is seen and probe fails:
>
> WARNING: CPU: 0 PID: 5040 at drivers/vfio/vfio_main.c:317
> __vfio_register_dev+0x130/0x140 [vfio]
> <...>
> pds_vfio_pci 0000:08:00.1: probe with driver pds_vfio_pci failed with error -
> 22
>
> This is because the driver's vfio_device_ops.detach_ioas isn't set.
>
> Fix this by using the generic vfio_iommufd_physical_detach_ioas
> function.
>
> Fixes: 38fe3975b4c2 ("vfio/pds: Initial support for pds VFIO driver")
> Signed-off-by: Brett Creeley <brett.creeley@amd.com>
It's a surprise to see it caught so late...
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vfio/pds: Fix missing detach_ioas op
2025-07-02 16:37 [PATCH] vfio/pds: Fix missing detach_ioas op Brett Creeley
2025-07-03 6:44 ` Tian, Kevin
@ 2025-07-11 22:51 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2025-07-11 22:51 UTC (permalink / raw)
To: Brett Creeley
Cc: jgg, yishaih, shameerali.kolothum.thodi, kevin.tian, kvm,
linux-kernel
On Wed, 2 Jul 2025 09:37:44 -0700
Brett Creeley <brett.creeley@amd.com> wrote:
> When CONFIG_IOMMUFD is enabled and a device is bound to the pds_vfio_pci
> driver, the following WARN_ON() trace is seen and probe fails:
>
> WARNING: CPU: 0 PID: 5040 at drivers/vfio/vfio_main.c:317 __vfio_register_dev+0x130/0x140 [vfio]
> <...>
> pds_vfio_pci 0000:08:00.1: probe with driver pds_vfio_pci failed with error -22
>
> This is because the driver's vfio_device_ops.detach_ioas isn't set.
>
> Fix this by using the generic vfio_iommufd_physical_detach_ioas
> function.
>
> Fixes: 38fe3975b4c2 ("vfio/pds: Initial support for pds VFIO driver")
> Signed-off-by: Brett Creeley <brett.creeley@amd.com>
> ---
> drivers/vfio/pci/pds/vfio_dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vfio/pci/pds/vfio_dev.c b/drivers/vfio/pci/pds/vfio_dev.c
> index 76a80ae7087b..f6e0253a8a14 100644
> --- a/drivers/vfio/pci/pds/vfio_dev.c
> +++ b/drivers/vfio/pci/pds/vfio_dev.c
> @@ -204,6 +204,7 @@ static const struct vfio_device_ops pds_vfio_ops = {
> .bind_iommufd = vfio_iommufd_physical_bind,
> .unbind_iommufd = vfio_iommufd_physical_unbind,
> .attach_ioas = vfio_iommufd_physical_attach_ioas,
> + .detach_ioas = vfio_iommufd_physical_detach_ioas,
> };
>
> const struct vfio_device_ops *pds_vfio_ops_info(void)
Applied to vfio next branch for v6.17. Thanks,
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-11 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-02 16:37 [PATCH] vfio/pds: Fix missing detach_ioas op Brett Creeley
2025-07-03 6:44 ` Tian, Kevin
2025-07-11 22:51 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).