From: Eric Biggers <ebiggers@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Ard Biesheuvel <ardb@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
Sohil Mehta <sohil.mehta@intel.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: arm/poly1305: fix poly1305_blocks_neon link failure
Date: Fri, 11 Jul 2025 14:34:37 -0700 [thread overview]
Message-ID: <20250711213437.GA4300@quark> (raw)
In-Reply-To: <20250711072404.2629868-1-arnd@kernel.org>
On Fri, Jul 11, 2025 at 09:23:59AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The reference to poly1305_blocks_neon from generated assembler code is
> apparently the reason we had the silly __weak function in the wrapper.
> Removing it introduced a link failure:
>
> ERROR: modpost: "poly1305_blocks_neon" [lib/crypto/arm/poly1305-arm.ko] undefined!
>
> Moving the reference inside of the #if ARMv7 block avoids this problem.
>
> Fixes: 16f9e0cc99ec ("lib/crypto: arm/poly1305: Remove unneeded empty weak function")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I see that the neon code is always built when targetting ARMv7, even in
> configurations without CONFIG_KERNEL_MODE_NEON where it is never called.
> I tried cleaning that up as well but couldn't figure it out.
> ---
> lib/crypto/arm/poly1305-armv4.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks! That's an interesting one... unfortunately the "perlasm" files
are kind of a mess.
To avoid a bisection hazard, I'm replacing the original patch with an
updated version that includes your fix:
https://lore.kernel.org/r/20250711212822.6372-1-ebiggers@kernel.org
- Eric
prev parent reply other threads:[~2025-07-11 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 7:23 [PATCH] lib/crypto: arm/poly1305: fix poly1305_blocks_neon link failure Arnd Bergmann
2025-07-11 21:34 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711213437.GA4300@quark \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sohil.mehta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).