* [PATCH] drm/xe: Remove unused functions
@ 2025-07-13 15:25 linux
2025-07-14 15:00 ` Lucas De Marchi
0 siblings, 1 reply; 2+ messages in thread
From: linux @ 2025-07-13 15:25 UTC (permalink / raw)
To: lucas.demarchi, thomas.hellstrom, rodrigo.vivi
Cc: airlied, simona, intel-xe, dri-devel, linux-kernel,
Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
xe_bo_create_from_data() last use was removed in 2023 by
commit 0e1a47fcabc8 ("drm/xe: Add a helper for DRM device-lifetime BO
create")
xe_rtp_match_first_gslice_fused_off() last use was removed in 2023 by
commit 4e124151fcfc ("drm/xe/dg2: Drop pre-production workarounds")
Remove them, and xe_dss_mask_empty whose last use was by
xe_rtp_match_first_gslice_fused_off().
(Xe has a bunch ofother symbols that have been added but not used,
given how new it is, I've left those, as opposed to these that
had the code that used them removed).
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/gpu/drm/xe/xe_bo.c | 15 ---------------
drivers/gpu/drm/xe/xe_bo.h | 3 ---
drivers/gpu/drm/xe/xe_gt_topology.c | 5 -----
drivers/gpu/drm/xe/xe_gt_topology.h | 2 --
drivers/gpu/drm/xe/xe_rtp.c | 15 ---------------
drivers/gpu/drm/xe/xe_rtp.h | 11 -----------
6 files changed, 51 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 7aa2c17825da..6bd1287869b4 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -2156,21 +2156,6 @@ struct xe_bo *xe_bo_create_pin_map(struct xe_device *xe, struct xe_tile *tile,
return xe_bo_create_pin_map_at(xe, tile, vm, size, ~0ull, type, flags);
}
-struct xe_bo *xe_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,
- const void *data, size_t size,
- enum ttm_bo_type type, u32 flags)
-{
- struct xe_bo *bo = xe_bo_create_pin_map(xe, tile, NULL,
- ALIGN(size, PAGE_SIZE),
- type, flags);
- if (IS_ERR(bo))
- return bo;
-
- xe_map_memcpy_to(xe, &bo->vmap, 0, data, size);
-
- return bo;
-}
-
static void __xe_bo_unpin_map_no_vm(void *arg)
{
xe_bo_unpin_map_no_vm(arg);
diff --git a/drivers/gpu/drm/xe/xe_bo.h b/drivers/gpu/drm/xe/xe_bo.h
index 02ada1fb8a23..89b6e1487971 100644
--- a/drivers/gpu/drm/xe/xe_bo.h
+++ b/drivers/gpu/drm/xe/xe_bo.h
@@ -118,9 +118,6 @@ struct xe_bo *xe_bo_create_pin_map_at_aligned(struct xe_device *xe,
size_t size, u64 offset,
enum ttm_bo_type type, u32 flags,
u64 alignment);
-struct xe_bo *xe_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,
- const void *data, size_t size,
- enum ttm_bo_type type, u32 flags);
struct xe_bo *xe_managed_bo_create_pin_map(struct xe_device *xe, struct xe_tile *tile,
size_t size, u32 flags);
struct xe_bo *xe_managed_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,
diff --git a/drivers/gpu/drm/xe/xe_gt_topology.c b/drivers/gpu/drm/xe/xe_gt_topology.c
index 516c81e3b8dd..b325eb9d3890 100644
--- a/drivers/gpu/drm/xe/xe_gt_topology.c
+++ b/drivers/gpu/drm/xe/xe_gt_topology.c
@@ -288,11 +288,6 @@ xe_dss_mask_group_ffs(const xe_dss_mask_t mask, int groupsize, int groupnum)
return find_next_bit(mask, XE_MAX_DSS_FUSE_BITS, groupnum * groupsize);
}
-bool xe_dss_mask_empty(const xe_dss_mask_t mask)
-{
- return bitmap_empty(mask, XE_MAX_DSS_FUSE_BITS);
-}
-
/**
* xe_gt_topology_has_dss_in_quadrant - check fusing of DSS in GT quadrant
* @gt: GT to check
diff --git a/drivers/gpu/drm/xe/xe_gt_topology.h b/drivers/gpu/drm/xe/xe_gt_topology.h
index a72d26ba0653..c8140704ad4c 100644
--- a/drivers/gpu/drm/xe/xe_gt_topology.h
+++ b/drivers/gpu/drm/xe/xe_gt_topology.h
@@ -41,8 +41,6 @@ xe_gt_topology_mask_last_dss(const xe_dss_mask_t mask)
unsigned int
xe_dss_mask_group_ffs(const xe_dss_mask_t mask, int groupsize, int groupnum);
-bool xe_dss_mask_empty(const xe_dss_mask_t mask);
-
bool
xe_gt_topology_has_dss_in_quadrant(struct xe_gt *gt, int quad);
diff --git a/drivers/gpu/drm/xe/xe_rtp.c b/drivers/gpu/drm/xe/xe_rtp.c
index 29e694bb1219..cc6636f6cd98 100644
--- a/drivers/gpu/drm/xe/xe_rtp.c
+++ b/drivers/gpu/drm/xe/xe_rtp.c
@@ -326,21 +326,6 @@ bool xe_rtp_match_first_render_or_compute(const struct xe_gt *gt,
hwe->engine_id == __ffs(render_compute_mask);
}
-bool xe_rtp_match_first_gslice_fused_off(const struct xe_gt *gt,
- const struct xe_hw_engine *hwe)
-{
- unsigned int dss_per_gslice = 4;
- unsigned int dss;
-
- if (drm_WARN(>_to_xe(gt)->drm, xe_dss_mask_empty(gt->fuse_topo.g_dss_mask),
- "Checking gslice for platform without geometry pipeline\n"))
- return false;
-
- dss = xe_dss_mask_group_ffs(gt->fuse_topo.g_dss_mask, 0, 0);
-
- return dss >= dss_per_gslice;
-}
-
bool xe_rtp_match_not_sriov_vf(const struct xe_gt *gt,
const struct xe_hw_engine *hwe)
{
diff --git a/drivers/gpu/drm/xe/xe_rtp.h b/drivers/gpu/drm/xe/xe_rtp.h
index 4fe736a11c42..86a3f1e4b3dc 100644
--- a/drivers/gpu/drm/xe/xe_rtp.h
+++ b/drivers/gpu/drm/xe/xe_rtp.h
@@ -465,17 +465,6 @@ bool xe_rtp_match_even_instance(const struct xe_gt *gt,
bool xe_rtp_match_first_render_or_compute(const struct xe_gt *gt,
const struct xe_hw_engine *hwe);
-/*
- * xe_rtp_match_first_gslice_fused_off - Match when first gslice is fused off
- *
- * @gt: GT structure
- * @hwe: Engine instance
- *
- * Returns: true if first gslice is fused off, false otherwise.
- */
-bool xe_rtp_match_first_gslice_fused_off(const struct xe_gt *gt,
- const struct xe_hw_engine *hwe);
-
/*
* xe_rtp_match_not_sriov_vf - Match when not on SR-IOV VF device
*
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/xe: Remove unused functions
2025-07-13 15:25 [PATCH] drm/xe: Remove unused functions linux
@ 2025-07-14 15:00 ` Lucas De Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Lucas De Marchi @ 2025-07-14 15:00 UTC (permalink / raw)
To: linux
Cc: thomas.hellstrom, rodrigo.vivi, airlied, simona, intel-xe,
dri-devel, linux-kernel
On Sun, Jul 13, 2025 at 04:25:31PM +0100, linux@treblig.org wrote:
>From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
>xe_bo_create_from_data() last use was removed in 2023 by
>commit 0e1a47fcabc8 ("drm/xe: Add a helper for DRM device-lifetime BO
>create")
>
>xe_rtp_match_first_gslice_fused_off() last use was removed in 2023 by
>commit 4e124151fcfc ("drm/xe/dg2: Drop pre-production workarounds")
>
>Remove them, and xe_dss_mask_empty whose last use was by
>xe_rtp_match_first_gslice_fused_off().
>
>(Xe has a bunch ofother symbols that have been added but not used,
>given how new it is, I've left those, as opposed to these that
>had the code that used them removed).
>
>Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Applied to drm-xe-next!
[1/1] drm/xe: Remove unused functions
commit: 8f3d1c9fb04e2ae018d06b4cacc49e146120facc
thanks
Lucas De Marchi
>---
> drivers/gpu/drm/xe/xe_bo.c | 15 ---------------
> drivers/gpu/drm/xe/xe_bo.h | 3 ---
> drivers/gpu/drm/xe/xe_gt_topology.c | 5 -----
> drivers/gpu/drm/xe/xe_gt_topology.h | 2 --
> drivers/gpu/drm/xe/xe_rtp.c | 15 ---------------
> drivers/gpu/drm/xe/xe_rtp.h | 11 -----------
> 6 files changed, 51 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
>index 7aa2c17825da..6bd1287869b4 100644
>--- a/drivers/gpu/drm/xe/xe_bo.c
>+++ b/drivers/gpu/drm/xe/xe_bo.c
>@@ -2156,21 +2156,6 @@ struct xe_bo *xe_bo_create_pin_map(struct xe_device *xe, struct xe_tile *tile,
> return xe_bo_create_pin_map_at(xe, tile, vm, size, ~0ull, type, flags);
> }
>
>-struct xe_bo *xe_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,
>- const void *data, size_t size,
>- enum ttm_bo_type type, u32 flags)
>-{
>- struct xe_bo *bo = xe_bo_create_pin_map(xe, tile, NULL,
>- ALIGN(size, PAGE_SIZE),
>- type, flags);
>- if (IS_ERR(bo))
>- return bo;
>-
>- xe_map_memcpy_to(xe, &bo->vmap, 0, data, size);
>-
>- return bo;
>-}
>-
> static void __xe_bo_unpin_map_no_vm(void *arg)
> {
> xe_bo_unpin_map_no_vm(arg);
>diff --git a/drivers/gpu/drm/xe/xe_bo.h b/drivers/gpu/drm/xe/xe_bo.h
>index 02ada1fb8a23..89b6e1487971 100644
>--- a/drivers/gpu/drm/xe/xe_bo.h
>+++ b/drivers/gpu/drm/xe/xe_bo.h
>@@ -118,9 +118,6 @@ struct xe_bo *xe_bo_create_pin_map_at_aligned(struct xe_device *xe,
> size_t size, u64 offset,
> enum ttm_bo_type type, u32 flags,
> u64 alignment);
>-struct xe_bo *xe_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,
>- const void *data, size_t size,
>- enum ttm_bo_type type, u32 flags);
> struct xe_bo *xe_managed_bo_create_pin_map(struct xe_device *xe, struct xe_tile *tile,
> size_t size, u32 flags);
> struct xe_bo *xe_managed_bo_create_from_data(struct xe_device *xe, struct xe_tile *tile,
>diff --git a/drivers/gpu/drm/xe/xe_gt_topology.c b/drivers/gpu/drm/xe/xe_gt_topology.c
>index 516c81e3b8dd..b325eb9d3890 100644
>--- a/drivers/gpu/drm/xe/xe_gt_topology.c
>+++ b/drivers/gpu/drm/xe/xe_gt_topology.c
>@@ -288,11 +288,6 @@ xe_dss_mask_group_ffs(const xe_dss_mask_t mask, int groupsize, int groupnum)
> return find_next_bit(mask, XE_MAX_DSS_FUSE_BITS, groupnum * groupsize);
> }
>
>-bool xe_dss_mask_empty(const xe_dss_mask_t mask)
>-{
>- return bitmap_empty(mask, XE_MAX_DSS_FUSE_BITS);
>-}
>-
> /**
> * xe_gt_topology_has_dss_in_quadrant - check fusing of DSS in GT quadrant
> * @gt: GT to check
>diff --git a/drivers/gpu/drm/xe/xe_gt_topology.h b/drivers/gpu/drm/xe/xe_gt_topology.h
>index a72d26ba0653..c8140704ad4c 100644
>--- a/drivers/gpu/drm/xe/xe_gt_topology.h
>+++ b/drivers/gpu/drm/xe/xe_gt_topology.h
>@@ -41,8 +41,6 @@ xe_gt_topology_mask_last_dss(const xe_dss_mask_t mask)
> unsigned int
> xe_dss_mask_group_ffs(const xe_dss_mask_t mask, int groupsize, int groupnum);
>
>-bool xe_dss_mask_empty(const xe_dss_mask_t mask);
>-
> bool
> xe_gt_topology_has_dss_in_quadrant(struct xe_gt *gt, int quad);
>
>diff --git a/drivers/gpu/drm/xe/xe_rtp.c b/drivers/gpu/drm/xe/xe_rtp.c
>index 29e694bb1219..cc6636f6cd98 100644
>--- a/drivers/gpu/drm/xe/xe_rtp.c
>+++ b/drivers/gpu/drm/xe/xe_rtp.c
>@@ -326,21 +326,6 @@ bool xe_rtp_match_first_render_or_compute(const struct xe_gt *gt,
> hwe->engine_id == __ffs(render_compute_mask);
> }
>
>-bool xe_rtp_match_first_gslice_fused_off(const struct xe_gt *gt,
>- const struct xe_hw_engine *hwe)
>-{
>- unsigned int dss_per_gslice = 4;
>- unsigned int dss;
>-
>- if (drm_WARN(>_to_xe(gt)->drm, xe_dss_mask_empty(gt->fuse_topo.g_dss_mask),
>- "Checking gslice for platform without geometry pipeline\n"))
>- return false;
>-
>- dss = xe_dss_mask_group_ffs(gt->fuse_topo.g_dss_mask, 0, 0);
>-
>- return dss >= dss_per_gslice;
>-}
>-
> bool xe_rtp_match_not_sriov_vf(const struct xe_gt *gt,
> const struct xe_hw_engine *hwe)
> {
>diff --git a/drivers/gpu/drm/xe/xe_rtp.h b/drivers/gpu/drm/xe/xe_rtp.h
>index 4fe736a11c42..86a3f1e4b3dc 100644
>--- a/drivers/gpu/drm/xe/xe_rtp.h
>+++ b/drivers/gpu/drm/xe/xe_rtp.h
>@@ -465,17 +465,6 @@ bool xe_rtp_match_even_instance(const struct xe_gt *gt,
> bool xe_rtp_match_first_render_or_compute(const struct xe_gt *gt,
> const struct xe_hw_engine *hwe);
>
>-/*
>- * xe_rtp_match_first_gslice_fused_off - Match when first gslice is fused off
>- *
>- * @gt: GT structure
>- * @hwe: Engine instance
>- *
>- * Returns: true if first gslice is fused off, false otherwise.
>- */
>-bool xe_rtp_match_first_gslice_fused_off(const struct xe_gt *gt,
>- const struct xe_hw_engine *hwe);
>-
> /*
> * xe_rtp_match_not_sriov_vf - Match when not on SR-IOV VF device
> *
>--
>2.50.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-14 15:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-13 15:25 [PATCH] drm/xe: Remove unused functions linux
2025-07-14 15:00 ` Lucas De Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).