Re: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer

[Vladimir Oltean <vladimir.oltean@nxp.com>]

On Mon, Jul 14, 2025 at 01:43:49PM +0300, Wei Fang wrote:
> > On Mon, Jul 14, 2025 at 01:28:04PM +0300, Wei Fang wrote:
> > > I do not understand, the property is to indicate which pin the board is
> > > used to out PPS signal, as I said earlier, these pins are multiplexed with
> > > other devices, so different board design may use different pins to out
> > > this PPS signal.
> > 
> > Did you look at the 'pins' API in ptp, as used by other drivers, to set
> > a function per pin?
> 
> ptp_set_pinfunc()?

You're in the right area, but ptp_set_pinfunc() is an internal function.
I was specifically referring to struct ptp_clock_info :: pin_config, the
verify() function, etc.

> > > The PPS interface (echo x > /sys/class/ptp/ptp0/pps_enable) provided
> > > by the current PTP framework only supports enabling or disabling the
> > > PPS signal. This is obviously limited for PTP devices with multiple channels.
> > 
> > For what we call "PPS" I think you should be looking at the periodic
> > output (perout) function. "PPS" is to emit events towards the local
> > system.
> 
> The driver supports both PPS and PEROUT.

Ok, I noticed patch 3 but missed patch 4. Anyway, the role of
PTP_CLK_REQ_PPS is to emit events which can be monitored on the
/dev/ppsN char device. It shouldn't have anything to do with external
pins.