[PATCH] media: atomisp: put trailing statement on it's own line

[PATCH] media: atomisp: put trailing statement on it's own line

[Evangelos Ribeiro Tzaras]

Fix checkpatch error "ERROR: trailing statements should be on next line"
in ia_css_formats.host.c:47.

Signed-off-by: Evangelos Ribeiro Tzaras <devrtz@fortysixandtwo.eu>
---

Hey, this is my first patch
(done as part of a workshop at DebConf25),
I appreciate any feedback, thanks!
---
 .../atomisp/pci/isp/kernels/fc/fc_1.0/ia_css_formats.host.c    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/fc/fc_1.0/ia_css_formats.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/fc/fc_1.0/ia_css_formats.host.c
index bae1ca2cd505..9a4f9cc40bfa 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/fc/fc_1.0/ia_css_formats.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/fc/fc_1.0/ia_css_formats.host.c
@@ -44,7 +44,8 @@ ia_css_formats_dump(
     const struct sh_css_isp_formats_params *formats,
     unsigned int level)
 {
-	if (!formats) return;
+	if (!formats)
+		return;
 	ia_css_debug_dtrace(level, "\t%-32s = %d\n",
 			    "video_full_range_flag", formats->video_full_range_flag);
 }
-- 
2.50.0

Re: [PATCH] media: atomisp: put trailing statement on it's own line

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 4:22 PM Evangelos Ribeiro Tzaras
<devrtz@fortysixandtwo.eu> wrote:
>
> Fix checkpatch error "ERROR: trailing statements should be on next line"
> in ia_css_formats.host.c:47.

Is this the only single occurrence of such a problem in the whole driver?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] media: atomisp: put trailing statement on it's own line

[Andy Shevchenko]

On Mon, Jul 14, 2025 at 8:50 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Jul 14, 2025 at 4:22 PM Evangelos Ribeiro Tzaras
> <devrtz@fortysixandtwo.eu> wrote:
> >
> > Fix checkpatch error "ERROR: trailing statements should be on next line"
> > in ia_css_formats.host.c:47.
>
> Is this the only single occurrence of such a problem in the whole driver?

There is another patch floating around targeting the same issue,
please coordinate and send only a few patches or ideally just one
against the whole driver (perhaps excluding i2c folder as Hans
actively working on it).


-- 
With Best Regards,
Andy Shevchenko