* [PATCH net-next] ipv6: mcast: Simplify mld_clear_{report|query}()
@ 2025-07-14 14:01 Yue Haibing
2025-07-14 15:27 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Yue Haibing @ 2025-07-14 14:01 UTC (permalink / raw)
To: davem, dsahern, edumazet, kuba, pabeni, horms
Cc: netdev, linux-kernel, yuehaibing
Use __skb_queue_purge() instead of re-implementing it.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
net/ipv6/mcast.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c
index 8aecdd85a6ae..36ca27496b3c 100644
--- a/net/ipv6/mcast.c
+++ b/net/ipv6/mcast.c
@@ -845,21 +845,15 @@ static void mld_clear_delrec(struct inet6_dev *idev)
static void mld_clear_query(struct inet6_dev *idev)
{
- struct sk_buff *skb;
-
spin_lock_bh(&idev->mc_query_lock);
- while ((skb = __skb_dequeue(&idev->mc_query_queue)))
- kfree_skb(skb);
+ __skb_queue_purge(&idev->mc_query_queue);
spin_unlock_bh(&idev->mc_query_lock);
}
static void mld_clear_report(struct inet6_dev *idev)
{
- struct sk_buff *skb;
-
spin_lock_bh(&idev->mc_report_lock);
- while ((skb = __skb_dequeue(&idev->mc_report_queue)))
- kfree_skb(skb);
+ __skb_queue_purge(&idev->mc_report_queue);
spin_unlock_bh(&idev->mc_report_lock);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: mcast: Simplify mld_clear_{report|query}()
2025-07-14 14:01 [PATCH net-next] ipv6: mcast: Simplify mld_clear_{report|query}() Yue Haibing
@ 2025-07-14 15:27 ` Simon Horman
2025-07-15 2:45 ` Yue Haibing
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2025-07-14 15:27 UTC (permalink / raw)
To: Yue Haibing; +Cc: davem, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel
On Mon, Jul 14, 2025 at 10:01:27PM +0800, Yue Haibing wrote:
> Use __skb_queue_purge() instead of re-implementing it.
Hi,
I think some mention of the changed drop reason is
warranted here.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: mcast: Simplify mld_clear_{report|query}()
2025-07-14 15:27 ` Simon Horman
@ 2025-07-15 2:45 ` Yue Haibing
0 siblings, 0 replies; 3+ messages in thread
From: Yue Haibing @ 2025-07-15 2:45 UTC (permalink / raw)
To: Simon Horman; +Cc: davem, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel
On 2025/7/14 23:27, Simon Horman wrote:
> On Mon, Jul 14, 2025 at 10:01:27PM +0800, Yue Haibing wrote:
>> Use __skb_queue_purge() instead of re-implementing it.
>
> Hi,
>
> I think some mention of the changed drop reason is
> warranted here.
Sure, thanks.
>
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> ...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-15 2:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-14 14:01 [PATCH net-next] ipv6: mcast: Simplify mld_clear_{report|query}() Yue Haibing
2025-07-14 15:27 ` Simon Horman
2025-07-15 2:45 ` Yue Haibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).