From: <fan.yu9@zte.com.cn>
To: <kuba@kernel.org>
Cc: <edumazet@google.com>, <kuniyu@amazon.com>,
<ncardwell@google.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <yang.yang29@zte.com.cn>,
<xu.xin16@zte.com.cn>, <tu.qiang35@zte.com.cn>,
<jiang.kun2@zte.com.cn>, <pabeni@redhat.com>, <horms@kernel.org>
Subject: Re: [PATCH net-next v4] tcp: extend tcp_retransmit_skb tracepoint with failure reasons
Date: Tue, 15 Jul 2025 23:13:25 +0800 (CST) [thread overview]
Message-ID: <20250715231325415aMAZWoPQiUJ2Fe-ongTRW@zte.com.cn> (raw)
In-Reply-To: <20250715072058.12f343bb@kernel.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 833 bytes --]
> > I agree that some of the result types (e.g., ENOMEM, END_SEQ_ERROR)
> > may be redundant or unlikely in practice. If we focus only on the most
> > critical cases, would the following subset be more acceptable?
> > - TCP_RETRANS_FAIL_QUEUED (packet stuck in host/driver queue)
> > - TCP_RETRANS_FAIL_ZERO_WINDOW (receiver window closed)
> > - TCP_RETRANS_FAIL_ROUTE (routing issues)
> > - TCP_RETRANS_FAIL_DEFAULT (catch-all for unexpected failures)
>
> Isn't it enough to add the retval to the tracepoint?
> All the cases we care about already have meaningful and distinct error
> codes.
Hi Jakub,
I agree that using existing error codes (retval) in
could be a simpler and more maintainable approach.
Instead of introducing new TCP_RETRANS_* enums, I’ll directly
pass the retval to the tracepoint in patch v5.
[-- Attachment #1.1.2: Type: text/html , Size: 1014 bytes --]
prev parent reply other threads:[~2025-07-15 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 2:01 [PATCH net-next v4] tcp: extend tcp_retransmit_skb tracepoint with failure reasons fan.yu9
2025-07-14 23:46 ` Jakub Kicinski
2025-07-15 4:35 ` fan.yu9
2025-07-15 14:20 ` Jakub Kicinski
2025-07-15 15:13 ` fan.yu9 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715231325415aMAZWoPQiUJ2Fe-ongTRW@zte.com.cn \
--to=fan.yu9@zte.com.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiang.kun2@zte.com.cn \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tu.qiang35@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).