From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Usyskin <alexander.usyskin@intel.com>
Cc: Reuven Abliyev <reuven.abliyev@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [char-misc-next v3 1/5] mei: set parent for char device
Date: Wed, 16 Jul 2025 11:47:09 +0200 [thread overview]
Message-ID: <2025071614-approach-snarl-90d7@gregkh> (raw)
In-Reply-To: <20250709151344.104942-2-alexander.usyskin@intel.com>
On Wed, Jul 09, 2025 at 06:13:40PM +0300, Alexander Usyskin wrote:
> Connect char device to parent device to avoid
> parent device unload while char device is
> still held open by user-space.
Again, this changelog text is not right. The parent pointer has nothing
to do with "unloading" anything. It has everything to do with placing
the device in the proper place in sysfs. So please show a before/after
location of what happens when this patch is applied to make it more
obvious what is happening here.
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-16 9:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 15:13 [char-misc-next v3 0/5] mei: fix mei_device lifetime Alexander Usyskin
2025-07-09 15:13 ` [char-misc-next v3 1/5] mei: set parent for char device Alexander Usyskin
2025-07-10 5:31 ` Greg Kroah-Hartman
2025-07-16 9:47 ` Greg Kroah-Hartman [this message]
2025-07-09 15:13 ` [char-misc-next v3 2/5] mei: make char device control its own lifetime Alexander Usyskin
2025-07-16 9:54 ` Greg Kroah-Hartman
2025-07-17 11:54 ` Usyskin, Alexander
2025-07-09 15:13 ` [char-misc-next v3 3/5] mei: bus: use cldev in prints Alexander Usyskin
2025-07-09 15:13 ` [char-misc-next v3 4/5] mei: more prints with client prefix Alexander Usyskin
2025-07-09 15:13 ` [char-misc-next v3 5/5] mei: hook mei_device on class device Alexander Usyskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071614-approach-snarl-90d7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reuven.abliyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).