* [PATCH RESEND] drm: Use strscpy() instead of strscpy_pad()
@ 2025-05-21 23:18 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-05-21 23:18 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: Thorsten Blum, dri-devel, linux-kernel
kzalloc() already zero-initializes the destination buffers, making
strscpy() sufficient for safely copying the names. The additional
NUL-padding performed by strscpy_pad() is unnecessary.
If the destination buffer has a fixed length, strscpy() automatically
determines its size using sizeof() when the argument is omitted. This
makes the explicit size arguments unnecessary.
No functional changes intended.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/gpu/drm/drm_property.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c
index 596272149a35..47f2891f3f06 100644
--- a/drivers/gpu/drm/drm_property.c
+++ b/drivers/gpu/drm/drm_property.c
@@ -128,7 +128,7 @@ struct drm_property *drm_property_create(struct drm_device *dev,
property->num_values = num_values;
INIT_LIST_HEAD(&property->enum_list);
- strscpy_pad(property->name, name, DRM_PROP_NAME_LEN);
+ strscpy(property->name, name);
list_add_tail(&property->head, &dev->mode_config.property_list);
@@ -421,7 +421,7 @@ int drm_property_add_enum(struct drm_property *property,
if (!prop_enum)
return -ENOMEM;
- strscpy_pad(prop_enum->name, name, DRM_PROP_NAME_LEN);
+ strscpy(prop_enum->name, name);
prop_enum->value = value;
property->values[index] = value;
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH RESEND] drm: Use strscpy() instead of strscpy_pad()
@ 2025-06-19 14:51 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-06-19 14:51 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: Thorsten Blum, dri-devel, linux-kernel
kzalloc() already zero-initializes the destination buffers, making
strscpy() sufficient for safely copying the names. The additional
NUL-padding performed by strscpy_pad() is unnecessary.
If the destination buffer has a fixed length, strscpy() automatically
determines its size using sizeof() when the argument is omitted. This
makes the explicit size arguments unnecessary.
No functional changes intended.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/gpu/drm/drm_property.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c
index 596272149a35..47f2891f3f06 100644
--- a/drivers/gpu/drm/drm_property.c
+++ b/drivers/gpu/drm/drm_property.c
@@ -128,7 +128,7 @@ struct drm_property *drm_property_create(struct drm_device *dev,
property->num_values = num_values;
INIT_LIST_HEAD(&property->enum_list);
- strscpy_pad(property->name, name, DRM_PROP_NAME_LEN);
+ strscpy(property->name, name);
list_add_tail(&property->head, &dev->mode_config.property_list);
@@ -421,7 +421,7 @@ int drm_property_add_enum(struct drm_property *property,
if (!prop_enum)
return -ENOMEM;
- strscpy_pad(prop_enum->name, name, DRM_PROP_NAME_LEN);
+ strscpy(prop_enum->name, name);
prop_enum->value = value;
property->values[index] = value;
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH RESEND] drm: Use strscpy() instead of strscpy_pad()
@ 2025-07-16 21:14 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-07-16 21:14 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: Thorsten Blum, dri-devel, linux-kernel
kzalloc() already zero-initializes the destination buffers, making
strscpy() sufficient for safely copying the names. The additional
NUL-padding performed by strscpy_pad() is unnecessary.
If the destination buffer has a fixed length, strscpy() automatically
determines its size using sizeof() when the argument is omitted. This
makes the explicit size arguments unnecessary.
No functional changes intended.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/gpu/drm/drm_property.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c
index 596272149a35..47f2891f3f06 100644
--- a/drivers/gpu/drm/drm_property.c
+++ b/drivers/gpu/drm/drm_property.c
@@ -128,7 +128,7 @@ struct drm_property *drm_property_create(struct drm_device *dev,
property->num_values = num_values;
INIT_LIST_HEAD(&property->enum_list);
- strscpy_pad(property->name, name, DRM_PROP_NAME_LEN);
+ strscpy(property->name, name);
list_add_tail(&property->head, &dev->mode_config.property_list);
@@ -421,7 +421,7 @@ int drm_property_add_enum(struct drm_property *property,
if (!prop_enum)
return -ENOMEM;
- strscpy_pad(prop_enum->name, name, DRM_PROP_NAME_LEN);
+ strscpy(prop_enum->name, name);
prop_enum->value = value;
property->values[index] = value;
--
2.50.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH RESEND] drm: Use strscpy() instead of strscpy_pad()
@ 2025-08-17 23:19 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2025-08-17 23:19 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
Cc: Thorsten Blum, dri-devel, linux-kernel
kzalloc() already zero-initializes the destination buffers, making
strscpy() sufficient for safely copying the names. The additional
NUL-padding performed by strscpy_pad() is unnecessary.
If the destination buffer has a fixed length, strscpy() automatically
determines its size using sizeof() when the argument is omitted. This
makes the explicit size arguments unnecessary.
No functional changes intended.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/gpu/drm/drm_property.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c
index 596272149a35..47f2891f3f06 100644
--- a/drivers/gpu/drm/drm_property.c
+++ b/drivers/gpu/drm/drm_property.c
@@ -128,7 +128,7 @@ struct drm_property *drm_property_create(struct drm_device *dev,
property->num_values = num_values;
INIT_LIST_HEAD(&property->enum_list);
- strscpy_pad(property->name, name, DRM_PROP_NAME_LEN);
+ strscpy(property->name, name);
list_add_tail(&property->head, &dev->mode_config.property_list);
@@ -421,7 +421,7 @@ int drm_property_add_enum(struct drm_property *property,
if (!prop_enum)
return -ENOMEM;
- strscpy_pad(prop_enum->name, name, DRM_PROP_NAME_LEN);
+ strscpy(prop_enum->name, name);
prop_enum->value = value;
property->values[index] = value;
--
2.50.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-17 23:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-16 21:14 [PATCH RESEND] drm: Use strscpy() instead of strscpy_pad() Thorsten Blum
-- strict thread matches above, loose matches on Subject: below --
2025-08-17 23:19 Thorsten Blum
2025-06-19 14:51 Thorsten Blum
2025-05-21 23:18 Thorsten Blum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).