From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 220542FC3D0 for ; Thu, 17 Jul 2025 19:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752781222; cv=none; b=iLAJyKTucvFUEgr2SqL6q2O0xH90X2lrosi5DTaROqzO52KedmAEADPNGknuPELLkFN7gkjO34gAe24hDsY/ff7vraGI92gAbrHE613lblqjtno7uIzU716U/1lDebgb3jtl9zTQHwr9z9pWAJ6RzNa17NgYHsg+OPEAWenJ+Bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752781222; c=relaxed/simple; bh=AliCz80P40/+u4uyNacd4d5aJesJDRNV1iyzNivQibw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=krrP2XwCAhL0Ys5Y5r7p7S2q0ZeG/5wT7lvJQUge6kh3U6uYWiaN2An2xkEQeiYpBprBSn5+2EqMzXcoF6zy7SlPM3jx8HzaTIDoRYJ8R4Y/c32r5eskzkmSXlmkcOE54WXdgc2bmi7NsJ+u690SHzi3oRLh4U6bpIK3uyhjUjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e9aIsDJ+; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e9aIsDJ+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752781220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/2+uUVHwQq1KQQUsEuaD+AV1NGVtRzgW4E0uexw5t0=; b=e9aIsDJ+GVy0eiydU7zQ0tF9O7oZerX+TGTQHuycjDVJYI4POMrzpfliKZuzRVVMBdb8k6 L15Q+innQBW1xaVLy9KS5C9+FvzOtUnxKUx/srJi+ShKQ8NjEuWo45p2R5fQH++1o+1Rej WWNjqVmdrMh5zCVpZOk3fZD1uDcTgvk= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-dLeunbOkMiyil7ISVqTZWw-1; Thu, 17 Jul 2025 15:40:17 -0400 X-MC-Unique: dLeunbOkMiyil7ISVqTZWw-1 X-Mimecast-MFC-AGG-ID: dLeunbOkMiyil7ISVqTZWw_1752781217 Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-3df57df1eb3so1949285ab.2 for ; Thu, 17 Jul 2025 12:40:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752781217; x=1753386017; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z/2+uUVHwQq1KQQUsEuaD+AV1NGVtRzgW4E0uexw5t0=; b=tac6jAfs1FkzdsC3j6ssxYR0SU75EYYmW/p3qdVLIdFBW/R3owmXL+j3RZyEyZuFEj UIOjNRM+DabnXYqqn9u9AnvJ0utxtShanhpJG1kwp/31L+PJh3++CPT/iehHcNhDqxDg rbgYW6DgbINqhETkyjj37FmuqaaJyzImOqPagLMunBtwURcSMynAd4NTC7AcpTx4r2Y2 7/JHEl2h83+tYO3qc458nkdWi0XtQuzuUnELvjoj4vEEcYlXgZ2KQMb+LdyxwmmVSI6N FxXds08p4vGatUJNdU5aKdTh/3BHSmIWYlkQ+8vokdkczi7Nx3Ps3yfHJlf37LnjtnbA EJNA== X-Forwarded-Encrypted: i=1; AJvYcCVOjxzsSA7QEh5ewjBAR4Sviamsr5wIqbXjZ++pVrN0PQlql94+VyeRic59QIBSF9ZxtbSXqxNYZlMPeyI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0kyVlA7kQ/OhDhwl+OFRK94avwtr80A0DgPuHbCaCqiO6aSV4 sm/i5LljV3mNqeqmKlnNE8SjRhLUySq7YKtv7lZ6v1MIzpUqbUpUMb6MrFsb5eEIGq9lQpBz5ew QCu3gnhI2CajWAzXtKfUmPkFV0EC+Mu6V4nyVdK892rp7Wz+lbC1fq7dEH2k+IT0yJw== X-Gm-Gg: ASbGncu1C9Qd9ukjQwI4XEuKPwBd4JnXrhbk+S2XqwOVOXFQSg9a4Sh5evnaAOLcCHq wpIeBqA31CX+UKXpoPBUC1YTGXsC/mZWDYXHzhDv9YLuMr00mwv+mfZkwwYnhlpUKsp983QvZ7O TenLfUVWkkW5MB8u4ITGxlUexrl+8mgucHcZ/9uAWn0qraRdv/Lzuus1/risVls46J5M6BXIqUf 7+wvAogxf1ZehDQWAZ7DxAHRAhosUZ+XRyQ//mTVgbUUjM+iIJ4l/z/DQWlGNgSUjrvsaGC24Pt m2Pv9f3T+aDYT8Oeu0c9WimNm95zZCimO5zA320zMFw= X-Received: by 2002:a05:6e02:3113:b0:3dc:87c7:a5a5 with SMTP id e9e14a558f8ab-3e28245f8e8mr24904015ab.5.1752781216871; Thu, 17 Jul 2025 12:40:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGV+0O7JW3kdwf9CMHiAKbvK9a8rLbbPPt/Na4CzthvG+duCf1EvXTna86WdjzvTwHw9uYkCw== X-Received: by 2002:a05:6e02:3113:b0:3dc:87c7:a5a5 with SMTP id e9e14a558f8ab-3e28245f8e8mr24903925ab.5.1752781216429; Thu, 17 Jul 2025 12:40:16 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e2462299c0sm53651965ab.48.2025.07.17.12.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 12:40:15 -0700 (PDT) Date: Thu, 17 Jul 2025 13:40:14 -0600 From: Alex Williamson To: Krzysztof Kozlowski Cc: Nipun Gupta , Nikhil Agarwal , Pieter Jansen van Vuuren , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap , stable@vger.kernel.org Subject: Re: [PATCH] vfio: cdx: Fix missing GENERIC_MSI_IRQ on compile test Message-ID: <20250717134014.16b97da5.alex.williamson@redhat.com> In-Reply-To: <20250717091053.129175-2-krzysztof.kozlowski@linaro.org> References: <20250717091053.129175-2-krzysztof.kozlowski@linaro.org> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 17 Jul 2025 11:10:54 +0200 Krzysztof Kozlowski wrote: > VFIO_CDX driver uses msi_domain_alloc_irqs() which is provided by > non-user-visible GENERIC_MSI_IRQ, thus it should select that option > directly. >=20 > VFIO_CDX depends on CDX_BUS, which also will select GENERIC_MSI_IRQ > (separate fix), nevertheless driver should poll what is being used there > instead of relying on bus Kconfig. This seems like a recipe for an explosion of Kconfig noise. If the bus fundamentally depends on a config option, as proposed in the separate fix, I don't see that a driver dependent on that bus needs to duplicate the config selections. IMO this is sufficiently fixed updating drivers/cdx/{Kconfig,Makefile}. Thanks, Alex =20 > Without the fix on CDX_BUS compile test fails: >=20 > drivers/vfio/cdx/intr.c: In function =E2=80=98vfio_cdx_msi_enable=E2=80= =99: > drivers/vfio/cdx/intr.c:41:15: error: implicit declaration of function = =E2=80=98msi_domain_alloc_irqs=E2=80=99; > did you mean =E2=80=98irq_domain_alloc_irqs=E2=80=99? [-Wimplicit-fun= ction-declaration] >=20 > Reported-by: Randy Dunlap > Closes: https://lore.kernel.org/r/4a6fd102-f8e0-42f3-b789-6e3340897032@in= fradead.org/ > Fixes: 848e447e000c ("vfio/cdx: add interrupt support") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- > drivers/vfio/cdx/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/vfio/cdx/Kconfig b/drivers/vfio/cdx/Kconfig > index e6de0a0caa32..90cf3dee5dba 100644 > --- a/drivers/vfio/cdx/Kconfig > +++ b/drivers/vfio/cdx/Kconfig > @@ -9,6 +9,7 @@ config VFIO_CDX > tristate "VFIO support for CDX bus devices" > depends on CDX_BUS > select EVENTFD > + select GENERIC_MSI_IRQ > help > Driver to enable VFIO support for the devices on CDX bus. > This is required to make use of CDX devices present in