From: Andrew Morton <akpm@linux-foundation.org>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev,
yosryahmed@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm/memcg: make memory.reclaim interface generic
Date: Thu, 17 Jul 2025 15:52:46 -0700 [thread overview]
Message-ID: <20250717155246.1f2a90c76d71b401255f11b9@linux-foundation.org> (raw)
In-Reply-To: <ggavn7jgnti6uhdwlbgmuz4miplyh5zzixgmlye53qmaoh7tkp@3srwgtxrhtld>
On Thu, 17 Jul 2025 15:17:09 -0700 Shakeel Butt <shakeel.butt@linux.dev> wrote:
> On Mon, Jun 23, 2025 at 11:58:49AM -0700, Davidlohr Bueso wrote:
> > +
> > +int user_proactive_reclaim(char *buf, struct mem_cgroup *memcg, pg_data_t *pgdat)
> > +{
> > + unsigned int nr_retries = MAX_RECLAIM_RETRIES;
> > + unsigned long nr_to_reclaim, nr_reclaimed = 0;
> > + int swappiness = -1;
> > + char *old_buf, *start;
> > + substring_t args[MAX_OPT_ARGS];
> > +
> > + if (!buf || (!memcg && !pgdat))
>
> I don't think this series is adding a use-case where both memcg and
> pgdat are non-NULL, so let's error out on that as well.
As a followup, please. This has been in -next for four weeks and I'd
prefer not to have to route around it (again).
next prev parent reply other threads:[~2025-07-17 22:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 18:58 [PATCH -next v2 0/4] mm: per-node proactive reclaim Davidlohr Bueso
2025-06-23 18:58 ` [PATCH 1/4] mm/vmscan: respect psi_memstall region in node reclaim Davidlohr Bueso
2025-06-25 17:08 ` Shakeel Butt
2025-07-17 1:44 ` Roman Gushchin
2025-06-23 18:58 ` [PATCH 2/4] mm/memcg: make memory.reclaim interface generic Davidlohr Bueso
2025-06-23 21:45 ` Andrew Morton
2025-06-23 23:36 ` Davidlohr Bueso
2025-06-24 18:26 ` Klara Modin
2025-07-17 1:58 ` Roman Gushchin
2025-07-17 16:35 ` Davidlohr Bueso
2025-07-17 22:17 ` Shakeel Butt
2025-07-17 22:52 ` Andrew Morton [this message]
2025-07-17 23:56 ` Davidlohr Bueso
2025-07-18 0:17 ` Shakeel Butt
2025-06-23 18:58 ` [PATCH 3/4] mm/vmscan: make __node_reclaim() more generic Davidlohr Bueso
2025-07-17 2:03 ` Roman Gushchin
2025-07-17 22:25 ` Shakeel Butt
2025-06-23 21:50 ` [PATCH -next v2 0/4] mm: per-node proactive reclaim Andrew Morton
2025-07-16 0:24 ` Andrew Morton
2025-07-16 15:15 ` Shakeel Butt
[not found] ` <20250623185851.830632-5-dave@stgolabs.net>
2025-06-25 23:10 ` [PATCH 4/4] mm: introduce per-node proactive reclaim interface Shakeel Butt
2025-06-27 19:07 ` SeongJae Park
2025-07-17 2:46 ` Roman Gushchin
2025-07-17 16:26 ` Davidlohr Bueso
2025-07-17 22:46 ` Andrew Morton
2025-07-17 6:49 ` Hillf Danton
2025-07-17 7:39 ` Michal Hocko
2025-07-17 22:28 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717155246.1f2a90c76d71b401255f11b9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).