From: Brigham Campbell <me@brighamcampbell.com>
To: dianders@chromium.org, tejasvipin76@gmail.com,
diogo.ivo@tecnico.ulisboa.pt, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Brigham Campbell <me@brighamcampbell.com>
Subject: [PATCH v3 0/4] drm: Fix bug in panel driver, update MIPI support macros
Date: Thu, 17 Jul 2025 10:40:48 -0600 [thread overview]
Message-ID: <20250717164053.284969-1-me@brighamcampbell.com> (raw)
This series removes the unintuitive mipi_dsi_generic_write_seq() macro
and related mipi_dsi_generic_write_chatty() method from the drm
subsystem. This is in accordance with a TODO item from Douglas Anderson
in the drm subsystem documentation. Tejas Vipin (among others) has
largely spearheaded this effort up until now, converting MIPI panel
drivers one at a time.
The second patch of the series removes the last remaining references to
mipi_dsi_generic_write_seq() in the jdi-lpm102a188a driver and updates
the driver to use the undeprecated _multi variants of MIPI functions. It
fixes a bug in the driver's unprepare function and cleans up duplicated
code using the new mipi_dsi_dual macro introduced in the first patch.
changes to v4:
- Fix whitespace (I forgot to run checkpatch. Thanks for your patience
as I familiarize myself with the kernel development process)
- Initialize mipi_dsi_multi_context struct
changes to v3:
- Define new mipi_dsi_dual macro in drm_mipi_dsi.h to reduce code
duplication.
- Fix bug in lpm102a188a panel driver's unprepare function which causes
it to return a nonsensical value.
- Make lpm102a188a panel driver's unprepare function send "display off"
and "enter sleep mode" commands to both serial interfaces regardless
of whether an error occurred when sending the last command.
changes to v2:
- Remove all usages of deprecated MIPI functions from jdi-lpm102a188a
driver instead of just mipi_dsi_generic_write_seq().
- Update TODO item in drm documentation instead of removing it
entirely.
Brigham Campbell (4):
drm: Create mipi_dsi_dual macro
drm/panel: jdi-lpm102a188a: Fix bug and clean up driver
drm: Remove unused MIPI write seq and chatty functions
drm: docs: Update task from drm TODO list
Documentation/gpu/todo.rst | 22 +-
drivers/gpu/drm/drm_mipi_dsi.c | 34 +--
drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 197 ++++++------------
include/drm/drm_mipi_dsi.h | 47 +++--
4 files changed, 98 insertions(+), 202 deletions(-)
v3: https://lore.kernel.org/all/20250717065757.246122-1-me@brighamcampbell.com/
v2: https://lore.kernel.org/all/20250708073901.90027-1-me@brighamcampbell.com/
v1: https://lore.kernel.org/all/20250707075659.75810-1-me@brighamcampbell.com/
base-commit: 667efb341917bde19f5d7517b65defcdaed67c9e
--
2.50.1
next reply other threads:[~2025-07-17 16:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 16:40 Brigham Campbell [this message]
2025-07-17 16:40 ` [PATCH v4 1/4] drm: Create mipi_dsi_dual macro Brigham Campbell
2025-07-18 16:10 ` Doug Anderson
2025-07-18 17:17 ` Brigham Campbell
2025-07-18 20:32 ` Doug Anderson
2025-07-17 16:40 ` [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver Brigham Campbell
2025-07-18 10:43 ` Diogo Ivo
2025-07-18 16:11 ` Doug Anderson
2025-07-19 17:10 ` Diogo Ivo
2025-07-20 7:50 ` Brigham Campbell
2025-07-20 11:19 ` Diogo Ivo
2025-07-21 15:46 ` Doug Anderson
2025-07-17 16:40 ` [PATCH v4 3/4] drm: Remove unused MIPI write seq and chatty functions Brigham Campbell
2025-07-17 16:40 ` [PATCH v4 4/4] drm: docs: Update task from drm TODO list Brigham Campbell
2025-07-17 18:41 ` [PATCH v3 0/4] drm: Fix bug in panel driver, update MIPI support macros Brigham Campbell
-- strict thread matches above, loose matches on Subject: below --
2025-07-17 6:57 Brigham Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717164053.284969-1-me@brighamcampbell.com \
--to=me@brighamcampbell.com \
--cc=dianders@chromium.org \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tejasvipin76@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).