linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: serial: 8250: spacemit: set clocks property as required
@ 2025-07-18 15:04 Yixun Lan
  2025-07-21  0:39 ` Rob Herring (Arm)
  0 siblings, 1 reply; 2+ messages in thread
From: Yixun Lan @ 2025-07-18 15:04 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Lubomir Rintel, devicetree, Alex Elder
  Cc: linux-kernel, linux-serial, linux-riscv, spacemit, Yixun Lan

In SpacemiT's K1 SoC, the clocks for UART are mandatory needed, so
for DT, both clocks and clock-names property should be set as required.

Fixes: 2c0594f9f062 ("dt-bindings: serial: 8250: support an optional second clock")
Signed-off-by: Yixun Lan <dlan@gentoo.org>
---
 Documentation/devicetree/bindings/serial/8250.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
index 33d2016b65090d0df257f9780ad8d5e05f7ce798..2c7604ed2a41d029276d3ebe9a3960a8dd44a9d9 100644
--- a/Documentation/devicetree/bindings/serial/8250.yaml
+++ b/Documentation/devicetree/bindings/serial/8250.yaml
@@ -239,7 +239,9 @@ if:
       contains:
         const: spacemit,k1-uart
 then:
-  required: [clock-names]
+  required:
+    - clocks
+    - clock-names
   properties:
     clocks:
       minItems: 2

---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250718-01-k1-uart-binding-6a996b6e2ff2

Best regards,
-- 
Yixun Lan


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: serial: 8250: spacemit: set clocks property as required
  2025-07-18 15:04 [PATCH] dt-bindings: serial: 8250: spacemit: set clocks property as required Yixun Lan
@ 2025-07-21  0:39 ` Rob Herring (Arm)
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-07-21  0:39 UTC (permalink / raw)
  To: Yixun Lan
  Cc: linux-riscv, spacemit, Greg Kroah-Hartman, Krzysztof Kozlowski,
	Alex Elder, linux-kernel, devicetree, linux-serial, Conor Dooley,
	Jiri Slaby, Lubomir Rintel


On Fri, 18 Jul 2025 23:04:37 +0800, Yixun Lan wrote:
> In SpacemiT's K1 SoC, the clocks for UART are mandatory needed, so
> for DT, both clocks and clock-names property should be set as required.
> 
> Fixes: 2c0594f9f062 ("dt-bindings: serial: 8250: support an optional second clock")
> Signed-off-by: Yixun Lan <dlan@gentoo.org>
> ---
>  Documentation/devicetree/bindings/serial/8250.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-21  0:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-18 15:04 [PATCH] dt-bindings: serial: 8250: spacemit: set clocks property as required Yixun Lan
2025-07-21  0:39 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).