[PATCH 1/2] staging: sm750fb: make const arrays static const char * const

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/2] staging: sm750fb: make const arrays static const char * const
@ 2025-07-18  3:49 Ignacio Peña
  2025-07-18  7:44 ` Greg Kroah-Hartman
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ignacio Peña @ 2025-07-18  3:49 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel, Ignacio Peña

Fix checkpatch warning:
"WARNING: static const char * array should probably be
 static const char * const"

This makes both the array and its contents immutable, which is the
intended behavior for these constant string arrays:
- g_fbmode: array of framebuffer mode strings
- fixId: array of framebuffer device names

Signed-off-by: Ignacio Peña <ignacio.pena87@gmail.com>
---
 drivers/staging/sm750fb/sm750.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 1d929aca3..82e01f114 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,7 +33,7 @@
 static int g_hwcursor = 1;
 static int g_noaccel;
 static int g_nomtrr;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
 static const char *g_def_fbmode = "1024x768-32@60";
 static char *g_settings;
 static int g_dualview;
@@ -731,7 +731,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
 		"kernel HELPERS prepared vesa_modes",
 	};
 
-	static const char *fixId[2] = {
+	static const char * const fixId[2] = {
 		"sm750_fb1", "sm750_fb2",
 	};
 
-- 
2.39.5 (Apple Git-154)


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] staging: sm750fb: make const arrays static const char * const
  2025-07-18  3:49 [PATCH 1/2] staging: sm750fb: make const arrays static const char * const Ignacio Peña
@ 2025-07-18  7:44 ` Greg Kroah-Hartman
  2025-07-18 14:53 ` Dan Carpenter
  2025-07-21 23:04 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2025-07-18  7:44 UTC (permalink / raw)
  To: Ignacio Peña; +Cc: linux-staging, linux-kernel

On Thu, Jul 17, 2025 at 11:49:13PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning:
> "WARNING: static const char * array should probably be
>  static const char * const"
> 
> This makes both the array and its contents immutable, which is the
> intended behavior for these constant string arrays:
> - g_fbmode: array of framebuffer mode strings
> - fixId: array of framebuffer device names
> 
> Signed-off-by: Ignacio Peña <ignacio.pena87@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Always test-build your patches so you don't break maintainers workflow
by submitting patches that break the build :(

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] staging: sm750fb: make const arrays static const char * const
  2025-07-18  3:49 [PATCH 1/2] staging: sm750fb: make const arrays static const char * const Ignacio Peña
  2025-07-18  7:44 ` Greg Kroah-Hartman
@ 2025-07-18 14:53 ` Dan Carpenter
  2025-07-21 23:04 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-07-18 14:53 UTC (permalink / raw)
  To: Ignacio Peña; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel

On Thu, Jul 17, 2025 at 11:49:13PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning:
> "WARNING: static const char * array should probably be
>  static const char * const"
> 
> This makes both the array and its contents immutable, which is the
> intended behavior for these constant string arrays:
> - g_fbmode: array of framebuffer mode strings
> - fixId: array of framebuffer device names
> 
> Signed-off-by: Ignacio Peña <ignacio.pena87@gmail.com>

This is a v2 patch.  On the first version of this patch I told you
that it breaks the build.  So I guess now you're trying to fix it
by making fixId const as well?  It's unclear.

Anyway, it still breaks the build.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] staging: sm750fb: make const arrays static const char * const
  2025-07-18  3:49 [PATCH 1/2] staging: sm750fb: make const arrays static const char * const Ignacio Peña
  2025-07-18  7:44 ` Greg Kroah-Hartman
  2025-07-18 14:53 ` Dan Carpenter
@ 2025-07-21 23:04 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-07-21 23:04 UTC (permalink / raw)
  To: Ignacio Peña, Greg Kroah-Hartman
  Cc: llvm, oe-kbuild-all, linux-staging, linux-kernel,
	Ignacio Peña

Hi Ignacio,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Ignacio-Pe-a/checkpatch-warn-when-patch-version-changelog-is-in-wrong-place/20250718-115204
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20250718034913.49300-1-ignacio.pena87%40gmail.com
patch subject: [PATCH 1/2] staging: sm750fb: make const arrays static const char * const
config: x86_64-randconfig-005-20250722 (https://download.01.org/0day-ci/archive/20250722/202507220658.ewPlYtwl-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250722/202507220658.ewPlYtwl-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507220658.ewPlYtwl-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/staging/sm750fb/sm750.c:790:19: error: cannot assign to variable 'g_fbmode' with const-qualified type 'const char *const[2]'
     790 |                 g_fbmode[index] = g_def_fbmode;
         |                 ~~~~~~~~~~~~~~~ ^
   drivers/staging/sm750fb/sm750.c:36:27: note: variable 'g_fbmode' declared const here
      36 | static const char * const g_fbmode[] = {NULL, NULL};
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/sm750fb/sm750.c:792:20: error: cannot assign to variable 'g_fbmode' with const-qualified type 'const char *const[2]'
     792 |                         g_fbmode[index] = g_fbmode[0];
         |                         ~~~~~~~~~~~~~~~ ^
   drivers/staging/sm750fb/sm750.c:36:27: note: variable 'g_fbmode' declared const here
      36 | static const char * const g_fbmode[] = {NULL, NULL};
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/sm750fb/sm750.c:953:17: error: cannot assign to variable 'g_fbmode' with const-qualified type 'const char *const[2]'
     953 |                                 g_fbmode[0] = opt;
         |                                 ~~~~~~~~~~~ ^
   drivers/staging/sm750fb/sm750.c:36:27: note: variable 'g_fbmode' declared const here
      36 | static const char * const g_fbmode[] = {NULL, NULL};
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/sm750fb/sm750.c:957:17: error: cannot assign to variable 'g_fbmode' with const-qualified type 'const char *const[2]'
     957 |                                 g_fbmode[1] = opt;
         |                                 ~~~~~~~~~~~ ^
   drivers/staging/sm750fb/sm750.c:36:27: note: variable 'g_fbmode' declared const here
      36 | static const char * const g_fbmode[] = {NULL, NULL};
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
   4 errors generated.


vim +790 drivers/staging/sm750fb/sm750.c

81dee67e215b23f Sudip Mukherjee         2015-03-03  717  
81dee67e215b23f Sudip Mukherjee         2015-03-03  718  static int lynxfb_set_fbinfo(struct fb_info *info, int index)
81dee67e215b23f Sudip Mukherjee         2015-03-03  719  {
81dee67e215b23f Sudip Mukherjee         2015-03-03  720  	int i;
81dee67e215b23f Sudip Mukherjee         2015-03-03  721  	struct lynxfb_par *par;
e359b6a863e19f2 Mike Rapoport           2015-10-26  722  	struct sm750_dev *sm750_dev;
81dee67e215b23f Sudip Mukherjee         2015-03-03  723  	struct lynxfb_crtc *crtc;
81dee67e215b23f Sudip Mukherjee         2015-03-03  724  	struct lynxfb_output *output;
81dee67e215b23f Sudip Mukherjee         2015-03-03  725  	struct fb_var_screeninfo *var;
81dee67e215b23f Sudip Mukherjee         2015-03-03  726  	struct fb_fix_screeninfo *fix;
81dee67e215b23f Sudip Mukherjee         2015-03-03  727  
81dee67e215b23f Sudip Mukherjee         2015-03-03  728  	const struct fb_videomode *pdb[] = {
81dee67e215b23f Sudip Mukherjee         2015-03-03  729  		lynx750_ext, NULL, vesa_modes,
81dee67e215b23f Sudip Mukherjee         2015-03-03  730  	};
81dee67e215b23f Sudip Mukherjee         2015-03-03  731  	int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE};
d5d66cfea2ca281 Kelsey Skunberg         2019-04-27  732  	static const char * const mdb_desc[] = {
81dee67e215b23f Sudip Mukherjee         2015-03-03  733  		"driver prepared modes",
81dee67e215b23f Sudip Mukherjee         2015-03-03  734  		"kernel prepared default modedb",
81dee67e215b23f Sudip Mukherjee         2015-03-03  735  		"kernel HELPERS prepared vesa_modes",
81dee67e215b23f Sudip Mukherjee         2015-03-03  736  	};
81dee67e215b23f Sudip Mukherjee         2015-03-03  737  
2dce23d6c03f476 Ignacio Peña            2025-07-17  738  	static const char * const fixId[2] = {
81dee67e215b23f Sudip Mukherjee         2015-03-03  739  		"sm750_fb1", "sm750_fb2",
81dee67e215b23f Sudip Mukherjee         2015-03-03  740  	};
81dee67e215b23f Sudip Mukherjee         2015-03-03  741  
81dee67e215b23f Sudip Mukherjee         2015-03-03  742  	int ret, line_length;
81dee67e215b23f Sudip Mukherjee         2015-03-03  743  
81dee67e215b23f Sudip Mukherjee         2015-03-03  744  	ret = 0;
81dee67e215b23f Sudip Mukherjee         2015-03-03  745  	par = (struct lynxfb_par *)info->par;
e359b6a863e19f2 Mike Rapoport           2015-10-26  746  	sm750_dev = par->dev;
81dee67e215b23f Sudip Mukherjee         2015-03-03  747  	crtc = &par->crtc;
81dee67e215b23f Sudip Mukherjee         2015-03-03  748  	output = &par->output;
81dee67e215b23f Sudip Mukherjee         2015-03-03  749  	var = &info->var;
81dee67e215b23f Sudip Mukherjee         2015-03-03  750  	fix = &info->fix;
81dee67e215b23f Sudip Mukherjee         2015-03-03  751  
81dee67e215b23f Sudip Mukherjee         2015-03-03  752  	/* set index */
81dee67e215b23f Sudip Mukherjee         2015-03-03  753  	par->index = index;
81dee67e215b23f Sudip Mukherjee         2015-03-03  754  	output->channel = &crtc->channel;
81dee67e215b23f Sudip Mukherjee         2015-03-03  755  	sm750fb_set_drv(par);
81dee67e215b23f Sudip Mukherjee         2015-03-03  756  
d11ac7cbcc266c6 Sudip Mukherjee         2015-08-07  757  	/*
d11ac7cbcc266c6 Sudip Mukherjee         2015-08-07  758  	 * set current cursor variable and proc pointer,
d11ac7cbcc266c6 Sudip Mukherjee         2015-08-07  759  	 * must be set after crtc member initialized
d11ac7cbcc266c6 Sudip Mukherjee         2015-08-07  760  	 */
fdc234d85210d91 Benjamin Philip         2021-07-28  761  	crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024;
e359b6a863e19f2 Mike Rapoport           2015-10-26  762  	crtc->cursor.mmio = sm750_dev->pvReg +
e359b6a863e19f2 Mike Rapoport           2015-10-26  763  		0x800f0 + (int)crtc->channel * 0x140;
81dee67e215b23f Sudip Mukherjee         2015-03-03  764  
81dee67e215b23f Sudip Mukherjee         2015-03-03  765  	pr_info("crtc->cursor.mmio = %p\n", crtc->cursor.mmio);
cd33da26036ea54 Christopher Carbone     2022-08-23  766  	crtc->cursor.max_h = 64;
cd33da26036ea54 Christopher Carbone     2022-08-23  767  	crtc->cursor.max_w = 64;
39f9137268ee3df Benjamin Philip         2021-07-26  768  	crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.max_w * 2 / 8;
e359b6a863e19f2 Mike Rapoport           2015-10-26  769  	crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset;
81dee67e215b23f Sudip Mukherjee         2015-03-03  770  
3de08a2d14ff8c7 Lorenzo Stoakes         2015-03-20  771  	memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);
f7c8a046577e09d Thomas Zimmermann       2023-11-27  772  	if (!g_hwcursor)
52d0744d751d8f1 Arnd Bergmann           2016-11-09  773  		sm750_hw_cursor_disable(&crtc->cursor);
81dee67e215b23f Sudip Mukherjee         2015-03-03  774  
81dee67e215b23f Sudip Mukherjee         2015-03-03  775  	/* set info->fbops, must be set before fb_find_mode */
e359b6a863e19f2 Mike Rapoport           2015-10-26  776  	if (!sm750_dev->accel_off) {
81dee67e215b23f Sudip Mukherjee         2015-03-03  777  		/* use 2d acceleration */
f7c8a046577e09d Thomas Zimmermann       2023-11-27  778  		if (!g_hwcursor)
f7c8a046577e09d Thomas Zimmermann       2023-11-27  779  			info->fbops = &lynxfb_ops_accel;
f7c8a046577e09d Thomas Zimmermann       2023-11-27  780  		else
f7c8a046577e09d Thomas Zimmermann       2023-11-27  781  			info->fbops = &lynxfb_ops_accel_with_cursor;
f7c8a046577e09d Thomas Zimmermann       2023-11-27  782  	} else {
f7c8a046577e09d Thomas Zimmermann       2023-11-27  783  		if (!g_hwcursor)
81dee67e215b23f Sudip Mukherjee         2015-03-03  784  			info->fbops = &lynxfb_ops;
f7c8a046577e09d Thomas Zimmermann       2023-11-27  785  		else
f7c8a046577e09d Thomas Zimmermann       2023-11-27  786  			info->fbops = &lynxfb_ops_with_cursor;
f7c8a046577e09d Thomas Zimmermann       2023-11-27  787  	}
81dee67e215b23f Sudip Mukherjee         2015-03-03  788  
81dee67e215b23f Sudip Mukherjee         2015-03-03  789  	if (!g_fbmode[index]) {
81dee67e215b23f Sudip Mukherjee         2015-03-03 @790  		g_fbmode[index] = g_def_fbmode;
81dee67e215b23f Sudip Mukherjee         2015-03-03  791  		if (index)
81dee67e215b23f Sudip Mukherjee         2015-03-03  792  			g_fbmode[index] = g_fbmode[0];
81dee67e215b23f Sudip Mukherjee         2015-03-03  793  	}
81dee67e215b23f Sudip Mukherjee         2015-03-03  794  
81dee67e215b23f Sudip Mukherjee         2015-03-03  795  	for (i = 0; i < 3; i++) {
81dee67e215b23f Sudip Mukherjee         2015-03-03  796  		ret = fb_find_mode(var, info, g_fbmode[index],
81dee67e215b23f Sudip Mukherjee         2015-03-03  797  				   pdb[i], cdb[i], NULL, 8);
81dee67e215b23f Sudip Mukherjee         2015-03-03  798  
81dee67e215b23f Sudip Mukherjee         2015-03-03  799  		if (ret == 1) {
81dee67e215b23f Sudip Mukherjee         2015-03-03  800  			pr_info("success! use specified mode:%s in %s\n",
81dee67e215b23f Sudip Mukherjee         2015-03-03  801  				g_fbmode[index],
81dee67e215b23f Sudip Mukherjee         2015-03-03  802  				mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee         2015-03-03  803  			break;
81dee67e215b23f Sudip Mukherjee         2015-03-03  804  		} else if (ret == 2) {
81dee67e215b23f Sudip Mukherjee         2015-03-03  805  			pr_warn("use specified mode:%s in %s,with an ignored refresh rate\n",
81dee67e215b23f Sudip Mukherjee         2015-03-03  806  				g_fbmode[index],
81dee67e215b23f Sudip Mukherjee         2015-03-03  807  				mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee         2015-03-03  808  			break;
81dee67e215b23f Sudip Mukherjee         2015-03-03  809  		} else if (ret == 3) {
81dee67e215b23f Sudip Mukherjee         2015-03-03  810  			pr_warn("wanna use default mode\n");
4bd9503d0becdb6 Michel von Czettritz    2015-03-26  811  			/*break;*/
81dee67e215b23f Sudip Mukherjee         2015-03-03  812  		} else if (ret == 4) {
81dee67e215b23f Sudip Mukherjee         2015-03-03  813  			pr_warn("fall back to any valid mode\n");
81dee67e215b23f Sudip Mukherjee         2015-03-03  814  		} else {
3318bb5e945f700 Michel von Czettritz    2015-03-26  815  			pr_warn("ret = %d,fb_find_mode failed,with %s\n",
3318bb5e945f700 Michel von Czettritz    2015-03-26  816  				ret,
3318bb5e945f700 Michel von Czettritz    2015-03-26  817  				mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee         2015-03-03  818  		}
81dee67e215b23f Sudip Mukherjee         2015-03-03  819  	}
81dee67e215b23f Sudip Mukherjee         2015-03-03  820  
81dee67e215b23f Sudip Mukherjee         2015-03-03  821  	/* some member of info->var had been set by fb_find_mode */
81dee67e215b23f Sudip Mukherjee         2015-03-03  822  
271dbae3c6a1daa Prasant Jalan           2017-04-01  823  	pr_info("Member of info->var is :\n"
271dbae3c6a1daa Prasant Jalan           2017-04-01  824  		"xres=%d\n"
271dbae3c6a1daa Prasant Jalan           2017-04-01  825  		"yres=%d\n"
271dbae3c6a1daa Prasant Jalan           2017-04-01  826  		"xres_virtual=%d\n"
271dbae3c6a1daa Prasant Jalan           2017-04-01  827  		"yres_virtual=%d\n"
271dbae3c6a1daa Prasant Jalan           2017-04-01  828  		"xoffset=%d\n"
271dbae3c6a1daa Prasant Jalan           2017-04-01  829  		"yoffset=%d\n"
271dbae3c6a1daa Prasant Jalan           2017-04-01  830  		"bits_per_pixel=%d\n"
271dbae3c6a1daa Prasant Jalan           2017-04-01  831  		" ...\n",
3318bb5e945f700 Michel von Czettritz    2015-03-26  832  		var->xres,
3318bb5e945f700 Michel von Czettritz    2015-03-26  833  		var->yres,
3318bb5e945f700 Michel von Czettritz    2015-03-26  834  		var->xres_virtual,
3318bb5e945f700 Michel von Czettritz    2015-03-26  835  		var->yres_virtual,
3318bb5e945f700 Michel von Czettritz    2015-03-26  836  		var->xoffset,
3318bb5e945f700 Michel von Czettritz    2015-03-26  837  		var->yoffset,
3318bb5e945f700 Michel von Czettritz    2015-03-26  838  		var->bits_per_pixel);
81dee67e215b23f Sudip Mukherjee         2015-03-03  839  
81dee67e215b23f Sudip Mukherjee         2015-03-03  840  	/* set par */
81dee67e215b23f Sudip Mukherjee         2015-03-03  841  	par->info = info;
81dee67e215b23f Sudip Mukherjee         2015-03-03  842  
81dee67e215b23f Sudip Mukherjee         2015-03-03  843  	/* set info */
e3a3f9f5123683b Mike Rapoport           2015-10-26  844  	line_length = ALIGN((var->xres_virtual * var->bits_per_pixel / 8),
e3a3f9f5123683b Mike Rapoport           2015-10-26  845  			    crtc->line_pad);
81dee67e215b23f Sudip Mukherjee         2015-03-03  846  
81dee67e215b23f Sudip Mukherjee         2015-03-03  847  	info->pseudo_palette = &par->pseudo_palette[0];
cc59bde1c920ab6 Benjamin Philip         2021-07-28  848  	info->screen_base = crtc->v_screen;
81dee67e215b23f Sudip Mukherjee         2015-03-03  849  	pr_debug("screen_base vaddr = %p\n", info->screen_base);
81dee67e215b23f Sudip Mukherjee         2015-03-03  850  	info->screen_size = line_length * var->yres_virtual;
81dee67e215b23f Sudip Mukherjee         2015-03-03  851  
81dee67e215b23f Sudip Mukherjee         2015-03-03  852  	/* set info->fix */
81dee67e215b23f Sudip Mukherjee         2015-03-03  853  	fix->type = FB_TYPE_PACKED_PIXELS;
81dee67e215b23f Sudip Mukherjee         2015-03-03  854  	fix->type_aux = 0;
81dee67e215b23f Sudip Mukherjee         2015-03-03  855  	fix->xpanstep = crtc->xpanstep;
81dee67e215b23f Sudip Mukherjee         2015-03-03  856  	fix->ypanstep = crtc->ypanstep;
81dee67e215b23f Sudip Mukherjee         2015-03-03  857  	fix->ywrapstep = crtc->ywrapstep;
81dee67e215b23f Sudip Mukherjee         2015-03-03  858  	fix->accel = FB_ACCEL_SMI;
81dee67e215b23f Sudip Mukherjee         2015-03-03  859  
9c15db83a86bf83 Kumar Kartikeya Dwivedi 2021-01-31  860  	strscpy(fix->id, fixId[index], sizeof(fix->id));
81dee67e215b23f Sudip Mukherjee         2015-03-03  861  
fdc234d85210d91 Benjamin Philip         2021-07-28  862  	fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
81dee67e215b23f Sudip Mukherjee         2015-03-03  863  	pr_info("fix->smem_start = %lx\n", fix->smem_start);
d11ac7cbcc266c6 Sudip Mukherjee         2015-08-07  864  	/*
d11ac7cbcc266c6 Sudip Mukherjee         2015-08-07  865  	 * according to mmap experiment from user space application,
81dee67e215b23f Sudip Mukherjee         2015-03-03  866  	 * fix->mmio_len should not larger than virtual size
81dee67e215b23f Sudip Mukherjee         2015-03-03  867  	 * (xres_virtual x yres_virtual x ByPP)
81dee67e215b23f Sudip Mukherjee         2015-03-03  868  	 * Below line maybe buggy when user mmap fb dev node and write
81dee67e215b23f Sudip Mukherjee         2015-03-03  869  	 * data into the bound over virtual size
d11ac7cbcc266c6 Sudip Mukherjee         2015-08-07  870  	 */
81dee67e215b23f Sudip Mukherjee         2015-03-03  871  	fix->smem_len = crtc->vidmem_size;
81dee67e215b23f Sudip Mukherjee         2015-03-03  872  	pr_info("fix->smem_len = %x\n", fix->smem_len);
81dee67e215b23f Sudip Mukherjee         2015-03-03  873  	info->screen_size = fix->smem_len;
81dee67e215b23f Sudip Mukherjee         2015-03-03  874  	fix->line_length = line_length;
e359b6a863e19f2 Mike Rapoport           2015-10-26  875  	fix->mmio_start = sm750_dev->vidreg_start;
81dee67e215b23f Sudip Mukherjee         2015-03-03  876  	pr_info("fix->mmio_start = %lx\n", fix->mmio_start);
e359b6a863e19f2 Mike Rapoport           2015-10-26  877  	fix->mmio_len = sm750_dev->vidreg_size;
81dee67e215b23f Sudip Mukherjee         2015-03-03  878  	pr_info("fix->mmio_len = %x\n", fix->mmio_len);
b610e1193a917f4 Matej Dujava            2020-04-30  879  
b610e1193a917f4 Matej Dujava            2020-04-30  880  	lynxfb_set_visual_mode(info);
81dee67e215b23f Sudip Mukherjee         2015-03-03  881  
81dee67e215b23f Sudip Mukherjee         2015-03-03  882  	/* set var */
81dee67e215b23f Sudip Mukherjee         2015-03-03  883  	var->activate = FB_ACTIVATE_NOW;
81dee67e215b23f Sudip Mukherjee         2015-03-03  884  	var->accel_flags = 0;
81dee67e215b23f Sudip Mukherjee         2015-03-03  885  	var->vmode = FB_VMODE_NONINTERLACED;
81dee67e215b23f Sudip Mukherjee         2015-03-03  886  
81dee67e215b23f Sudip Mukherjee         2015-03-03  887  	pr_debug("#1 show info->cmap :\nstart=%d,len=%d,red=%p,green=%p,blue=%p,transp=%p\n",
81dee67e215b23f Sudip Mukherjee         2015-03-03  888  		 info->cmap.start, info->cmap.len,
81dee67e215b23f Sudip Mukherjee         2015-03-03  889  		 info->cmap.red, info->cmap.green, info->cmap.blue,
81dee67e215b23f Sudip Mukherjee         2015-03-03  890  		 info->cmap.transp);
81dee67e215b23f Sudip Mukherjee         2015-03-03  891  
61c507cf652da1b Michel von Czettritz    2015-03-26  892  	ret = fb_alloc_cmap(&info->cmap, 256, 0);
61c507cf652da1b Michel von Czettritz    2015-03-26  893  	if (ret < 0) {
008272072d61a8c Masanari Iida           2015-05-28  894  		pr_err("Could not allocate memory for cmap.\n");
81dee67e215b23f Sudip Mukherjee         2015-03-03  895  		goto exit;
81dee67e215b23f Sudip Mukherjee         2015-03-03  896  	}
81dee67e215b23f Sudip Mukherjee         2015-03-03  897  
81dee67e215b23f Sudip Mukherjee         2015-03-03  898  	pr_debug("#2 show info->cmap :\nstart=%d,len=%d,red=%p,green=%p,blue=%p,transp=%p\n",
81dee67e215b23f Sudip Mukherjee         2015-03-03  899  		 info->cmap.start, info->cmap.len,
81dee67e215b23f Sudip Mukherjee         2015-03-03  900  		 info->cmap.red, info->cmap.green, info->cmap.blue,
81dee67e215b23f Sudip Mukherjee         2015-03-03  901  		 info->cmap.transp);
81dee67e215b23f Sudip Mukherjee         2015-03-03  902  
81dee67e215b23f Sudip Mukherjee         2015-03-03  903  exit:
81dee67e215b23f Sudip Mukherjee         2015-03-03  904  	lynxfb_ops_check_var(var, info);
81dee67e215b23f Sudip Mukherjee         2015-03-03  905  	return ret;
81dee67e215b23f Sudip Mukherjee         2015-03-03  906  }
81dee67e215b23f Sudip Mukherjee         2015-03-03  907  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-21 23:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-18  3:49 [PATCH 1/2] staging: sm750fb: make const arrays static const char * const Ignacio Peña
2025-07-18  7:44 ` Greg Kroah-Hartman
2025-07-18 14:53 ` Dan Carpenter
2025-07-21 23:04 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).