[PATCH v2] drm/sitronix/st7571-i2c: Make st7571_panel_data variables static const

[PATCH v2] drm/sitronix/st7571-i2c: Make st7571_panel_data variables static const

[Javier Martinez Canillas]

The kernel test robot reported that sparse gives the following warnings:

make C=2 M=drivers/gpu/drm/sitronix/
  CC [M]  st7571-i2c.o
  CHECK   st7571-i2c.c
st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static?
st7571-i2c.c:1039:26: warning: symbol 'st7571_config' was not declared. Should it be static?
  MODPOST Module.symvers
  LD [M]  st7571-i2c.ko

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507180503.nfyD9uRv-lkp@intel.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

Changes in v2:
- Also make the st7571_panel_data variables to be const (Thomas Zimmermann).

 drivers/gpu/drm/sitronix/st7571-i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
index 453eb7e045e5..dda99cbe5372 100644
--- a/drivers/gpu/drm/sitronix/st7571-i2c.c
+++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
@@ -1024,7 +1024,7 @@ static void st7571_remove(struct i2c_client *client)
 	drm_dev_unplug(&st7571->dev);
 }
 
-struct st7571_panel_data st7567_config = {
+static const struct st7571_panel_data st7567_config = {
 	.init = st7567_lcd_init,
 	.parse_dt = st7567_parse_dt,
 	.constraints = {
@@ -1036,7 +1036,7 @@ struct st7571_panel_data st7567_config = {
 	},
 };
 
-struct st7571_panel_data st7571_config = {
+static const struct st7571_panel_data st7571_config = {
 	.init = st7571_lcd_init,
 	.parse_dt = st7571_parse_dt,
 	.constraints = {
-- 
2.49.0

base-commit: a55863ba4c9ea9febe81ecf7dba36e7989a37b7e
branch: drm-misc-next

Re: [PATCH v2] drm/sitronix/st7571-i2c: Make st7571_panel_data variables static const

[Dmitry Baryshkov]

On Fri, Jul 18, 2025 at 05:25:25PM +0200, Javier Martinez Canillas wrote:
> The kernel test robot reported that sparse gives the following warnings:
> 
> make C=2 M=drivers/gpu/drm/sitronix/
>   CC [M]  st7571-i2c.o
>   CHECK   st7571-i2c.c
> st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static?
> st7571-i2c.c:1039:26: warning: symbol 'st7571_config' was not declared. Should it be static?
>   MODPOST Module.symvers
>   LD [M]  st7571-i2c.ko
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507180503.nfyD9uRv-lkp@intel.com
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
> 
> Changes in v2:
> - Also make the st7571_panel_data variables to be const (Thomas Zimmermann).
> 
>  drivers/gpu/drm/sitronix/st7571-i2c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH v2] drm/sitronix/st7571-i2c: Make st7571_panel_data variables static const

[Javier Martinez Canillas]

Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> writes:

> On Fri, Jul 18, 2025 at 05:25:25PM +0200, Javier Martinez Canillas wrote:
>> The kernel test robot reported that sparse gives the following warnings:
>> 
>> make C=2 M=drivers/gpu/drm/sitronix/
>>   CC [M]  st7571-i2c.o
>>   CHECK   st7571-i2c.c
>> st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static?
>> st7571-i2c.c:1039:26: warning: symbol 'st7571_config' was not declared. Should it be static?
>>   MODPOST Module.symvers
>>   LD [M]  st7571-i2c.ko
>> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202507180503.nfyD9uRv-lkp@intel.com
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> ---
>> 
>> Changes in v2:
>> - Also make the st7571_panel_data variables to be const (Thomas Zimmermann).
>> 
>>  drivers/gpu/drm/sitronix/st7571-i2c.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>

Pushed to drm-misc (drm-misc-next). Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat