From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Liangyan <liangyan.peng@bytedance.com>,
Yicong Shen <shenyicong.1023@bytedance.com>,
Jiri Slaby <jirislaby@kernel.org>
Subject: [patch 0/4] genirq: Prevent migration live lock in handle_edge_irq()
Date: Fri, 18 Jul 2025 20:54:04 +0200 (CEST) [thread overview]
Message-ID: <20250718184935.232983339@linutronix.de> (raw)
Yicon reported and Liangyan debugged a live lock in handle_edge_irq()
related to interrupt migration.
If the interrupt affinity is moved to a new target CPU and the interrupt is
currently handled on the previous target CPU for edge type interrupts the
handler might get stuck on the previous target:
CPU 0 (previous target) CPU 1 (new target)
handle_edge_irq()
repeat:
handle_event() handle_edge_irq()
if (INPROGESS) {
set(PENDING);
mask();
return;
}
if (PENDING) {
clear(PENDING);
unmask();
goto repeat;
}
The migration in software never completes and CPU0 continues to handle the
pending events forever. This happens when the device raises interrupts with
a high rate and always before handle_event() completes and before the CPU0
handler can clear INPROGRESS so that CPU1 sets the PENDING flag over and
over. This has been observed in virtual machines.
The following series is addressing this by making the new target CPU wait
for the handler to complete on CPU1 and thereby completing the software
migration.
A draft combo patch of this has been tested by Liangyan:
https://lore.kernel.org/all/87o6u0rpaa.ffs@tglx
The series splits up the draft patch and has proper changelogs.
Thanks,
tglx
---
chip.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------
internals.h | 6 ++---
pm.c | 16 +++++---------
spurious.c | 37 --------------------------------
4 files changed, 69 insertions(+), 58 deletions(-)
next reply other threads:[~2025-07-18 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 18:54 Thomas Gleixner [this message]
2025-07-18 18:54 ` [patch 1/4] genirq: Remove pointless local variable Thomas Gleixner
2025-07-22 12:45 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-07-18 18:54 ` [patch 2/4] genirq: Move irq_wait_for_poll() to call site Thomas Gleixner
2025-07-22 7:07 ` Jiri Slaby
2025-07-22 12:36 ` Thomas Gleixner
2025-07-22 12:45 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-07-23 6:22 ` Ingo Molnar
2025-07-18 18:54 ` [patch 3/4] genirq: Split up irq_pm_check_wakeup() Thomas Gleixner
2025-07-22 12:45 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-07-18 18:54 ` [patch 4/4] genirq: Prevent migration live lock in handle_edge_irq() Thomas Gleixner
2025-07-22 7:37 ` Jiri Slaby
2025-07-22 12:45 ` [tip: irq/core] " tip-bot2 for Thomas Gleixner
2025-07-21 15:05 ` [External] [patch 0/4] " Liangyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718184935.232983339@linutronix.de \
--to=tglx@linutronix.de \
--cc=jirislaby@kernel.org \
--cc=liangyan.peng@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shenyicong.1023@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).