From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Salah Triki <salah.triki@gmail.com>
Cc: Eli Billauer <eli.billauer@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] char: xillybus: Replace deprecated MSI API
Date: Sun, 20 Jul 2025 11:07:40 +0200 [thread overview]
Message-ID: <2025072038-improvise-polymer-a538@gregkh> (raw)
In-Reply-To: <aHyvPWeN_4JmPAzc@pc>
On Sun, Jul 20, 2025 at 09:56:29AM +0100, Salah Triki wrote:
> On Sun, Jul 20, 2025 at 10:33:47AM +0200, Greg Kroah-Hartman wrote:
> >
> > This says what you are doing, but not _WHY_ you are doing it.
> >
>
> I did the replacement because pci_enable_msi() is deprecated, isn't that
> enough ?
If it was a simple search/replace, why wouldn't have been done already?
Again, you need to prove why this is ok at all. pci_enable_msi()
shouldn't be used in new drivers, but what's wrong with it being in
existing drivers? Especially in ones that you can't test to verify it
still works after changing the code?
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-20 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 19:39 [PATCH] char: xillybus: Replace deprecated MSI API Salah Triki
2025-07-17 13:51 ` Eli Billauer
2025-07-17 16:26 ` [PATCH v2] " Salah Triki
2025-07-18 0:55 ` [PATCH v3] " Salah Triki
2025-07-18 14:19 ` Eli Billauer
2025-07-19 4:51 ` [PATCH v4] " Salah Triki
2025-07-19 12:22 ` Eli Billauer
2025-07-19 12:35 ` Salah Triki
2025-07-20 8:33 ` Greg Kroah-Hartman
2025-07-20 8:56 ` Salah Triki
2025-07-20 9:07 ` Greg Kroah-Hartman [this message]
2025-07-20 17:03 ` Salah Triki
2025-07-21 5:41 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072038-improvise-polymer-a538@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=eli.billauer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox