* [PATCH 1/3] usb: chipidea: imx: Add a missing blank line [not found] <cover.1752703107.git.dan.carpenter@linaro.org> @ 2025-07-16 22:46 ` Dan Carpenter 2025-07-21 2:24 ` Peter Chen (CIX) 2025-07-16 22:46 ` [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree Dan Carpenter 2025-07-16 22:46 ` [PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section Dan Carpenter 2 siblings, 1 reply; 10+ messages in thread From: Dan Carpenter @ 2025-07-16 22:46 UTC (permalink / raw) To: Xu Yang Cc: Peter Chen, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, linux-usb, imx, linux-arm-kernel, linux-kernel Fix a checkpatch warning: CHECK: Please use a blank line after function/struct/union/enum declarations Reported-by: Xu Yang <xu.yang_2@nxp.com> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/usb/chipidea/usbmisc_imx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c index 0b8b980409bc..3d20c5e76c6a 100644 --- a/drivers/usb/chipidea/usbmisc_imx.c +++ b/drivers/usb/chipidea/usbmisc_imx.c @@ -1118,6 +1118,7 @@ static int usbmisc_imx6sx_power_lost_check(struct imx_usbmisc_data *data) else return 0; } + static int usbmisc_s32g_power_lost_check(struct imx_usbmisc_data *data) { return 1; -- 2.47.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] usb: chipidea: imx: Add a missing blank line 2025-07-16 22:46 ` [PATCH 1/3] usb: chipidea: imx: Add a missing blank line Dan Carpenter @ 2025-07-21 2:24 ` Peter Chen (CIX) 0 siblings, 0 replies; 10+ messages in thread From: Peter Chen (CIX) @ 2025-07-21 2:24 UTC (permalink / raw) To: Dan Carpenter Cc: Xu Yang, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, linux-usb, imx, linux-arm-kernel, linux-kernel On 25-07-16 17:46:26, Dan Carpenter wrote: > Fix a checkpatch warning: > CHECK: Please use a blank line after function/struct/union/enum declarations > > Reported-by: Xu Yang <xu.yang_2@nxp.com> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Acked-by: Peter Chen <peter.chen@kernel.org> Peter > --- > drivers/usb/chipidea/usbmisc_imx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > index 0b8b980409bc..3d20c5e76c6a 100644 > --- a/drivers/usb/chipidea/usbmisc_imx.c > +++ b/drivers/usb/chipidea/usbmisc_imx.c > @@ -1118,6 +1118,7 @@ static int usbmisc_imx6sx_power_lost_check(struct imx_usbmisc_data *data) > else > return 0; > } > + > static int usbmisc_s32g_power_lost_check(struct imx_usbmisc_data *data) > { > return 1; > -- > 2.47.2 > -- Best regards, Peter ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree [not found] <cover.1752703107.git.dan.carpenter@linaro.org> 2025-07-16 22:46 ` [PATCH 1/3] usb: chipidea: imx: Add a missing blank line Dan Carpenter @ 2025-07-16 22:46 ` Dan Carpenter 2025-07-17 16:07 ` Matthias Brugger 2025-07-18 6:58 ` Krzysztof Kozlowski 2025-07-16 22:46 ` [PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section Dan Carpenter 2 siblings, 2 replies; 10+ messages in thread From: Dan Carpenter @ 2025-07-16 22:46 UTC (permalink / raw) To: Xu Yang Cc: Chester Lin, Matthias Brugger, Ghennadi Procopciuc, NXP S32 Linux Team, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, imx, devicetree, linux-kernel Checkpatch points out that this should use spaces instead of tabs. "ERROR: code indent should use tabs where possible". Reported-by: Xu Yang <xu.yang_2@nxp.com> Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- arch/arm64/boot/dts/freescale/s32g3.dtsi | 32 ++++++++++++------------ 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi index 68c11ebd405f..e80144e33efb 100644 --- a/arch/arm64/boot/dts/freescale/s32g3.dtsi +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi @@ -489,22 +489,22 @@ usbmisc: usbmisc@44064200 { reg = <0x44064200 0x200>; }; - usbotg: usb@44064000 { - compatible = "nxp,s32g3-usb", "nxp,s32g2-usb"; - reg = <0x44064000 0x200>; - interrupt-parent = <&gic>; - interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */ - <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */ - clocks = <&clks 94>, <&clks 95>; - fsl,usbmisc = <&usbmisc 0>; - ahb-burst-config = <0x3>; - tx-burst-size-dword = <0x10>; - rx-burst-size-dword = <0x10>; - phy_type = "ulpi"; - dr_mode = "host"; - maximum-speed = "high-speed"; - status = "disabled"; - }; + usbotg: usb@44064000 { + compatible = "nxp,s32g3-usb", "nxp,s32g2-usb"; + reg = <0x44064000 0x200>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */ + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */ + clocks = <&clks 94>, <&clks 95>; + fsl,usbmisc = <&usbmisc 0>; + ahb-burst-config = <0x3>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; + phy_type = "ulpi"; + dr_mode = "host"; + maximum-speed = "high-speed"; + status = "disabled"; + }; i2c0: i2c@401e4000 { compatible = "nxp,s32g3-i2c", -- 2.47.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree 2025-07-16 22:46 ` [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree Dan Carpenter @ 2025-07-17 16:07 ` Matthias Brugger 2025-07-18 6:58 ` Krzysztof Kozlowski 1 sibling, 0 replies; 10+ messages in thread From: Matthias Brugger @ 2025-07-17 16:07 UTC (permalink / raw) To: Dan Carpenter, Xu Yang Cc: Chester Lin, Ghennadi Procopciuc, NXP S32 Linux Team, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, imx, devicetree, linux-kernel On 17/07/2025 00:46, Dan Carpenter wrote: > Checkpatch points out that this should use spaces instead of tabs. > "ERROR: code indent should use tabs where possible". > > Reported-by: Xu Yang <xu.yang_2@nxp.com> > Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Matthias Brugger <mbrugger@suse.com> > --- > arch/arm64/boot/dts/freescale/s32g3.dtsi | 32 ++++++++++++------------ > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi > index 68c11ebd405f..e80144e33efb 100644 > --- a/arch/arm64/boot/dts/freescale/s32g3.dtsi > +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi > @@ -489,22 +489,22 @@ usbmisc: usbmisc@44064200 { > reg = <0x44064200 0x200>; > }; > > - usbotg: usb@44064000 { > - compatible = "nxp,s32g3-usb", "nxp,s32g2-usb"; > - reg = <0x44064000 0x200>; > - interrupt-parent = <&gic>; > - interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */ > - <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */ > - clocks = <&clks 94>, <&clks 95>; > - fsl,usbmisc = <&usbmisc 0>; > - ahb-burst-config = <0x3>; > - tx-burst-size-dword = <0x10>; > - rx-burst-size-dword = <0x10>; > - phy_type = "ulpi"; > - dr_mode = "host"; > - maximum-speed = "high-speed"; > - status = "disabled"; > - }; > + usbotg: usb@44064000 { > + compatible = "nxp,s32g3-usb", "nxp,s32g2-usb"; > + reg = <0x44064000 0x200>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */ > + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */ > + clocks = <&clks 94>, <&clks 95>; > + fsl,usbmisc = <&usbmisc 0>; > + ahb-burst-config = <0x3>; > + tx-burst-size-dword = <0x10>; > + rx-burst-size-dword = <0x10>; > + phy_type = "ulpi"; > + dr_mode = "host"; > + maximum-speed = "high-speed"; > + status = "disabled"; > + }; > > i2c0: i2c@401e4000 { > compatible = "nxp,s32g3-i2c", ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree 2025-07-16 22:46 ` [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree Dan Carpenter 2025-07-17 16:07 ` Matthias Brugger @ 2025-07-18 6:58 ` Krzysztof Kozlowski 2025-07-18 15:21 ` Dan Carpenter 1 sibling, 1 reply; 10+ messages in thread From: Krzysztof Kozlowski @ 2025-07-18 6:58 UTC (permalink / raw) To: Dan Carpenter, Xu Yang Cc: Chester Lin, Matthias Brugger, Ghennadi Procopciuc, NXP S32 Linux Team, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, imx, devicetree, linux-kernel On 17/07/2025 00:46, Dan Carpenter wrote: > Checkpatch points out that this should use spaces instead of tabs. > "ERROR: code indent should use tabs where possible". > > Reported-by: Xu Yang <xu.yang_2@nxp.com> > Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- Patches were not merged, so this should be squashed there... or you meant they went with Greg USB? Then no, that's dissapointing, you are not supposed to send DTS patches to Greg's subsystem. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree 2025-07-18 6:58 ` Krzysztof Kozlowski @ 2025-07-18 15:21 ` Dan Carpenter 2025-08-21 8:04 ` Shawn Guo 2025-08-21 8:41 ` Krzysztof Kozlowski 0 siblings, 2 replies; 10+ messages in thread From: Dan Carpenter @ 2025-07-18 15:21 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Xu Yang, Chester Lin, Matthias Brugger, Ghennadi Procopciuc, NXP S32 Linux Team, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, imx, devicetree, linux-kernel On Fri, Jul 18, 2025 at 08:58:19AM +0200, Krzysztof Kozlowski wrote: > On 17/07/2025 00:46, Dan Carpenter wrote: > > Checkpatch points out that this should use spaces instead of tabs. > > "ERROR: code indent should use tabs where possible". > > > > Reported-by: Xu Yang <xu.yang_2@nxp.com> > > Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > > --- > > Patches were not merged, so this should be squashed there... or you > meant they went with Greg USB? Then no, that's dissapointing, you are > not supposed to send DTS patches to Greg's subsystem. I worry that I have accidentally stepped into politics... Yes, it went through Greg's tree. I'm just using get_maintainer.pl. Looking at it now, Greg and linux-usb weren't even on the Cc list for the DTS patches. There was probably some b4 magic which let him apply the whole series. How was this supposed to have worked? regards, dan carpenter ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree 2025-07-18 15:21 ` Dan Carpenter @ 2025-08-21 8:04 ` Shawn Guo 2025-08-21 8:41 ` Krzysztof Kozlowski 1 sibling, 0 replies; 10+ messages in thread From: Shawn Guo @ 2025-08-21 8:04 UTC (permalink / raw) To: Dan Carpenter Cc: Krzysztof Kozlowski, Xu Yang, Chester Lin, Matthias Brugger, Ghennadi Procopciuc, NXP S32 Linux Team, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, imx, devicetree, linux-kernel On Fri, Jul 18, 2025 at 06:21:00PM +0300, Dan Carpenter wrote: > On Fri, Jul 18, 2025 at 08:58:19AM +0200, Krzysztof Kozlowski wrote: > > On 17/07/2025 00:46, Dan Carpenter wrote: > > > Checkpatch points out that this should use spaces instead of tabs. > > > "ERROR: code indent should use tabs where possible". > > > > > > Reported-by: Xu Yang <xu.yang_2@nxp.com> > > > Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ > > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > > > --- > > > > Patches were not merged, so this should be squashed there... or you > > meant they went with Greg USB? Then no, that's dissapointing, you are > > not supposed to send DTS patches to Greg's subsystem. > > I worry that I have accidentally stepped into politics... > > Yes, it went through Greg's tree. I don't find two DTS patches in v6.17-rc1. I tried to pick them up, but this one doesn't apply. So you may want to resend them. > I'm just using get_maintainer.pl. > Looking at it now, Greg and linux-usb weren't even on the Cc list for > the DTS patches. There was probably some b4 magic which let him apply > the whole series. > > How was this supposed to have worked? The DTS changes should be sent separately from usb driver ones. Shawn ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree 2025-07-18 15:21 ` Dan Carpenter 2025-08-21 8:04 ` Shawn Guo @ 2025-08-21 8:41 ` Krzysztof Kozlowski 1 sibling, 0 replies; 10+ messages in thread From: Krzysztof Kozlowski @ 2025-08-21 8:41 UTC (permalink / raw) To: Dan Carpenter Cc: Xu Yang, Chester Lin, Matthias Brugger, Ghennadi Procopciuc, NXP S32 Linux Team, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, imx, devicetree, linux-kernel On 18/07/2025 17:21, Dan Carpenter wrote: > > Yes, it went through Greg's tree. I'm just using get_maintainer.pl. > Looking at it now, Greg and linux-usb weren't even on the Cc list for > the DTS patches. There was probably some b4 magic which let him apply > the whole series. > > How was this supposed to have worked? There are few maintainers who pick up entire patchsets, including DTS. You must not combine DTS into the same patchset targeting such maintainers (Greg, and in the past sometimes watchdog and netdev). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section [not found] <cover.1752703107.git.dan.carpenter@linaro.org> 2025-07-16 22:46 ` [PATCH 1/3] usb: chipidea: imx: Add a missing blank line Dan Carpenter 2025-07-16 22:46 ` [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree Dan Carpenter @ 2025-07-16 22:46 ` Dan Carpenter 2025-07-17 16:06 ` Matthias Brugger 2 siblings, 1 reply; 10+ messages in thread From: Dan Carpenter @ 2025-07-16 22:46 UTC (permalink / raw) To: Xu Yang Cc: Chester Lin, Matthias Brugger, Ghennadi Procopciuc, NXP S32 Linux Team, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, imx, devicetree, linux-kernel The compatible line is supposed to be first. Reported-by: Xu Yang <xu.yang_2@nxp.com> Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- arch/arm64/boot/dts/freescale/s32g2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi index 089f54415571..6f700085dec2 100644 --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi @@ -424,8 +424,8 @@ spi2: spi@401dc000 { }; usbmisc: usbmisc@44064200 { - #index-cells = <1>; compatible = "nxp,s32g2-usbmisc"; + #index-cells = <1>; reg = <0x44064200 0x200>; }; -- 2.47.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section 2025-07-16 22:46 ` [PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section Dan Carpenter @ 2025-07-17 16:06 ` Matthias Brugger 0 siblings, 0 replies; 10+ messages in thread From: Matthias Brugger @ 2025-07-17 16:06 UTC (permalink / raw) To: Dan Carpenter, Xu Yang Cc: Chester Lin, Ghennadi Procopciuc, NXP S32 Linux Team, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, imx, devicetree, linux-kernel On 17/07/2025 00:46, Dan Carpenter wrote: > The compatible line is supposed to be first. > > Reported-by: Xu Yang <xu.yang_2@nxp.com> > Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Matthias Brugger <mbrugger@suse.com> > --- > arch/arm64/boot/dts/freescale/s32g2.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi > index 089f54415571..6f700085dec2 100644 > --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi > +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi > @@ -424,8 +424,8 @@ spi2: spi@401dc000 { > }; > > usbmisc: usbmisc@44064200 { > - #index-cells = <1>; > compatible = "nxp,s32g2-usbmisc"; > + #index-cells = <1>; > reg = <0x44064200 0x200>; > }; > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-08-21 8:41 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1752703107.git.dan.carpenter@linaro.org>
2025-07-16 22:46 ` [PATCH 1/3] usb: chipidea: imx: Add a missing blank line Dan Carpenter
2025-07-21 2:24 ` Peter Chen (CIX)
2025-07-16 22:46 ` [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree Dan Carpenter
2025-07-17 16:07 ` Matthias Brugger
2025-07-18 6:58 ` Krzysztof Kozlowski
2025-07-18 15:21 ` Dan Carpenter
2025-08-21 8:04 ` Shawn Guo
2025-08-21 8:41 ` Krzysztof Kozlowski
2025-07-16 22:46 ` [PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section Dan Carpenter
2025-07-17 16:06 ` Matthias Brugger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).