* [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs
2025-07-09 11:13 [PATCH v3 0/2] Add support for remoteprocs on Milos SoC Luca Weiss
@ 2025-07-09 11:13 ` Luca Weiss
2025-07-09 22:30 ` Rob Herring (Arm)
2025-07-21 6:42 ` Peng Fan
2025-07-09 11:13 ` [PATCH v3 2/2] remoteproc: qcom: pas: Add Milos remoteproc support Luca Weiss
1 sibling, 2 replies; 8+ messages in thread
From: Luca Weiss @ 2025-07-09 11:13 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel, Luca Weiss
Document the bindings for the ADSP, CDSP, MPSS and WPSS PAS on the Milos
(e.g. SM7635) SoC.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
.../bindings/remoteproc/qcom,milos-pas.yaml | 201 +++++++++++++++++++++
1 file changed, 201 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..790ad38a0330bf81f6333e887522ddb97690edbc
--- /dev/null
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
@@ -0,0 +1,201 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,milos-pas.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Milos SoC Peripheral Authentication Service
+
+maintainers:
+ - Luca Weiss <luca.weiss@fairphone.com>
+
+description:
+ Qualcomm Milos SoC Peripheral Authentication Service loads and boots firmware
+ on the Qualcomm DSP Hexagon cores.
+
+properties:
+ compatible:
+ enum:
+ - qcom,milos-adsp-pas
+ - qcom,milos-cdsp-pas
+ - qcom,milos-mpss-pas
+ - qcom,milos-wpss-pas
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: XO clock
+
+ clock-names:
+ items:
+ - const: xo
+
+ interrupts:
+ minItems: 6
+ maxItems: 6
+
+ interrupt-names:
+ minItems: 6
+ maxItems: 6
+
+ qcom,qmp:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Reference to the AOSS side-channel message RAM.
+
+ smd-edge: false
+
+ firmware-name:
+ $ref: /schemas/types.yaml#/definitions/string-array
+ minItems: 1
+ items:
+ - description: Firmware name of the Hexagon core
+ - description: Firmware name of the Hexagon Devicetree
+
+ memory-region:
+ minItems: 1
+ items:
+ - description: Memory region for core Firmware authentication
+ - description: Memory region for Devicetree Firmware authentication
+
+required:
+ - compatible
+ - reg
+ - memory-region
+
+allOf:
+ - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,milos-adsp-pas
+ - qcom,milos-cdsp-pas
+ then:
+ properties:
+ memory-region:
+ minItems: 2
+ maxItems: 2
+ firmware-name:
+ minItems: 2
+ maxItems: 2
+ else:
+ properties:
+ memory-region:
+ maxItems: 1
+ firmware-name:
+ maxItems: 1
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,milos-adsp-pas
+ then:
+ properties:
+ power-domains:
+ items:
+ - description: LCX power domain
+ - description: LMX power domain
+ power-domain-names:
+ items:
+ - const: lcx
+ - const: lmx
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,milos-cdsp-pas
+ - qcom,milos-wpss-pas
+ then:
+ properties:
+ power-domains:
+ items:
+ - description: CX power domain
+ - description: MX power domain
+ power-domain-names:
+ items:
+ - const: cx
+ - const: mx
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,milos-mpss-pas
+ then:
+ properties:
+ power-domains:
+ items:
+ - description: CX power domain
+ - description: MSS power domain
+ power-domain-names:
+ items:
+ - const: cx
+ - const: mss
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,rpmh.h>
+ #include <dt-bindings/interconnect/qcom,icc.h>
+ #include <dt-bindings/interconnect/qcom,milos-rpmh.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/mailbox/qcom-ipcc.h>
+ #include <dt-bindings/power/qcom,rpmhpd.h>
+
+ remoteproc@3000000 {
+ compatible = "qcom,milos-adsp-pas";
+ reg = <0x03000000 0x10000>;
+
+ interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>,
+ <&smp2p_adsp_in 7 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "wdog",
+ "fatal",
+ "ready",
+ "handover",
+ "stop-ack",
+ "shutdown-ack";
+
+ clocks = <&rpmhcc RPMH_CXO_CLK>;
+ clock-names = "xo";
+
+ power-domains = <&rpmhpd RPMHPD_LCX>,
+ <&rpmhpd RPMHPD_LMX>;
+ power-domain-names = "lcx",
+ "lmx";
+
+ interconnects = <&lpass_ag_noc MASTER_LPASS_PROC QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+
+ memory-region = <&adspslpi_mem>, <&q6_adsp_dtb_mem>;
+
+ firmware-name = "qcom/milos/vendor/device/adsp.mbn",
+ "qcom/milos/vendor/device/adsp_dtb.mbn";
+
+ qcom,qmp = <&aoss_qmp>;
+
+ qcom,smem-states = <&smp2p_adsp_out 0>;
+ qcom,smem-state-names = "stop";
+
+ glink-edge {
+ interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_GLINK_QMP
+ IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&ipcc IPCC_CLIENT_LPASS
+ IPCC_MPROC_SIGNAL_GLINK_QMP>;
+
+ label = "lpass";
+ qcom,remote-pid = <2>;
+
+ /* ... */
+ };
+ };
--
2.50.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs
2025-07-09 11:13 ` [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs Luca Weiss
@ 2025-07-09 22:30 ` Rob Herring (Arm)
2025-07-17 7:20 ` Luca Weiss
2025-07-21 6:42 ` Peng Fan
1 sibling, 1 reply; 8+ messages in thread
From: Rob Herring (Arm) @ 2025-07-09 22:30 UTC (permalink / raw)
To: Luca Weiss
Cc: devicetree, Mathieu Poirier, Krzysztof Kozlowski,
Manivannan Sadhasivam, linux-remoteproc, linux-arm-msm,
Conor Dooley, phone-devel, linux-kernel, Bjorn Andersson,
~postmarketos/upstreaming
On Wed, 09 Jul 2025 13:13:07 +0200, Luca Weiss wrote:
> Document the bindings for the ADSP, CDSP, MPSS and WPSS PAS on the Milos
> (e.g. SM7635) SoC.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> .../bindings/remoteproc/qcom,milos-pas.yaml | 201 +++++++++++++++++++++
> 1 file changed, 201 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.example.dts:20:18: fatal error: dt-bindings/interconnect/qcom,milos-rpmh.h: No such file or directory
20 | #include <dt-bindings/interconnect/qcom,milos-rpmh.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250709-sm7635-remoteprocs-v3-1-c943be976180@fairphone.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs
2025-07-09 22:30 ` Rob Herring (Arm)
@ 2025-07-17 7:20 ` Luca Weiss
0 siblings, 0 replies; 8+ messages in thread
From: Luca Weiss @ 2025-07-17 7:20 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: devicetree, Mathieu Poirier, Krzysztof Kozlowski,
Manivannan Sadhasivam, linux-remoteproc, linux-arm-msm,
Conor Dooley, phone-devel, linux-kernel, Bjorn Andersson,
~postmarketos/upstreaming
On Thu Jul 10, 2025 at 12:30 AM CEST, Rob Herring (Arm) wrote:
>
> On Wed, 09 Jul 2025 13:13:07 +0200, Luca Weiss wrote:
>> Document the bindings for the ADSP, CDSP, MPSS and WPSS PAS on the Milos
>> (e.g. SM7635) SoC.
>>
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> ---
>> .../bindings/remoteproc/qcom,milos-pas.yaml | 201 +++++++++++++++++++++
>> 1 file changed, 201 insertions(+)
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.example.dts:20:18: fatal error: dt-bindings/interconnect/qcom,milos-rpmh.h: No such file or directory
> 20 | #include <dt-bindings/interconnect/qcom,milos-rpmh.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I forgot to mark the milos interconnect series to be a dependency of
this.
If a resend is necessary, I can add it in v4.
Regards
Luca
> compilation terminated.
> make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1519: dt_binding_check] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250709-sm7635-remoteprocs-v3-1-c943be976180@fairphone.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs
2025-07-09 11:13 ` [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs Luca Weiss
2025-07-09 22:30 ` Rob Herring (Arm)
@ 2025-07-21 6:42 ` Peng Fan
2025-07-21 11:38 ` Krzysztof Kozlowski
1 sibling, 1 reply; 8+ messages in thread
From: Peng Fan @ 2025-07-21 6:42 UTC (permalink / raw)
To: Luca Weiss
Cc: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel
On Wed, Jul 09, 2025 at 01:13:07PM +0200, Luca Weiss wrote:
>Document the bindings for the ADSP, CDSP, MPSS and WPSS PAS on the Milos
>(e.g. SM7635) SoC.
>
>Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>---
> .../bindings/remoteproc/qcom,milos-pas.yaml | 201 +++++++++++++++++++++
> 1 file changed, 201 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
>new file mode 100644
>index 0000000000000000000000000000000000000000..790ad38a0330bf81f6333e887522ddb97690edbc
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
>@@ -0,0 +1,201 @@
>+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
>+%YAML 1.2
>+---
>+$id: http://devicetree.org/schemas/remoteproc/qcom,milos-pas.yaml#
>+$schema: http://devicetree.org/meta-schemas/core.yaml#
>+
>+title: Qualcomm Milos SoC Peripheral Authentication Service
>+
>+maintainers:
>+ - Luca Weiss <luca.weiss@fairphone.com>
>+
>+description:
>+ Qualcomm Milos SoC Peripheral Authentication Service loads and boots firmware
>+ on the Qualcomm DSP Hexagon cores.
>+
>+properties:
>+ compatible:
>+ enum:
>+ - qcom,milos-adsp-pas
>+ - qcom,milos-cdsp-pas
>+ - qcom,milos-mpss-pas
>+ - qcom,milos-wpss-pas
>+
>+ reg:
>+ maxItems: 1
>+
>+ clocks:
>+ items:
>+ - description: XO clock
>+
>+ clock-names:
>+ items:
>+ - const: xo
>+
>+ interrupts:
>+ minItems: 6
>+ maxItems: 6
If minItems and maxItems are same, just keep minItems.
>+
>+ interrupt-names:
>+ minItems: 6
>+ maxItems: 6
Ditto.
Do you need to define the list?
>+
>+ qcom,qmp:
>+ $ref: /schemas/types.yaml#/definitions/phandle
>+ description: Reference to the AOSS side-channel message RAM.
>+
>+ smd-edge: false
>+
>+ firmware-name:
>+ $ref: /schemas/types.yaml#/definitions/string-array
>+ minItems: 1
>+ items:
>+ - description: Firmware name of the Hexagon core
>+ - description: Firmware name of the Hexagon Devicetree
>+
>+ memory-region:
>+ minItems: 1
>+ items:
>+ - description: Memory region for core Firmware authentication
>+ - description: Memory region for Devicetree Firmware authentication
>+
>+required:
>+ - compatible
>+ - reg
>+ - memory-region
>+
>+allOf:
>+ - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
>+ - if:
>+ properties:
>+ compatible:
>+ enum:
>+ - qcom,milos-adsp-pas
>+ - qcom,milos-cdsp-pas
>+ then:
>+ properties:
>+ memory-region:
>+ minItems: 2
>+ maxItems: 2
>+ firmware-name:
>+ minItems: 2
>+ maxItems: 2
Just keep minItems if maxItems is same value.
>+ else:
>+ properties:
>+ memory-region:
>+ maxItems: 1
>+ firmware-name:
>+ maxItems: 1
>+
>+ - if:
>+ properties:
>+ compatible:
>+ contains:
>+ enum:
>+ - qcom,milos-adsp-pas
>+ then:
>+ properties:
>+ power-domains:
>+ items:
>+ - description: LCX power domain
>+ - description: LMX power domain
>+ power-domain-names:
>+ items:
>+ - const: lcx
>+ - const: lmx
>+
>+ - if:
>+ properties:
>+ compatible:
>+ enum:
>+ - qcom,milos-cdsp-pas
>+ - qcom,milos-wpss-pas
>+ then:
>+ properties:
>+ power-domains:
>+ items:
>+ - description: CX power domain
>+ - description: MX power domain
>+ power-domain-names:
>+ items:
>+ - const: cx
>+ - const: mx
>+
>+ - if:
>+ properties:
>+ compatible:
>+ enum:
>+ - qcom,milos-mpss-pas
>+ then:
>+ properties:
>+ power-domains:
>+ items:
>+ - description: CX power domain
>+ - description: MSS power domain
>+ power-domain-names:
>+ items:
>+ - const: cx
>+ - const: mss
>+
>+unevaluatedProperties: false
>+
>+examples:
>+ - |
>+ #include <dt-bindings/clock/qcom,rpmh.h>
>+ #include <dt-bindings/interconnect/qcom,icc.h>
>+ #include <dt-bindings/interconnect/qcom,milos-rpmh.h>
>+ #include <dt-bindings/interrupt-controller/irq.h>
>+ #include <dt-bindings/mailbox/qcom-ipcc.h>
>+ #include <dt-bindings/power/qcom,rpmhpd.h>
>+
>+ remoteproc@3000000 {
>+ compatible = "qcom,milos-adsp-pas";
>+ reg = <0x03000000 0x10000>;
>+
>+ interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
>+ <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
>+ <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>,
>+ <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>,
>+ <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>,
>+ <&smp2p_adsp_in 7 IRQ_TYPE_EDGE_RISING>;
This seems not defined in bindings, I am not sure on this. Just a question
here.
Regards
Peng
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs
2025-07-21 6:42 ` Peng Fan
@ 2025-07-21 11:38 ` Krzysztof Kozlowski
2025-07-21 13:17 ` Peng Fan
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-21 11:38 UTC (permalink / raw)
To: Peng Fan, Luca Weiss
Cc: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel
On 21/07/2025 08:42, Peng Fan wrote:
>> +
>> + interrupt-names:
>> + minItems: 6
>> + maxItems: 6
>
> Ditto.
>
> Do you need to define the list?
Did you read the entire binding? It reminds me Frank's comment as well -
instead of actually checking you just ask question which you would find
answer by yourselves if you really opened the code.
>
>> +
>> + qcom,qmp:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description: Reference to the AOSS side-channel message RAM.
>> +
>> + smd-edge: false
>> +
>> + firmware-name:
>> + $ref: /schemas/types.yaml#/definitions/string-array
>> + minItems: 1
>> + items:
>> + - description: Firmware name of the Hexagon core
>> + - description: Firmware name of the Hexagon Devicetree
>> +
>> + memory-region:
>> + minItems: 1
>> + items:
>> + - description: Memory region for core Firmware authentication
>> + - description: Memory region for Devicetree Firmware authentication
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - memory-region
>> +
>> +allOf:
>> + - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,milos-adsp-pas
>> + - qcom,milos-cdsp-pas
>> + then:
>> + properties:
>> + memory-region:
>> + minItems: 2
>> + maxItems: 2
>> + firmware-name:
>> + minItems: 2
>> + maxItems: 2
>
> Just keep minItems if maxItems is same value.
This is not a correct advice.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs
2025-07-21 11:38 ` Krzysztof Kozlowski
@ 2025-07-21 13:17 ` Peng Fan
0 siblings, 0 replies; 8+ messages in thread
From: Peng Fan @ 2025-07-21 13:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Luca Weiss, Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel
On Mon, Jul 21, 2025 at 01:38:59PM +0200, Krzysztof Kozlowski wrote:
>On 21/07/2025 08:42, Peng Fan wrote:
>>> +
>>> + interrupt-names:
>>> + minItems: 6
>>> + maxItems: 6
>>
>> Ditto.
>>
>> Do you need to define the list?
>
>
>Did you read the entire binding? It reminds me Frank's comment as well -
I DO.
>instead of actually checking you just ask question which you would find
>answer by yourselves if you really opened the code.
I see there is a list in pas-common with entries listed. So just wonder
here is there a need to list all 6 entries. Not qcom developer, just
go through the list and see what I could do.
Things could be improved if ask language is not welcomed. Or I am
doing something wrong here?
>
>>
>>> +
>>> + qcom,qmp:
>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>> + description: Reference to the AOSS side-channel message RAM.
>>> +
>>> + smd-edge: false
>>> +
>>> + firmware-name:
>>> + $ref: /schemas/types.yaml#/definitions/string-array
>>> + minItems: 1
>>> + items:
>>> + - description: Firmware name of the Hexagon core
>>> + - description: Firmware name of the Hexagon Devicetree
>>> +
>>> + memory-region:
>>> + minItems: 1
>>> + items:
>>> + - description: Memory region for core Firmware authentication
>>> + - description: Memory region for Devicetree Firmware authentication
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - memory-region
>>> +
>>> +allOf:
>>> + - $ref: /schemas/remoteproc/qcom,pas-common.yaml#
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + enum:
>>> + - qcom,milos-adsp-pas
>>> + - qcom,milos-cdsp-pas
>>> + then:
>>> + properties:
>>> + memory-region:
>>> + minItems: 2
>>> + maxItems: 2
>>> + firmware-name:
>>> + minItems: 2
>>> + maxItems: 2
>>
>> Just keep minItems if maxItems is same value.
>
>
>This is not a correct advice.
Sorry for this. I may need to find out more in dt-schema.
Regards,
Peng
>
>
>Best regards,
>Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/2] remoteproc: qcom: pas: Add Milos remoteproc support
2025-07-09 11:13 [PATCH v3 0/2] Add support for remoteprocs on Milos SoC Luca Weiss
2025-07-09 11:13 ` [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs Luca Weiss
@ 2025-07-09 11:13 ` Luca Weiss
1 sibling, 0 replies; 8+ messages in thread
From: Luca Weiss @ 2025-07-09 11:13 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel, Luca Weiss,
Konrad Dybcio
Add the different remoteprocs found on the Milos SoC: ADSP, CDSP, MPSS
and WPSS.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
drivers/remoteproc/qcom_q6v5_pas.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index b306f223127c452f8f2d85aa0fc98db2d684feae..7cc67ee62a341d56c92bbf2e4222837c0e34cb20 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -1261,6 +1261,26 @@ static const struct adsp_data sdx55_mpss_resource = {
.ssctl_id = 0x22,
};
+static const struct adsp_data milos_cdsp_resource = {
+ .crash_reason_smem = 601,
+ .firmware_name = "cdsp.mbn",
+ .dtb_firmware_name = "cdsp_dtb.mbn",
+ .pas_id = 18,
+ .dtb_pas_id = 0x25,
+ .minidump_id = 7,
+ .auto_boot = true,
+ .proxy_pd_names = (char*[]){
+ "cx",
+ "mx",
+ NULL
+ },
+ .load_state = "cdsp",
+ .ssr_name = "cdsp",
+ .sysmon_name = "cdsp",
+ .ssctl_id = 0x17,
+ .smem_host_id = 5,
+};
+
static const struct adsp_data sm8450_mpss_resource = {
.crash_reason_smem = 421,
.firmware_name = "modem.mdt",
@@ -1435,6 +1455,10 @@ static const struct adsp_data sm8750_mpss_resource = {
};
static const struct of_device_id adsp_of_match[] = {
+ { .compatible = "qcom,milos-adsp-pas", .data = &sm8550_adsp_resource},
+ { .compatible = "qcom,milos-cdsp-pas", .data = &milos_cdsp_resource},
+ { .compatible = "qcom,milos-mpss-pas", .data = &sm8450_mpss_resource},
+ { .compatible = "qcom,milos-wpss-pas", .data = &sc7280_wpss_resource},
{ .compatible = "qcom,msm8226-adsp-pil", .data = &msm8996_adsp_resource},
{ .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource},
{ .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
--
2.50.0
^ permalink raw reply related [flat|nested] 8+ messages in thread