[PATCH 0/2] MIPS: mobileye: dts: rename the emmc controller

[PATCH 0/2] MIPS: mobileye: dts: rename the emmc controller

[Benoît Monin]

I somehow missed running dtbs_check with W=1 but the kernel test robot
did...

This patchset change the name of the SDHCI controller to match the
expected pattern from the mmc-controller binding in the eyeQ5 and eyeQ6H
device trees.

Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
---
Benoît Monin (2):
      MIPS: mobileye: dts: eyeq5: rename the emmc controller
      MIPS: mobileye: dts: eyeq6h: rename the emmc controller

 arch/mips/boot/dts/mobileye/eyeq5.dtsi  | 2 +-
 arch/mips/boot/dts/mobileye/eyeq6h.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: 05adbee3ad528100ab0285c15c91100e19e10138
change-id: 20250722-mmc_dts_warnings-ae5c40a23a85

Best regards,
-- 
Benoît Monin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH 1/2] MIPS: mobileye: dts: eyeq5: rename the emmc controller

[Benoît Monin]

The name should match the pattern defined in the mmc-controller binding.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507220336.JhvVLL7k-lkp@intel.com/
Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
---
 arch/mips/boot/dts/mobileye/eyeq5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/mobileye/eyeq5.dtsi b/arch/mips/boot/dts/mobileye/eyeq5.dtsi
index 699eeb30ced8159b6a0b5d75541f1e6cb6ef4e5e..36a73e8a63a1ab32d1c300d17c4491b175428cdf 100644
--- a/arch/mips/boot/dts/mobileye/eyeq5.dtsi
+++ b/arch/mips/boot/dts/mobileye/eyeq5.dtsi
@@ -254,7 +254,7 @@ timer {
 			};
 		};
 
-		emmc: sdhci@2200000 {
+		emmc: mmc@2200000 {
 			compatible = "mobileye,eyeq-sd4hc", "cdns,sd4hc";
 			reg = <0 0x2200000 0x0 0x1000>;
 			interrupt-parent = <&gic>;

-- 
2.50.1

[PATCH 2/2] MIPS: mobileye: dts: eyeq6h: rename the emmc controller

[Benoît Monin]

The name should match the pattern defined in the mmc-controller binding.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202507220215.wVoUMK5B-lkp@intel.com/
Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
---
 arch/mips/boot/dts/mobileye/eyeq6h.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/mobileye/eyeq6h.dtsi b/arch/mips/boot/dts/mobileye/eyeq6h.dtsi
index bbd463435ad658105a862c5b550d21e1110e7c8c..5ae939d25ea87ddc15cb848c249beed3d07e32e0 100644
--- a/arch/mips/boot/dts/mobileye/eyeq6h.dtsi
+++ b/arch/mips/boot/dts/mobileye/eyeq6h.dtsi
@@ -109,7 +109,7 @@ olb_east: system-controller@d3358000 {
 			clock-names = "ref";
 		};
 
-		emmc: sdhci@d8010000 {
+		emmc: mmc@d8010000 {
 			compatible = "mobileye,eyeq-sd4hc", "cdns,sd4hc";
 			reg = <0 0xd8010000 0x0 0x1000>;
 			interrupt-parent = <&gic>;

-- 
2.50.1

Re: [PATCH 1/2] MIPS: mobileye: dts: eyeq5: rename the emmc controller

[Krzysztof Kozlowski]

On 22/07/2025 17:15, Benoît Monin wrote:
> The name should match the pattern defined in the mmc-controller binding.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507220336.JhvVLL7k-lkp@intel.com/
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>

The important point of that binding here:
https://lore.kernel.org/linux-devicetree/9b34b471d1e71cf47c503aed7145fab896767ba7.1750156323.git.benoit.monin@bootlin.com/

was to USE it for testing it. Before you send such work, you are
supposed to check your code with the toolset.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 2/2] MIPS: mobileye: dts: eyeq6h: rename the emmc controller

[Krzysztof Kozlowski]

On 22/07/2025 17:15, Benoît Monin wrote:
> The name should match the pattern defined in the mmc-controller binding.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507220215.wVoUMK5B-lkp@intel.com/
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
> ---
>  arch/mips/boot/dts/mobileye/eyeq6h.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This should be squashed. It is trivial node name alignment with schema.
We don't fix it one by one, it's a churn.

Best regards,
Krzysztof

Re: [PATCH 0/2] MIPS: mobileye: dts: rename the emmc controller

[Thomas Bogendoerfer]

On Tue, Jul 22, 2025 at 05:15:19PM +0200, Benoît Monin wrote:
> I somehow missed running dtbs_check with W=1 but the kernel test robot
> did...
> 
> This patchset change the name of the SDHCI controller to match the
> expected pattern from the mmc-controller binding in the eyeQ5 and eyeQ6H
> device trees.
> 
> Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
> ---
> Benoît Monin (2):
>       MIPS: mobileye: dts: eyeq5: rename the emmc controller
>       MIPS: mobileye: dts: eyeq6h: rename the emmc controller
> 
>  arch/mips/boot/dts/mobileye/eyeq5.dtsi  | 2 +-
>  arch/mips/boot/dts/mobileye/eyeq6h.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> ---
> base-commit: 05adbee3ad528100ab0285c15c91100e19e10138
> change-id: 20250722-mmc_dts_warnings-ae5c40a23a85
> 
> Best regards,
> -- 
> Benoît Monin, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

applied to mips-next with both patches squashed into one

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]