From: Christoph Hellwig <hch@lst.de>
To: Kamaljit Singh <kamaljit.singh1@wdc.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
cassel@kernel.org, dlemoal@kernel.org
Subject: Re: [PATCH v4 2/2] nvme: prevent admin controller from smart log fetch (LID 2)
Date: Tue, 22 Jul 2025 08:30:15 +0200 [thread overview]
Message-ID: <20250722063015.GC15013@lst.de> (raw)
In-Reply-To: <20250721173700.4153098-3-kamaljit.singh1@wdc.com>
On Mon, Jul 21, 2025 at 10:37:00AM -0700, Kamaljit Singh wrote:
> Similar to a discovery ctrl, prevent an admin-ctrl from getting a smart
> log. LID 2 is optional for admin controllers to support.
>
> In the future when support for the newly added LID=0 (supported log
> pages) is added, GLP accesses can be made smarter by basing such calls
> on response from LID=0 reads.
Umm, as pointed out last time, this log page is prohibited for discovery
controllers, but optional for admin controllers. So I don't see why
we want or need to skip it here.
next prev parent reply other threads:[~2025-07-22 6:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 17:36 [PATCH v4 0/2] Support for Administrative Controllers Kamaljit Singh
2025-07-21 17:36 ` [PATCH v4 1/2] nvme: add capability to connect to an administrative controller Kamaljit Singh
2025-07-22 6:28 ` Christoph Hellwig
2025-07-21 17:37 ` [PATCH v4 2/2] nvme: prevent admin controller from smart log fetch (LID 2) Kamaljit Singh
2025-07-22 6:30 ` Christoph Hellwig [this message]
2025-07-22 16:34 ` Kamaljit Singh
2025-07-23 6:11 ` hch
2025-07-23 18:27 ` Kamaljit Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250722063015.GC15013@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kamaljit.singh1@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).