linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb+git@google.com>
To: linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org, x86@kernel.org,
	 Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Ingo Molnar <mingo@kernel.org>,
	 Kevin Loughlin <kevinloughlin@google.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	 Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	 Nikunj A Dadhania <nikunj@amd.com>
Subject: [PATCH v6 02/22] x86/sev: Use MSR protocol for remapping SVSM calling area
Date: Tue, 22 Jul 2025 09:27:11 +0200	[thread overview]
Message-ID: <20250722072708.2079165-26-ardb+git@google.com> (raw)
In-Reply-To: <20250722072708.2079165-24-ardb+git@google.com>

From: Ard Biesheuvel <ardb@kernel.org>

As the preceding code comment already indicates, remapping the SVSM
calling area occurs long before the GHCB page is configured, and so
calling svsm_perform_call_protocol() is guaranteed to result in a call
to svsm_perform_msr_protocol().

So just call the latter directly. This allows most of the GHCB based API
infrastructure to be moved out of the startup code in a subsequent
patch.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 arch/x86/boot/startup/sev-shared.c  | 11 +++++++++++
 arch/x86/boot/startup/sev-startup.c |  5 ++---
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/arch/x86/boot/startup/sev-shared.c b/arch/x86/boot/startup/sev-shared.c
index a1e211e0000c..4b958d03834b 100644
--- a/arch/x86/boot/startup/sev-shared.c
+++ b/arch/x86/boot/startup/sev-shared.c
@@ -724,6 +724,17 @@ static void __head setup_cpuid_table(const struct cc_blob_sev_info *cc_info)
 	}
 }
 
+static int __head svsm_call_msr_protocol(struct svsm_call *call)
+{
+	int ret;
+
+	do {
+		ret = svsm_perform_msr_protocol(call);
+	} while (ret == -EAGAIN);
+
+	return ret;
+}
+
 static void __head svsm_pval_4k_page(unsigned long paddr, bool validate)
 {
 	struct svsm_pvalidate_call *pc;
diff --git a/arch/x86/boot/startup/sev-startup.c b/arch/x86/boot/startup/sev-startup.c
index 0b7e3b950183..8412807a865c 100644
--- a/arch/x86/boot/startup/sev-startup.c
+++ b/arch/x86/boot/startup/sev-startup.c
@@ -295,7 +295,6 @@ static __head struct cc_blob_sev_info *find_cc_blob(struct boot_params *bp)
 static __head void svsm_setup(struct cc_blob_sev_info *cc_info)
 {
 	struct svsm_call call = {};
-	int ret;
 	u64 pa;
 
 	/*
@@ -325,8 +324,8 @@ static __head void svsm_setup(struct cc_blob_sev_info *cc_info)
 	call.caa = svsm_get_caa();
 	call.rax = SVSM_CORE_CALL(SVSM_CORE_REMAP_CA);
 	call.rcx = pa;
-	ret = svsm_perform_call_protocol(&call);
-	if (ret)
+
+	if (svsm_call_msr_protocol(&call))
 		sev_es_terminate(SEV_TERM_SET_LINUX, GHCB_TERM_SVSM_CA_REMAP_FAIL);
 
 	boot_svsm_caa = (struct svsm_ca *)pa;
-- 
2.50.0.727.gbf7dc18ff4-goog


  parent reply	other threads:[~2025-07-22  7:29 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  7:27 [PATCH v6 00/22] x86: strict separation of startup code Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 01/22] x86/sev: Separate MSR and GHCB based snp_cpuid() via a callback Ard Biesheuvel
2025-07-22  7:27 ` Ard Biesheuvel [this message]
2025-07-22  7:27 ` [PATCH v6 03/22] x86/sev: Use MSR protocol only for early SVSM PVALIDATE call Ard Biesheuvel
2025-07-29 13:48   ` Tom Lendacky
2025-07-22  7:27 ` [PATCH v6 04/22] x86/sev: Run RMPADJUST on SVSM calling area page to test VMPL Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 05/22] x86/sev: Move GHCB page based HV communication out of startup code Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 06/22] x86/sev: Avoid global variable to store virtual address of SVSM area Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 07/22] x86/sev: Share implementation of MSR-based page state change Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 08/22] x86/sev: Pass SVSM calling area down to early page state change API Ard Biesheuvel
2025-08-10 20:36   ` Borislav Petkov
2025-07-22  7:27 ` [PATCH v6 09/22] x86/sev: Use boot SVSM CA for all startup and init code Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 10/22] x86/boot: Drop redundant RMPADJUST in SEV SVSM presence check Ard Biesheuvel
2025-08-11  6:30   ` Borislav Petkov
2025-08-28  7:36     ` Ard Biesheuvel
2025-08-28 14:47       ` Borislav Petkov
2025-07-22  7:27 ` [PATCH v6 11/22] x86/boot: Provide PIC aliases for 5-level paging related constants Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 12/22] x86/sev: Provide PIC aliases for SEV related data objects Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 13/22] x86/sev: Move __sev_[get|put]_ghcb() into separate noinstr object Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 14/22] x86/sev: Export startup routines for later use Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 15/22] objtool: Add action to check for absence of absolute relocations Ard Biesheuvel
2025-08-11  7:20   ` Borislav Petkov
2025-07-22  7:27 ` [PATCH v6 16/22] x86/boot: Check startup code " Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 17/22] x86/boot: Revert "Reject absolute references in .head.text" Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 18/22] x86/kbuild: Incorporate boot/startup/ via Kbuild makefile Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 19/22] x86/boot: Create a confined code area for startup code Ard Biesheuvel
2025-08-11 10:19   ` Borislav Petkov
2025-07-22  7:27 ` [PATCH v6 20/22] efistub/x86: Remap inittext read-execute when needed Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 21/22] x86/boot: Move startup code out of __head section Ard Biesheuvel
2025-08-11 17:40   ` Borislav Petkov
2025-08-11 18:05     ` Tom Lendacky
2025-08-11 19:03       ` Borislav Petkov
2025-08-14 17:17         ` Tom Lendacky
2025-08-28  6:50           ` Ard Biesheuvel
2025-08-28  6:55             ` Ard Biesheuvel
2025-07-22  7:27 ` [PATCH v6 22/22] x86/boot: Get rid of the .head.text section Ard Biesheuvel
2025-08-11 14:17 ` [PATCH v6 00/22] x86: strict separation of startup code Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722072708.2079165-26-ardb+git@google.com \
    --to=ardb+git@google.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=jpoimboe@kernel.org \
    --cc=kevinloughlin@google.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=nikunj@amd.com \
    --cc=peterz@infradead.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).