* [PATCH] arm64: dts: rockchip: Drop netdev triggers on NanoPi R5S
@ 2025-07-22 12:35 Diederik de Haas
2025-07-22 19:02 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Diederik de Haas @ 2025-07-22 12:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
Cc: Dragan Simic, Vasily Khoruzhick, Tianling Shen, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, Diederik de Haas,
Robin Murphy
Sometimes the netdev triggers causes tasks to get blocked for more then
120 seconds, which in turn makes the (WAN) network port on the NanoPi
R5S fail to come up.
This results in the following (partial) trace:
INFO: task kworker/0:1:11 blocked for more than 120 seconds.
Not tainted 6.16-rc6+unreleased-arm64-cknow #1 Debian 6.16~rc6-1~exp1
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
task:kworker/0:1 state:D stack:0 pid:11 tgid:11 ppid:2 task_flags:0x4208060 flags:0x00000010
Workqueue: events_power_efficient reg_check_chans_work [cfg80211]
Call trace:
__switch_to+0xf8/0x168 (T)
__schedule+0x3f8/0xda8
schedule+0x3c/0x120
schedule_preempt_disabled+0x2c/0x58
__mutex_lock.constprop.0+0x4d0/0xab8
__mutex_lock_slowpath+0x1c/0x30
mutex_lock+0x50/0x68
rtnl_lock+0x20/0x38
reg_check_chans_work+0x40/0x478 [cfg80211]
process_one_work+0x178/0x3e0
worker_thread+0x260/0x390
kthread+0x150/0x250
ret_from_fork+0x10/0x20
INFO: task kworker/0:1:11 is blocked on a mutex likely owned by task dhcpcd:615.
task:dhcpcd state:D stack:0 pid:615 tgid:615 ppid:614 task_flags:0x400140 flags:0x00000018
Call trace:
__switch_to+0xf8/0x168 (T)
__schedule+0x3f8/0xda8
schedule+0x3c/0x120
schedule_preempt_disabled+0x2c/0x58
rwsem_down_write_slowpath+0x1e4/0x750
down_write+0x98/0xb0
led_trigger_register+0x134/0x1c0
phy_led_triggers_register+0xf4/0x258 [libphy]
phy_attach_direct+0x30c/0x390 [libphy]
phylink_fwnode_phy_connect+0xb0/0x138 [phylink]
__stmmac_open+0xec/0x520 [stmmac]
stmmac_open+0x4c/0xe8 [stmmac]
__dev_open+0x130/0x2e0
__dev_change_flags+0x1c4/0x248
netif_change_flags+0x2c/0x80
dev_change_flags+0x88/0xc8
devinet_ioctl+0x35c/0x610
inet_ioctl+0x204/0x260
sock_do_ioctl+0x6c/0x140
sock_ioctl+0x2e4/0x388
__arm64_sys_ioctl+0xb4/0x120
invoke_syscall+0x6c/0x100
el0_svc_common.constprop.0+0x48/0xf0
do_el0_svc+0x24/0x38
el0_svc+0x3c/0x188
el0t_64_sync_handler+0x10c/0x140
el0t_64_sync+0x198/0x1a0
In order to not introduce a regression with kernel 6.16, drop the netdev
triggers for now while the problem is being investigated further.
Fixes: 1631cbdb8089 ("arm64: dts: rockchip: Improve LED config for NanoPi R5S")
Helped-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
index 3b31f0dd8f3b..539edc3c535f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
@@ -29,7 +29,6 @@ led-lan1 {
function-enumerator = <1>;
gpios = <&gpio3 RK_PD6 GPIO_ACTIVE_HIGH>;
label = "LAN-1";
- linux,default-trigger = "netdev";
};
led-lan2 {
@@ -39,7 +38,6 @@ led-lan2 {
function-enumerator = <2>;
gpios = <&gpio3 RK_PD7 GPIO_ACTIVE_HIGH>;
label = "LAN-2";
- linux,default-trigger = "netdev";
};
power_led: led-sys {
@@ -56,7 +54,6 @@ led-wan {
function = LED_FUNCTION_WAN;
gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
label = "WAN";
- linux,default-trigger = "netdev";
};
};
};
--
2.50.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Drop netdev triggers on NanoPi R5S
2025-07-22 12:35 [PATCH] arm64: dts: rockchip: Drop netdev triggers on NanoPi R5S Diederik de Haas
@ 2025-07-22 19:02 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2025-07-22 19:02 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Diederik de Haas
Cc: Heiko Stuebner, Dragan Simic, Vasily Khoruzhick, Tianling Shen,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Robin Murphy
On Tue, 22 Jul 2025 14:35:33 +0200, Diederik de Haas wrote:
> Sometimes the netdev triggers causes tasks to get blocked for more then
> 120 seconds, which in turn makes the (WAN) network port on the NanoPi
> R5S fail to come up.
> This results in the following (partial) trace:
>
> INFO: task kworker/0:1:11 blocked for more than 120 seconds.
> Not tainted 6.16-rc6+unreleased-arm64-cknow #1 Debian 6.16~rc6-1~exp1
> "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> task:kworker/0:1 state:D stack:0 pid:11 tgid:11 ppid:2 task_flags:0x4208060 flags:0x00000010
> Workqueue: events_power_efficient reg_check_chans_work [cfg80211]
> Call trace:
> __switch_to+0xf8/0x168 (T)
> __schedule+0x3f8/0xda8
> schedule+0x3c/0x120
> schedule_preempt_disabled+0x2c/0x58
> __mutex_lock.constprop.0+0x4d0/0xab8
> __mutex_lock_slowpath+0x1c/0x30
> mutex_lock+0x50/0x68
> rtnl_lock+0x20/0x38
> reg_check_chans_work+0x40/0x478 [cfg80211]
> process_one_work+0x178/0x3e0
> worker_thread+0x260/0x390
> kthread+0x150/0x250
> ret_from_fork+0x10/0x20
> INFO: task kworker/0:1:11 is blocked on a mutex likely owned by task dhcpcd:615.
> task:dhcpcd state:D stack:0 pid:615 tgid:615 ppid:614 task_flags:0x400140 flags:0x00000018
> Call trace:
> __switch_to+0xf8/0x168 (T)
> __schedule+0x3f8/0xda8
> schedule+0x3c/0x120
> schedule_preempt_disabled+0x2c/0x58
> rwsem_down_write_slowpath+0x1e4/0x750
> down_write+0x98/0xb0
> led_trigger_register+0x134/0x1c0
> phy_led_triggers_register+0xf4/0x258 [libphy]
> phy_attach_direct+0x30c/0x390 [libphy]
> phylink_fwnode_phy_connect+0xb0/0x138 [phylink]
> __stmmac_open+0xec/0x520 [stmmac]
> stmmac_open+0x4c/0xe8 [stmmac]
> __dev_open+0x130/0x2e0
> __dev_change_flags+0x1c4/0x248
> netif_change_flags+0x2c/0x80
> dev_change_flags+0x88/0xc8
> devinet_ioctl+0x35c/0x610
> inet_ioctl+0x204/0x260
> sock_do_ioctl+0x6c/0x140
> sock_ioctl+0x2e4/0x388
> __arm64_sys_ioctl+0xb4/0x120
> invoke_syscall+0x6c/0x100
> el0_svc_common.constprop.0+0x48/0xf0
> do_el0_svc+0x24/0x38
> el0_svc+0x3c/0x188
> el0t_64_sync_handler+0x10c/0x140
> el0t_64_sync+0x198/0x1a0
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Drop netdev triggers on NanoPi R5S
commit: 60d89a256079895a154d0f714caee8c64de586f7
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-22 19:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-22 12:35 [PATCH] arm64: dts: rockchip: Drop netdev triggers on NanoPi R5S Diederik de Haas
2025-07-22 19:02 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).