* [PATCH][next] ACPI: pci_link: Remove space before \n newline
@ 2025-07-21 14:59 Colin Ian King
2025-07-21 21:40 ` Bjorn Helgaas
0 siblings, 1 reply; 5+ messages in thread
From: Colin Ian King @ 2025-07-21 14:59 UTC (permalink / raw)
To: Bjorn Helgaas, Rafael J . Wysocki, Len Brown, linux-pci,
linux-acpi
Cc: kernel-janitors, linux-kernel
There is an extraneous space before a newline in an acpi_handle_debug
message. Remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/acpi/pci_link.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index 08e10b6226dc..e4560b33b8ad 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -268,7 +268,7 @@ static int acpi_pci_link_get_current(struct acpi_pci_link *link)
link->irq.active = irq;
- acpi_handle_debug(handle, "Link at IRQ %d \n", link->irq.active);
+ acpi_handle_debug(handle, "Link at IRQ %d\n", link->irq.active);
end:
return result;
--
2.50.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ACPI: pci_link: Remove space before \n newline
2025-07-21 14:59 [PATCH][next] ACPI: pci_link: Remove space before \n newline Colin Ian King
@ 2025-07-21 21:40 ` Bjorn Helgaas
2025-07-22 9:48 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2025-07-21 21:40 UTC (permalink / raw)
To: Colin Ian King
Cc: Bjorn Helgaas, Rafael J . Wysocki, Len Brown, linux-pci,
linux-acpi, kernel-janitors, linux-kernel
On Mon, Jul 21, 2025 at 03:59:52PM +0100, Colin Ian King wrote:
> There is an extraneous space before a newline in an acpi_handle_debug
> message. Remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
FWIW,
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Fixes for more ACPI-related typos below, feel free to squash or I can
send separately.
> ---
> drivers/acpi/pci_link.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index 08e10b6226dc..e4560b33b8ad 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -268,7 +268,7 @@ static int acpi_pci_link_get_current(struct acpi_pci_link *link)
>
> link->irq.active = irq;
>
> - acpi_handle_debug(handle, "Link at IRQ %d \n", link->irq.active);
> + acpi_handle_debug(handle, "Link at IRQ %d\n", link->irq.active);
>
> end:
> return result;
diff --git a/Documentation/ABI/testing/sysfs-firmware-acpi b/Documentation/ABI/testing/sysfs-firmware-acpi
index f4de60c4134d..72e7c9161ce7 100644
--- a/Documentation/ABI/testing/sysfs-firmware-acpi
+++ b/Documentation/ABI/testing/sysfs-firmware-acpi
@@ -108,15 +108,15 @@ Description:
number of a "General Purpose Events" (GPE).
A GPE vectors to a specified handler in AML, which
- can do a anything the BIOS writer wants from
+ can do anything the BIOS writer wants from
OS context. GPE 0x12, for example, would vector
to a level or edge handler called _L12 or _E12.
The handler may do its business and return.
- Or the handler may send send a Notify event
+ Or the handler may send a Notify event
to a Linux device driver registered on an ACPI device,
such as a battery, or a processor.
- To figure out where all the SCI's are coming from,
+ To figure out where all the SCIs are coming from,
/sys/firmware/acpi/interrupts contains a file listing
every possible source, and the count of how many
times it has triggered::
diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
index db0c0b1f3700..1e603189b5b1 100644
--- a/Documentation/firmware-guide/acpi/gpio-properties.rst
+++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
@@ -92,8 +92,8 @@ and polarity settings. The table below shows the expectations:
| | Low | as low, assuming active |
+-------------+-------------+-----------------------------------------------+
-That said, for our above example the both GPIOs, since the bias setting
-is explicit and _DSD is present, will be treated as active with a high
+That said, for our above example, since the bias setting is explicit and
+_DSD is present, both GPIOs will be treated as active with a high
polarity and Linux will configure the pins in this state until a driver
reprograms them differently.
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index c2ab2783303f..a984ccd4a2a0 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -1406,7 +1406,7 @@ static int __init acpi_bus_init(void)
goto error1;
/*
- * Register the for all standard device notifications.
+ * Register for all standard device notifications.
*/
status =
acpi_install_notify_handler(ACPI_ROOT_OBJECT, ACPI_SYSTEM_NOTIFY,
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ACPI: pci_link: Remove space before \n newline
2025-07-21 21:40 ` Bjorn Helgaas
@ 2025-07-22 9:48 ` Rafael J. Wysocki
2025-07-22 13:26 ` Bjorn Helgaas
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2025-07-22 9:48 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Colin Ian King, Bjorn Helgaas, Rafael J . Wysocki, Len Brown,
linux-pci, linux-acpi, kernel-janitors, linux-kernel
On Mon, Jul 21, 2025 at 11:40 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Mon, Jul 21, 2025 at 03:59:52PM +0100, Colin Ian King wrote:
> > There is an extraneous space before a newline in an acpi_handle_debug
> > message. Remove it.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> FWIW,
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Fixes for more ACPI-related typos below, feel free to squash or I can
> send separately.
If I can assume your sign-off on this, no need to resend.
> > ---
> > drivers/acpi/pci_link.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> > index 08e10b6226dc..e4560b33b8ad 100644
> > --- a/drivers/acpi/pci_link.c
> > +++ b/drivers/acpi/pci_link.c
> > @@ -268,7 +268,7 @@ static int acpi_pci_link_get_current(struct acpi_pci_link *link)
> >
> > link->irq.active = irq;
> >
> > - acpi_handle_debug(handle, "Link at IRQ %d \n", link->irq.active);
> > + acpi_handle_debug(handle, "Link at IRQ %d\n", link->irq.active);
> >
> > end:
> > return result;
>
> diff --git a/Documentation/ABI/testing/sysfs-firmware-acpi b/Documentation/ABI/testing/sysfs-firmware-acpi
> index f4de60c4134d..72e7c9161ce7 100644
> --- a/Documentation/ABI/testing/sysfs-firmware-acpi
> +++ b/Documentation/ABI/testing/sysfs-firmware-acpi
> @@ -108,15 +108,15 @@ Description:
> number of a "General Purpose Events" (GPE).
>
> A GPE vectors to a specified handler in AML, which
> - can do a anything the BIOS writer wants from
> + can do anything the BIOS writer wants from
> OS context. GPE 0x12, for example, would vector
> to a level or edge handler called _L12 or _E12.
> The handler may do its business and return.
> - Or the handler may send send a Notify event
> + Or the handler may send a Notify event
> to a Linux device driver registered on an ACPI device,
> such as a battery, or a processor.
>
> - To figure out where all the SCI's are coming from,
> + To figure out where all the SCIs are coming from,
> /sys/firmware/acpi/interrupts contains a file listing
> every possible source, and the count of how many
> times it has triggered::
> diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
> index db0c0b1f3700..1e603189b5b1 100644
> --- a/Documentation/firmware-guide/acpi/gpio-properties.rst
> +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
> @@ -92,8 +92,8 @@ and polarity settings. The table below shows the expectations:
> | | Low | as low, assuming active |
> +-------------+-------------+-----------------------------------------------+
>
> -That said, for our above example the both GPIOs, since the bias setting
> -is explicit and _DSD is present, will be treated as active with a high
> +That said, for our above example, since the bias setting is explicit and
> +_DSD is present, both GPIOs will be treated as active with a high
> polarity and Linux will configure the pins in this state until a driver
> reprograms them differently.
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index c2ab2783303f..a984ccd4a2a0 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -1406,7 +1406,7 @@ static int __init acpi_bus_init(void)
> goto error1;
>
> /*
> - * Register the for all standard device notifications.
> + * Register for all standard device notifications.
> */
> status =
> acpi_install_notify_handler(ACPI_ROOT_OBJECT, ACPI_SYSTEM_NOTIFY,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ACPI: pci_link: Remove space before \n newline
2025-07-22 9:48 ` Rafael J. Wysocki
@ 2025-07-22 13:26 ` Bjorn Helgaas
2025-07-22 15:21 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2025-07-22 13:26 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Colin Ian King, Bjorn Helgaas, Len Brown, linux-pci, linux-acpi,
kernel-janitors, linux-kernel
On Tue, Jul 22, 2025 at 11:48:07AM +0200, Rafael J. Wysocki wrote:
> On Mon, Jul 21, 2025 at 11:40 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> ...
> >
> > Fixes for more ACPI-related typos below, feel free to squash or I can
> > send separately.
>
> If I can assume your sign-off on this, no need to resend.
Of course, sorry, my fault:
commit 9cdbf361a40d ("ACPI: Fix typos")
Author: Bjorn Helgaas <bhelgaas@google.com>
Date: Mon Jul 21 16:37:14 2025 -0500
ACPI: Fix typos
Fix typos in documentation and comments.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
diff --git a/Documentation/ABI/testing/sysfs-firmware-acpi b/Documentation/ABI/testing/sysfs-firmware-acpi
index f4de60c4134d..72e7c9161ce7 100644
--- a/Documentation/ABI/testing/sysfs-firmware-acpi
+++ b/Documentation/ABI/testing/sysfs-firmware-acpi
@@ -108,15 +108,15 @@ Description:
number of a "General Purpose Events" (GPE).
A GPE vectors to a specified handler in AML, which
- can do a anything the BIOS writer wants from
+ can do anything the BIOS writer wants from
OS context. GPE 0x12, for example, would vector
to a level or edge handler called _L12 or _E12.
The handler may do its business and return.
- Or the handler may send send a Notify event
+ Or the handler may send a Notify event
to a Linux device driver registered on an ACPI device,
such as a battery, or a processor.
- To figure out where all the SCI's are coming from,
+ To figure out where all the SCIs are coming from,
/sys/firmware/acpi/interrupts contains a file listing
every possible source, and the count of how many
times it has triggered::
diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
index db0c0b1f3700..1e603189b5b1 100644
--- a/Documentation/firmware-guide/acpi/gpio-properties.rst
+++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
@@ -92,8 +92,8 @@ and polarity settings. The table below shows the expectations:
| | Low | as low, assuming active |
+-------------+-------------+-----------------------------------------------+
-That said, for our above example the both GPIOs, since the bias setting
-is explicit and _DSD is present, will be treated as active with a high
+That said, for our above example, since the bias setting is explicit and
+_DSD is present, both GPIOs will be treated as active with a high
polarity and Linux will configure the pins in this state until a driver
reprograms them differently.
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index c2ab2783303f..a984ccd4a2a0 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -1406,7 +1406,7 @@ static int __init acpi_bus_init(void)
goto error1;
/*
- * Register the for all standard device notifications.
+ * Register for all standard device notifications.
*/
status =
acpi_install_notify_handler(ACPI_ROOT_OBJECT, ACPI_SYSTEM_NOTIFY,
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ACPI: pci_link: Remove space before \n newline
2025-07-22 13:26 ` Bjorn Helgaas
@ 2025-07-22 15:21 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2025-07-22 15:21 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Rafael J. Wysocki, Colin Ian King, Bjorn Helgaas, Len Brown,
linux-pci, linux-acpi, kernel-janitors, linux-kernel
On Tue, Jul 22, 2025 at 3:26 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Tue, Jul 22, 2025 at 11:48:07AM +0200, Rafael J. Wysocki wrote:
> > On Mon, Jul 21, 2025 at 11:40 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> > ...
> > >
> > > Fixes for more ACPI-related typos below, feel free to squash or I can
> > > send separately.
> >
> > If I can assume your sign-off on this, no need to resend.
>
> Of course, sorry, my fault:
No worries.
> commit 9cdbf361a40d ("ACPI: Fix typos")
> Author: Bjorn Helgaas <bhelgaas@google.com>
> Date: Mon Jul 21 16:37:14 2025 -0500
>
> ACPI: Fix typos
>
> Fix typos in documentation and comments.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
>
> diff --git a/Documentation/ABI/testing/sysfs-firmware-acpi b/Documentation/ABI/testing/sysfs-firmware-acpi
> index f4de60c4134d..72e7c9161ce7 100644
> --- a/Documentation/ABI/testing/sysfs-firmware-acpi
> +++ b/Documentation/ABI/testing/sysfs-firmware-acpi
> @@ -108,15 +108,15 @@ Description:
> number of a "General Purpose Events" (GPE).
>
> A GPE vectors to a specified handler in AML, which
> - can do a anything the BIOS writer wants from
> + can do anything the BIOS writer wants from
> OS context. GPE 0x12, for example, would vector
> to a level or edge handler called _L12 or _E12.
> The handler may do its business and return.
> - Or the handler may send send a Notify event
> + Or the handler may send a Notify event
> to a Linux device driver registered on an ACPI device,
> such as a battery, or a processor.
>
> - To figure out where all the SCI's are coming from,
> + To figure out where all the SCIs are coming from,
> /sys/firmware/acpi/interrupts contains a file listing
> every possible source, and the count of how many
> times it has triggered::
> diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
> index db0c0b1f3700..1e603189b5b1 100644
> --- a/Documentation/firmware-guide/acpi/gpio-properties.rst
> +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
> @@ -92,8 +92,8 @@ and polarity settings. The table below shows the expectations:
> | | Low | as low, assuming active |
> +-------------+-------------+-----------------------------------------------+
>
> -That said, for our above example the both GPIOs, since the bias setting
> -is explicit and _DSD is present, will be treated as active with a high
> +That said, for our above example, since the bias setting is explicit and
> +_DSD is present, both GPIOs will be treated as active with a high
> polarity and Linux will configure the pins in this state until a driver
> reprograms them differently.
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index c2ab2783303f..a984ccd4a2a0 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -1406,7 +1406,7 @@ static int __init acpi_bus_init(void)
> goto error1;
>
> /*
> - * Register the for all standard device notifications.
> + * Register for all standard device notifications.
> */
> status =
> acpi_install_notify_handler(ACPI_ROOT_OBJECT, ACPI_SYSTEM_NOTIFY,
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-07-22 15:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-21 14:59 [PATCH][next] ACPI: pci_link: Remove space before \n newline Colin Ian King
2025-07-21 21:40 ` Bjorn Helgaas
2025-07-22 9:48 ` Rafael J. Wysocki
2025-07-22 13:26 ` Bjorn Helgaas
2025-07-22 15:21 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).