[PATCH v3 0/2] staging: rtl8723bs: fix coding style issues

[PATCH v3 0/2] staging: rtl8723bs: fix coding style issues

[Ali Nasrolahi]

This patch series addresses several coding style and comment formatting issues
in the rtl8723bs staging driver as reported by checkpatch.pl.

Thanks for your time and feedbacks

Ali Nasrolahi (2):
  staging: rtl8723bs: fix comment formatting in basic_types.h
  staging: rtl8723bs: fix comment style and formatting in
    osdep_service.c

 drivers/staging/rtl8723bs/include/basic_types.h  | 13 ++++++-------
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 11 ++++++-----
 2 files changed, 12 insertions(+), 12 deletions(-)

-- 
2.50.1

[PATCH v3 1/2] staging: rtl8723bs: fix comment formatting in basic_types.h

[Ali Nasrolahi]

Signed-off-by: Ali Nasrolahi <A.Nasrolahi01@gmail.com>
---
 drivers/staging/rtl8723bs/include/basic_types.h | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h
index 57bb717327c..e2f203910be 100644
--- a/drivers/staging/rtl8723bs/include/basic_types.h
+++ b/drivers/staging/rtl8723bs/include/basic_types.h
@@ -26,7 +26,7 @@
  *	1. Read/write packet content.
  *	2. Before write integer to IO.
  *	3. After read integer from IO.
-*/
+ */
 
 /*  */
 /*  Byte Swapping routine. */
@@ -94,7 +94,7 @@
 #define BIT_OFFSET_LEN_MASK_8(__bitoffset, __bitlen) \
 	(BIT_LEN_MASK_8(__bitlen) << (__bitoffset))
 
-/*Description:
+/* Description:
  * Return 4-byte value in host byte ordering from
  * 4-byte pointer in little-endian system.
  */
@@ -105,11 +105,10 @@
 #define LE_P1BYTE_TO_HOST_1BYTE(__pstart) \
 	(EF1BYTE(*((u8 *)(__pstart))))
 
-/*  */
-/* 	Description: */
-/* 		Translate subfield (continuous bits in little-endian) of 4-byte value in litten byte to */
-/* 		4-byte value in host byte ordering. */
-/*  */
+/* Description:
+ *	Translate subfield (continuous bits in little-endian) of 4-byte value in litten byte to
+ *	4-byte value in host byte ordering.
+ */
 #define LE_BITS_TO_4BYTE(__pstart, __bitoffset, __bitlen) \
 	(\
 		(LE_P4BYTE_TO_HOST_4BYTE(__pstart) >> (__bitoffset))  & \
-- 
2.50.1

[PATCH v3 2/2] staging: rtl8723bs: fix comment style and formatting in osdep_service.c

[Ali Nasrolahi]

Signed-off-by: Ali Nasrolahi <A.Nasrolahi01@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c85c..60c3da009a5 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -7,9 +7,9 @@
 #include <drv_types.h>
 
 /*
-* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
-* @return: one of RTW_STATUS_CODE
-*/
+ * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
+ * @return: one of RTW_STATUS_CODE
+ */
 inline int RTW_STATUS_CODE(int error_code)
 {
 	if (error_code >= 0)
@@ -152,7 +152,6 @@ void rtw_buf_update(u8 **buf, u32 *buf_len, u8 *src, u32 src_len)
 		kfree(ori);
 }
 
-
 /**
  * rtw_cbuf_full - test if cbuf is full
  * @cbuf: pointer of struct rtw_cbuf
@@ -204,6 +203,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf)
 void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
 {
 	void *buf;
+
 	if (rtw_cbuf_empty(cbuf))
 		return NULL;
 
@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
 	cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
 
 	if (cbuf) {
-		cbuf->write = cbuf->read = 0;
+		cbuf->read = 0;
+		cbuf->write = 0;
 		cbuf->size = size;
 	}
 
-- 
2.50.1

Re: [PATCH v3 0/2] staging: rtl8723bs: fix coding style issues

[Greg KH]

On Mon, Jul 21, 2025 at 08:13:41PM +0330, Ali Nasrolahi wrote:
> This patch series addresses several coding style and comment formatting issues
> in the rtl8723bs staging driver as reported by checkpatch.pl.
> 
> Thanks for your time and feedbacks
> 
> Ali Nasrolahi (2):
>   staging: rtl8723bs: fix comment formatting in basic_types.h
>   staging: rtl8723bs: fix comment style and formatting in
>     osdep_service.c
> 
>  drivers/staging/rtl8723bs/include/basic_types.h  | 13 ++++++-------
>  drivers/staging/rtl8723bs/os_dep/osdep_service.c | 11 ++++++-----
>  2 files changed, 12 insertions(+), 12 deletions(-)
> 
> -- 
> 2.50.1
> 
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch series,
  but you did not list below the --- line any changes from the previous
  version.  Please read the section entitled "The canonical patch
  format" in the kernel file,
  Documentation/process/submitting-patches.rst for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH v3 1/2] staging: rtl8723bs: fix comment formatting in basic_types.h

[Greg KH]

On Mon, Jul 21, 2025 at 08:13:42PM +0330, Ali Nasrolahi wrote:
> Signed-off-by: Ali Nasrolahi <A.Nasrolahi01@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/basic_types.h | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/basic_types.h b/drivers/staging/rtl8723bs/include/basic_types.h
> index 57bb717327c..e2f203910be 100644
> --- a/drivers/staging/rtl8723bs/include/basic_types.h
> +++ b/drivers/staging/rtl8723bs/include/basic_types.h
> @@ -26,7 +26,7 @@
>   *	1. Read/write packet content.
>   *	2. Before write integer to IO.
>   *	3. After read integer from IO.
> -*/
> + */
>  
>  /*  */
>  /*  Byte Swapping routine. */
> @@ -94,7 +94,7 @@
>  #define BIT_OFFSET_LEN_MASK_8(__bitoffset, __bitlen) \
>  	(BIT_LEN_MASK_8(__bitlen) << (__bitoffset))
>  
> -/*Description:
> +/* Description:
>   * Return 4-byte value in host byte ordering from
>   * 4-byte pointer in little-endian system.
>   */
> @@ -105,11 +105,10 @@
>  #define LE_P1BYTE_TO_HOST_1BYTE(__pstart) \
>  	(EF1BYTE(*((u8 *)(__pstart))))
>  
> -/*  */
> -/* 	Description: */
> -/* 		Translate subfield (continuous bits in little-endian) of 4-byte value in litten byte to */
> -/* 		4-byte value in host byte ordering. */
> -/*  */
> +/* Description:
> + *	Translate subfield (continuous bits in little-endian) of 4-byte value in litten byte to
> + *	4-byte value in host byte ordering.
> + */
>  #define LE_BITS_TO_4BYTE(__pstart, __bitoffset, __bitlen) \
>  	(\
>  		(LE_P4BYTE_TO_HOST_4BYTE(__pstart) >> (__bitoffset))  & \
> -- 
> 2.50.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH v3 2/2] staging: rtl8723bs: fix comment style and formatting in osdep_service.c

[Greg KH]

On Mon, Jul 21, 2025 at 08:13:43PM +0330, Ali Nasrolahi wrote:
> Signed-off-by: Ali Nasrolahi <A.Nasrolahi01@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/osdep_service.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> index a00f9f0c85c..60c3da009a5 100644
> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> @@ -7,9 +7,9 @@
>  #include <drv_types.h>
>  
>  /*
> -* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> -* @return: one of RTW_STATUS_CODE
> -*/
> + * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> + * @return: one of RTW_STATUS_CODE
> + */
>  inline int RTW_STATUS_CODE(int error_code)
>  {
>  	if (error_code >= 0)
> @@ -152,7 +152,6 @@ void rtw_buf_update(u8 **buf, u32 *buf_len, u8 *src, u32 src_len)
>  		kfree(ori);
>  }
>  
> -
>  /**
>   * rtw_cbuf_full - test if cbuf is full
>   * @cbuf: pointer of struct rtw_cbuf
> @@ -204,6 +203,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf)
>  void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
>  {
>  	void *buf;
> +
>  	if (rtw_cbuf_empty(cbuf))
>  		return NULL;
>  
> @@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
>  	cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
>  
>  	if (cbuf) {
> -		cbuf->write = cbuf->read = 0;
> +		cbuf->read = 0;
> +		cbuf->write = 0;
>  		cbuf->size = size;
>  	}
>  
> -- 
> 2.50.1
> 
> 


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot