From: Simon Horman <horms@kernel.org>
To: Tristram.Ha@microchip.com
Cc: Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Marek Vasut <marex@denx.de>,
UNGLinuxDriver@microchip.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5 3/6] net: dsa: microchip: Use different registers for KSZ8463
Date: Wed, 23 Jul 2025 17:26:47 +0100 [thread overview]
Message-ID: <20250723162647.GK1036606@horms.kernel.org> (raw)
In-Reply-To: <20250723022612.38535-4-Tristram.Ha@microchip.com>
On Tue, Jul 22, 2025 at 07:26:09PM -0700, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
>
> KSZ8463 does not use same set of registers as KSZ8863 so it is necessary
> to change some registers when using KSZ8463.
>
> Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
...
> diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
...
> @@ -2980,10 +2981,14 @@ static int ksz_setup(struct dsa_switch *ds)
> }
>
> /* set broadcast storm protection 10% rate */
> + storm_mask = BROADCAST_STORM_RATE;
> + storm_rate = (BROADCAST_STORM_VALUE * BROADCAST_STORM_PROT_RATE) / 100;
> + if (ksz_is_ksz8463(dev)) {
> + storm_mask = swab16(storm_mask);
> + storm_rate = swab16(storm_rate);
> + }
I'm sorry to be difficult, but I think the topic of using
swab16(), which I raised in reviewing the previous version of this
patchset, is still open.
https://lore.kernel.org/netdev/20250723162158.GJ1036606@horms.kernel.org/
...
next prev parent reply other threads:[~2025-07-23 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 2:26 [PATCH net-next v5 0/6] net: dsa: microchip: Add KSZ8463 switch support Tristram.Ha
2025-07-23 2:26 ` [PATCH net-next v5 1/6] dt-bindings: " Tristram.Ha
2025-07-23 2:26 ` [PATCH net-next v5 2/6] net: dsa: microchip: Add KSZ8463 switch support to KSZ DSA driver Tristram.Ha
2025-07-23 17:09 ` Andrew Lunn
2025-07-23 17:16 ` Andrew Lunn
2025-07-23 2:26 ` [PATCH net-next v5 3/6] net: dsa: microchip: Use different registers for KSZ8463 Tristram.Ha
2025-07-23 16:26 ` Simon Horman [this message]
2025-07-23 2:26 ` [PATCH net-next v5 4/6] net: dsa: microchip: Write switch MAC address differently " Tristram.Ha
2025-07-23 2:26 ` [PATCH net-next v5 5/6] net: dsa: microchip: Setup fiber ports " Tristram.Ha
2025-07-23 2:26 ` [PATCH net-next v5 6/6] net: dsa: microchip: Disable PTP function of KSZ8463 Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723162647.GK1036606@horms.kernel.org \
--to=horms@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).