[PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Sanjay Suthar]

Fix minor grammatical issues by removing duplicated "is" in two devicetree
binding documents:

- net/amlogic,meson-dwmac.yaml
- iio/dac/ti,dac7612.yaml

Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>
---
Changes since V2:
- Corrected the subject line
- link to v2 : https://lore.kernel.org/linux-iio/20250720182627.39384-1-sanjaysuthar661996@gmail.com/T/#u

 Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml      | 2 +-
 Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml
index 20dd1370660d..624c640be4c8 100644
--- a/Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml
@@ -9,7 +9,7 @@ title: Texas Instruments DAC7612 family of DACs
 description:
   The DAC7612 is a dual, 12-bit digital-to-analog converter (DAC) with
   guaranteed 12-bit monotonicity performance over the industrial temperature
-  range. Is is programmable through an SPI interface.
+  range. It is programmable through an SPI interface.
 
 maintainers:
   - Ricardo Ribalda Delgado <ricardo@ribalda.com>
diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
index 0cd78d71768c..5c91716d1f21 100644
--- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
@@ -149,7 +149,7 @@ properties:
       - description:
           The first register range should be the one of the DWMAC controller
       - description:
-          The second range is is for the Amlogic specific configuration
+          The second range is for the Amlogic specific configuration
           (for example the PRG_ETHERNET register range on Meson8b and newer)
 
   interrupts:
-- 
2.34.1

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Martin Blumenstingl]

On Tue, Jul 22, 2025 at 7:06 PM Sanjay Suthar
<sanjaysuthar661996@gmail.com> wrote:
>
> Fix minor grammatical issues by removing duplicated "is" in two devicetree
> binding documents:
>
> - net/amlogic,meson-dwmac.yaml
> - iio/dac/ti,dac7612.yaml
>
> Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Thank you for spotting and fixing this!

To my knowledge nobody else is currently working on amlogic,meson-dwmac changes.
Meaning: with an ACK from the netdev or iio maintainers this patch can
go through any tree (iio, netdev, devicetree).


Best regards,
Martin

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Sanjay Suthar]

On 23/07/25 01:08, Martin Blumenstingl wrote:

> On Tue, Jul 22, 2025 at 7:06 PM Sanjay Suthar
> <sanjaysuthar661996@gmail.com> wrote:
>> Fix minor grammatical issues by removing duplicated "is" in two devicetree
>> binding documents:
>>
>> - net/amlogic,meson-dwmac.yaml
>> - iio/dac/ti,dac7612.yaml
>>
>> Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> Thank you for spotting and fixing this!
>
> To my knowledge nobody else is currently working on amlogic,meson-dwmac changes.
> Meaning: with an ACK from the netdev or iio maintainers this patch can
> go through any tree (iio, netdev, devicetree).
>
>
> Best regards,
> Martin

Thanks for reviewing the patch. So you mentioned, now the patch can go 
through any of above mentioned tree, Is there any Action item left on my 
end related to this patch? Also will I be notified about when the patch 
will be approved and merged by the respective owner?

Best regards,

Sanjay Suthar

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Martin Blumenstingl]

On Wed, Jul 23, 2025 at 6:30 PM Sanjay Suthar
<sanjaysuthar661996@gmail.com> wrote:
>
> On 23/07/25 01:08, Martin Blumenstingl wrote:
>
> > On Tue, Jul 22, 2025 at 7:06 PM Sanjay Suthar
> > <sanjaysuthar661996@gmail.com> wrote:
> >> Fix minor grammatical issues by removing duplicated "is" in two devicetree
> >> binding documents:
> >>
> >> - net/amlogic,meson-dwmac.yaml
> >> - iio/dac/ti,dac7612.yaml
> >>
> >> Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>
> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> >
> > Thank you for spotting and fixing this!
> >
> > To my knowledge nobody else is currently working on amlogic,meson-dwmac changes.
> > Meaning: with an ACK from the netdev or iio maintainers this patch can
> > go through any tree (iio, netdev, devicetree).
> >
> >
> > Best regards,
> > Martin
>
> Thanks for reviewing the patch. So you mentioned, now the patch can go
> through any of above mentioned tree, Is there any Action item left on my
> end related to this patch? Also will I be notified about when the patch
> will be approved and merged by the respective owner?
Apart from waiting a few days there's nothing to be done on your end.
Both the netdev and iio maintainers are fairly quick to review
patches, but they have to review a large volume. So give them some
time.

A little bit of background in case it helps understand things better.
In my opinion this patch can go through three trees, since these areas
are involved (in no particular order):
- netdev
- iio
- devicetree

If one maintainer takes a patch that somehow touches another
maintainer's area what typically happens is that the maintainers give
their Acked-by and agree on the tree through which the patch will land
in mainline (= Linux Torvalds' tree).
When the patch is picked up there's typically a mail, informing you
about the tree that it has been applied to.

In case you don't hear anything after a few days (my rule of thumb is
a week, during the merge window it can take longer though - but we're
not there yet) then please send a short gentle reminder that you're
still waiting for a reply.


Best regards,
Martin

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Krzysztof Kozlowski]

On Tue, Jul 22, 2025 at 10:35:13PM +0530, Sanjay Suthar wrote:
> Fix minor grammatical issues by removing duplicated "is" in two devicetree
> binding documents:
> 
> - net/amlogic,meson-dwmac.yaml
> - iio/dac/ti,dac7612.yaml
> 
> Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>
> ---
> Changes since V2:
> - Corrected the subject line
> - link to v2 : https://lore.kernel.org/linux-iio/20250720182627.39384-1-sanjaysuthar661996@gmail.com/T/#u

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Sanjay Suthar]

On 23/07/25 13:12, Krzysztof Kozlowski wrote:

>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Best regards,
>> Krzysztof

Thanks for the review and suggestion throughout the patch review 
process. Let me know if any action item needed from my end related to 
this patch. Best Regards, Sanjay Suthar

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Jakub Kicinski]

On Tue, 22 Jul 2025 22:35:13 +0530 Sanjay Suthar wrote:
> - net/amlogic,meson-dwmac.yaml

Acked-by: Jakub Kicinski <kuba@kernel.org>

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Jonathan Cameron]

On Tue, 22 Jul 2025 22:35:13 +0530
Sanjay Suthar <sanjaysuthar661996@gmail.com> wrote:

> Fix minor grammatical issues by removing duplicated "is" in two devicetree
> binding documents:
> 
> - net/amlogic,meson-dwmac.yaml
> - iio/dac/ti,dac7612.yaml
> 
> Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>

I'd have no problem with the argument that this can go through either
tree if there was any interaction between the files or the changes, but
here there isn't. This is just causing potential mess if either tree ends
up with other changes overlapping this for no benefit.  Please split into
two patches, one for each subsystem.  You should be fine to keep the
various tags given here for the new patches.

Jonathan


> ---
> Changes since V2:
> - Corrected the subject line
> - link to v2 : https://lore.kernel.org/linux-iio/20250720182627.39384-1-sanjaysuthar661996@gmail.com/T/#u
> 
>  Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml      | 2 +-
>  Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml
> index 20dd1370660d..624c640be4c8 100644
> --- a/Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.yaml
> @@ -9,7 +9,7 @@ title: Texas Instruments DAC7612 family of DACs
>  description:
>    The DAC7612 is a dual, 12-bit digital-to-analog converter (DAC) with
>    guaranteed 12-bit monotonicity performance over the industrial temperature
> -  range. Is is programmable through an SPI interface.
> +  range. It is programmable through an SPI interface.
>  
>  maintainers:
>    - Ricardo Ribalda Delgado <ricardo@ribalda.com>
> diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> index 0cd78d71768c..5c91716d1f21 100644
> --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml
> @@ -149,7 +149,7 @@ properties:
>        - description:
>            The first register range should be the one of the DWMAC controller
>        - description:
> -          The second range is is for the Amlogic specific configuration
> +          The second range is for the Amlogic specific configuration
>            (for example the PRG_ETHERNET register range on Meson8b and newer)
>  
>    interrupts:

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Sanjay Suthar]

On 24/07/25 15:42, Jonathan Cameron wrote:
> On Tue, 22 Jul 2025 22:35:13 +0530
> Sanjay Suthar <sanjaysuthar661996@gmail.com> wrote:
>
>> Fix minor grammatical issues by removing duplicated "is" in two devicetree
>> binding documents:
>>
>> - net/amlogic,meson-dwmac.yaml
>> - iio/dac/ti,dac7612.yaml
>>
>> Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>
> I'd have no problem with the argument that this can go through either
> tree if there was any interaction between the files or the changes, but
> here there isn't. This is just causing potential mess if either tree ends
> up with other changes overlapping this for no benefit.  Please split into
> two patches, one for each subsystem.  You should be fine to keep the
> various tags given here for the new patches.

Thanks for the review. I understand your concern regarding splitting the 
changes. My intention was that, since the fix is a trivial and identical 
grammatical correction across both subsystems, it didn’t seem necessary 
to separate them.

However, I’m open to either approach — keeping it as a single patch or 
splitting it if that's preferred. As I’m still new to this process, I’ll 
defer to @krzysztof and the DT maintainers for the final call on how 
this should be handled.

Please let me know the preferred direction, and I’ll be happy to update 
accordingly.

Best regards,

Sanjay Suthar

Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs

[Jonathan Cameron]

On Thu, 24 Jul 2025 22:38:14 +0530
Sanjay Suthar <sanjaysuthar661996@gmail.com> wrote:

> On 24/07/25 15:42, Jonathan Cameron wrote:
> > On Tue, 22 Jul 2025 22:35:13 +0530
> > Sanjay Suthar <sanjaysuthar661996@gmail.com> wrote:
> >  
> >> Fix minor grammatical issues by removing duplicated "is" in two devicetree
> >> binding documents:
> >>
> >> - net/amlogic,meson-dwmac.yaml
> >> - iio/dac/ti,dac7612.yaml
> >>
> >> Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>  
> > I'd have no problem with the argument that this can go through either
> > tree if there was any interaction between the files or the changes, but
> > here there isn't. This is just causing potential mess if either tree ends
> > up with other changes overlapping this for no benefit.  Please split into
> > two patches, one for each subsystem.  You should be fine to keep the
> > various tags given here for the new patches.  
> 
> Thanks for the review. I understand your concern regarding splitting the 
> changes. My intention was that, since the fix is a trivial and identical 
> grammatical correction across both subsystems, it didn’t seem necessary 
> to separate them.
> 
> However, I’m open to either approach — keeping it as a single patch or 
> splitting it if that's preferred. As I’m still new to this process, I’ll 
> defer to @krzysztof and the DT maintainers for the final call on how 
> this should be handled.
> 
> Please let me know the preferred direction, and I’ll be happy to update 
> accordingly.

DT bindings ultimately go through the subsystem trees (in vast majority of
cases) to avoid churn issues and keep them aligned with driver changes.
So split it.

Thanks

Jonathan

> 
> Best regards,
> 
> Sanjay Suthar
>