[PATCH] Net: ipv4: fixed a coding style issue

[PATCH] Net: ipv4: fixed a coding style issue

[Ali Ghaffarian]

Fixed a coding style issue.

Signed-off-by: Ali Ghaffarian <alighaffarian9@gmail.com>
---
 net/ipv4/af_inet.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 76e38092c..e38a977c9 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -445,9 +445,8 @@ int inet_bind_sk(struct sock *sk, struct sockaddr *uaddr, int addr_len)
 	int err;
 
 	/* If the socket has its own bind function then use it. (RAW) */
-	if (sk->sk_prot->bind) {
+	if (sk->sk_prot->bind)
 		return sk->sk_prot->bind(sk, uaddr, addr_len);
-	}
 	if (addr_len < sizeof(struct sockaddr_in))
 		return -EINVAL;
 
-- 
2.50.1

Re: [PATCH] Net: ipv4: fixed a coding style issue

[Simon Horman]

On Wed, Jul 23, 2025 at 12:17:36PM +0330, Ali Ghaffarian wrote:
> Fixed a coding style issue.
> 
> Signed-off-by: Ali Ghaffarian <alighaffarian9@gmail.com>

Hi Ali,

Unfortunately we don't accept clean-up patches of this nature
for Networking code unless they are part of a broader set of changes.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~

  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:

  * Addressing ``checkpatch.pl`` warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)

  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.

  Conversely, spelling and grammar fixes are not discouraged.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
--
pw-bot: cr