From: Borislav Petkov <bp@alien8.de>
To: Breno Leitao <leitao@debian.org>
Cc: kernel test robot <lkp@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
Robert Moore <robert.moore@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Hanjun Guo <guohanjun@huawei.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
oe-kbuild-all@lists.linux.dev, linux-media@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linux.dev, osandov@osandov.com,
xueshuai@linux.alibaba.com, konrad.wilk@oracle.com,
linux-edac@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-pci@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH v3] vmcoreinfo: Track and log recoverable hardware errors
Date: Wed, 23 Jul 2025 21:00:48 +0200 [thread overview]
Message-ID: <20250723190048.GBaIExYJYiHWnSBFye@renoirsky.local> (raw)
In-Reply-To: <cdlrppnrheyq7z3gmwmwsmktpmoiwq7g5hxa67rcx4iem5i6ge@jksa5o5use4w>
On Wed, Jul 23, 2025 at 08:36:52AM -0700, Breno Leitao wrote:
> Basically there are two approaches, from what I understand:
>
> 1) mark do_machine_check() as noinstr
do_machine_check is already noinstr. I think you mean mark
hwerr_log_error_type() noinstr.
And yes, you can mark it. hwerr_log_error_type() is not that fascinating
to allow instrumentation for it.
> 2) Move hwerr_log_error_type() earlier inside the
> instrumentation_begin() area.
Or you can do that - that looks like less of an effort btw.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2025-07-23 18:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 16:56 [PATCH v3] vmcoreinfo: Track and log recoverable hardware errors Breno Leitao
2025-07-23 14:28 ` kernel test robot
2025-07-23 15:36 ` Breno Leitao
2025-07-23 19:00 ` Borislav Petkov [this message]
2025-07-23 23:21 ` Huang, Kai
2025-07-24 8:00 ` Shuai Xue
2025-07-24 13:34 ` Breno Leitao
2025-07-25 7:40 ` Shuai Xue
2025-07-25 16:16 ` Breno Leitao
2025-07-28 1:08 ` Shuai Xue
2025-07-29 13:48 ` Breno Leitao
2025-07-30 2:13 ` Shuai Xue
2025-07-30 13:11 ` Breno Leitao
2025-07-30 13:50 ` Shuai Xue
2025-07-30 17:16 ` Breno Leitao
2025-07-30 16:21 ` Mauro Carvalho Chehab
2025-07-30 17:22 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723190048.GBaIExYJYiHWnSBFye@renoirsky.local \
--to=bp@alien8.de \
--cc=acpica-devel@lists.linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=kernel-team@meta.com \
--cc=konrad.wilk@oracle.com \
--cc=leitao@debian.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=mahesh@linux.ibm.com \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oohall@gmail.com \
--cc=osandov@osandov.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).