From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A51C42E92C1 for ; Fri, 25 Jul 2025 10:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753438120; cv=none; b=CxKV6SL1ADu9i/Fo9qCxnmd1yJyC8IQ50HC0Rz2ErT2F5pyY2V5vmQ7Ndx/GhVG5kGV4FtUO7Q8YQVrzU1ow5Ikt/UHbBQWbnFMuHN/k6L4fVwRGTY9PEUyLWOjBIxFvpozlQEljhW/v0NrSofZBxe3hC7us8je90glxd18+Ekk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753438120; c=relaxed/simple; bh=ab+Uam6+qCgeeyzW1mLzRBfg/DFM2tOzmX2HD9EDM74=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oJ88ibIxqOcwShe7117fC/Dry60w0cZrCRQZg1+DCOVekpDsqkc64jPmC+PgS3gHb6CQ/sEdoqHKeXpu8XZOU/5kORQNwpg685eMP+S8tPl8ZHy+M8x9r1geFBLHHNQE6G6dQ3uXSbl09KT08l+y50911N5GmIzQ2MufLRMqHiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bBzw9wCZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bBzw9wCZ" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56P8iwcm025981 for ; Fri, 25 Jul 2025 10:08:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Jk8rhw+3ezl HXU/LdBbPr3lAiametlPEc9i/J7FBJU8=; b=bBzw9wCZ5NqJoAECm4nP3vriVoh FhHVfkiVdp59Bve/WNVOQmffD86zONT7Ce7u2k+aiBhxYjRYwnT3pgTpPIGzEYRN t9GJ0TcOxyp7T1VXHpOKrRZLJ0IoFBAcCy4tQLIfqgBt5wTR+lWH1mhmDGO11vaz 2i7f4kbeccqykw7XWA+903UQ6eWyYmHwVWWlMWgE9PjMNwUryCJvpX6lVTIhMfuJ BvX4F3Y7G7hYWPO+Qd3+zF/xjOzROcilHxK1xtAw4qrkQ/EySJVCVXcJ3yUaApZl YzEFAkJFLsTPVX+IJ21wkOmVA6DYCaYG5Kd1uLSs686CYJrOskd29TVnwIg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 483w2u1nyx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Jul 2025 10:08:37 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b1ffc678adfso1411537a12.0 for ; Fri, 25 Jul 2025 03:08:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753438116; x=1754042916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jk8rhw+3ezlHXU/LdBbPr3lAiametlPEc9i/J7FBJU8=; b=rNb4w22oJv4CI3AnAevgQIRYNmxPPIwrCdwPEOCjPVQezRb7pjRW7y/Q/MpBKlW3Ft NCT/UPG+qIsuVHGWy04/+XkoON7LUvwRcoXrb+bz1vSi5mS1iH5nJsHZpSmCtiUvNIYh WRTZS5Kp6zn/l6TKT7CNLoYV+6dmWBGQi/Pj3ZTM+tILv6FFmaChFMvPYWahf3SgZL5q ogHbD+f14jcpLM9tOkZ2+aHPDKs4jiAKOvBfRb17MJekED4MIFvfEqIurVKdlqARZuBY ZyaE50JOnqbWf9wgiO9fXj57zPp6zeTtphIySEKMZ7N37CZlPXYLEBuX61ZJJ9OwN9X7 V4Rw== X-Forwarded-Encrypted: i=1; AJvYcCXFu4gFMo9+UoaLXjwikP8NN2IFDjiqwDg2KgOJbrRIsCniGcHWQ/K0EKNAC/+yq4QAwV7xZpJF/sWhKCU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLmMGjx38MOXpxnhIpO1LeyzRIwJvNYOcx5xYwnyymJe/m6Ew4 G51mh80b9R+YdOyaOhYgtqHwSnaeuUZYQ+ciUtu7JJbN4MUsWqH2e1jiigypycMpJ9kQHc5rtB8 lRH6Vwe5hLFCthzaEGo8AnE9V0GCPW+zYFcVE5IOqh9tXlzcg6HodFU6d7HF8i+EHEX0zfrFxw9 u5XA== X-Gm-Gg: ASbGnct18YsrxNTgR+9xhkLmKOScqmkeq4a9x9Qo7fp/uzGEfWewg9pFOsKtPEs++9A ITkbZIW6rv0JLHesn6gWC7i6OhRFciTfGhO5BhkXahknUvVoJKPegGhMevi08dY+7aOfaXlvmvN 1y3UXLYR+PhqLLB+zrEsQ6snieHUbnhQJXt6R6AOlRojAm3nACEFa++cSmMrWFB0jZ/su2bId5c s2cuzVUKEb9HqyG+f/9Vo7uxmxfNOqJWouZ3VeNICcOd9i/r0lh4KuyygRLcV/qfYMQE5cibD/u kWeGkoShWlQLziXPUobCQlHu79GbndyFfQwNY0HsJGpDZnNlzzcP8BH5moCXLqa6mJGESm32jvz 2qB/P+2xfybgqaGZYI4s= X-Received: by 2002:a17:903:181:b0:234:d679:72e3 with SMTP id d9443c01a7336-23fb3100766mr20201465ad.42.1753438116154; Fri, 25 Jul 2025 03:08:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGs0H0KGXgka7RDhfyUl5zCfbbvzjg0Kqg2pI0R60Jp3ieS0GcT2u8RGVpplg5Z8ydKHN+mw== X-Received: by 2002:a17:903:181:b0:234:d679:72e3 with SMTP id d9443c01a7336-23fb3100766mr20200975ad.42.1753438115670; Fri, 25 Jul 2025 03:08:35 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23fa48fd29dsm33641435ad.176.2025.07.25.03.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 03:08:35 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Alexander Shishkin , Tingwei Zhang , Jinlong Mao Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan Subject: [PATCH v4 05/10] coresight: tmc: Introduce tmc_read_ops to wrap read operations Date: Fri, 25 Jul 2025 18:08:01 +0800 Message-Id: <20250725100806.1157-6-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250725100806.1157-1-jie.gan@oss.qualcomm.com> References: <20250725100806.1157-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI1MDA4NSBTYWx0ZWRfXyv2HBS9ihMcv zFRyf2aV34LF5gB+YuOripNFfjSkRtnM+L0R1FfuP1o/KjejYxowDfcz9JW8AMrEZ8msiyPf+ru zCID/Oy3jDO5az7JmHg2qf38g1LC0r68L++No4wvVPTyOi1/XlzAs1FeXtL6HW3uEjRX/v6O5bT e6KYf8RGBQG3l42daPUb0FvWFOuaUuhB6NrndzQiu+9z5wOzdmS+AzHWKAjbRQb764qT/bgDKNs gHTFAOcua1IPhFAZyw67fwO5OJAuFF5dGpPRM5rUaercKdJEOKVqkLA9rXV/efrUrt46SWzAJ3l EnrWCmhJJwBxtNP70vYNWEitTz2szMDV/q5hUyKY8RIODsB1snOur7N2v9YwXE5wqO+xVTp0oRA hlGJeT3b5eWJxMxaBq/VUtfxBqaDqWWRINpQ6hQpl0KNDD+vyEUnCD4+mnK+xqcu5HLl4tBw X-Proofpoint-ORIG-GUID: eLTObfGHH3GJGdwEnlplSAcTCdUzp33d X-Authority-Analysis: v=2.4 cv=FcA3xI+6 c=1 sm=1 tr=0 ts=688357a5 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=1hiE41pZ4Zj50arX-_gA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: eLTObfGHH3GJGdwEnlplSAcTCdUzp33d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-25_02,2025-07-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 clxscore=1015 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507250085 Introduce tmc_read_ops as a wrapper, wrap read operations, for reading trace data from the TMC buffer. Signed-off-by: Jie Gan --- .../hwtracing/coresight/coresight-tmc-core.c | 50 +++++++++---------- drivers/hwtracing/coresight/coresight-tmc.h | 17 +++++++ 2 files changed, 40 insertions(+), 27 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c index 4d249af93097..f668047c5df4 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -232,17 +232,10 @@ static int tmc_read_prepare(struct tmc_drvdata *drvdata) { int ret = 0; - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret = tmc_read_prepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret = tmc_read_prepare_etr(drvdata); - break; - default: + if (drvdata->read_ops) + ret = drvdata->read_ops->read_prepare(drvdata); + else ret = -EINVAL; - } if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read start\n"); @@ -254,17 +247,10 @@ static int tmc_read_unprepare(struct tmc_drvdata *drvdata) { int ret = 0; - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret = tmc_read_unprepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret = tmc_read_unprepare_etr(drvdata); - break; - default: + if (drvdata->read_ops) + ret = drvdata->read_ops->read_unprepare(drvdata); + else ret = -EINVAL; - } if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read end\n"); @@ -291,13 +277,8 @@ static int tmc_open(struct inode *inode, struct file *file) static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos, size_t len, char **bufpp) { - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - return tmc_etb_get_sysfs_trace(drvdata, pos, len, bufpp); - case TMC_CONFIG_TYPE_ETR: - return tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); - } + if (drvdata->read_ops) + return drvdata->read_ops->get_trace_data(drvdata, pos, len, bufpp); return -EINVAL; } @@ -769,6 +750,18 @@ static void register_crash_dev_interface(struct tmc_drvdata *drvdata, "Valid crash tracedata found\n"); } +static const struct tmc_read_ops tmc_etb_read_ops = { + .read_prepare = tmc_read_prepare_etb, + .read_unprepare = tmc_read_unprepare_etb, + .get_trace_data = tmc_etb_get_sysfs_trace, +}; + +static const struct tmc_read_ops tmc_etr_read_ops = { + .read_prepare = tmc_read_prepare_etr, + .read_unprepare = tmc_read_unprepare_etr, + .get_trace_data = tmc_etr_get_sysfs_trace, +}; + static int __tmc_probe(struct device *dev, struct resource *res) { int ret = 0; @@ -818,6 +811,7 @@ static int __tmc_probe(struct device *dev, struct resource *res) desc.subtype.sink_subtype = CORESIGHT_DEV_SUBTYPE_SINK_BUFFER; desc.ops = &tmc_etb_cs_ops; dev_list = &etb_devs; + drvdata->read_ops = &tmc_etb_read_ops; break; case TMC_CONFIG_TYPE_ETR: desc.groups = coresight_etr_groups; @@ -831,6 +825,7 @@ static int __tmc_probe(struct device *dev, struct resource *res) mutex_init(&drvdata->idr_mutex); dev_list = &etr_devs; INIT_LIST_HEAD(&drvdata->etr_buf_list); + drvdata->read_ops = &tmc_etr_read_ops; break; case TMC_CONFIG_TYPE_ETF: desc.groups = coresight_etf_groups; @@ -839,6 +834,7 @@ static int __tmc_probe(struct device *dev, struct resource *res) desc.subtype.link_subtype = CORESIGHT_DEV_SUBTYPE_LINK_FIFO; desc.ops = &tmc_etf_cs_ops; dev_list = &etf_devs; + drvdata->read_ops = &tmc_etb_read_ops; break; default: pr_err("%s: Unsupported TMC config\n", desc.name); diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h index 3cb8ba9f88f5..2ad8e288c94b 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -223,6 +223,8 @@ struct etr_buf_node { struct list_head node; }; +struct tmc_read_ops; + /** * struct tmc_drvdata - specifics associated to an TMC component * @pclk: APB clock if present, otherwise NULL @@ -259,6 +261,7 @@ struct etr_buf_node { * Used by ETR/ETF. * @etr_buf_list: List that is used to manage allocated etr_buf. * @reading_node: Available buffer for byte-cntr reading. + * @tmc_read_ops: Read operations for TMC device. */ struct tmc_drvdata { struct clk *pclk; @@ -290,6 +293,20 @@ struct tmc_drvdata { struct tmc_resrv_buf crash_mdata; struct list_head etr_buf_list; struct etr_buf_node *reading_node; + const struct tmc_read_ops *read_ops; +}; + +/** + * struct tmc_read_ops - read operations for TMC and its helper devices + * @read_prepare: prepare operation. + * @read_unprepare: unprepare operation. + * @get_trace_data: read operation. + */ +struct tmc_read_ops { + int (*read_prepare)(struct tmc_drvdata *drvdata); + int (*read_unprepare)(struct tmc_drvdata *drvdata); + ssize_t (*get_trace_data)(struct tmc_drvdata *drvdata, loff_t pos, + size_t len, char **bufpp); }; struct etr_buf_operations { -- 2.34.1