From: Greg KH <gregkh@linuxfoundation.org>
To: Olivier Tuchon <tcn@google.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: Add gadgetmon traffic monitor
Date: Fri, 25 Jul 2025 17:33:23 +0200 [thread overview]
Message-ID: <2025072527-entrust-childless-3ae9@gregkh> (raw)
In-Reply-To: <CALU+5Va_zeqS5YK7v3HNvDKkg8srqc87P5ZaQUK5tGFUMyNrkg@mail.gmail.com>
Cool, but:
On Fri, Jul 25, 2025 at 05:25:49PM +0200, Olivier Tuchon wrote:
> Signed-off-by: Oliv <tcn@google.com>
Doesn't match the From: line :(
> +config GADGETMON_BUFFER_SIZE_MB
> + int "Buffer size for gadget monitor (in MiB)"
> + depends on USB_GADGET_MON
> + default 4
> + help
> + Sets the size of the ring buffer used to transfer event data
> + from the kernel to userspace. A larger buffer reduces the risk
> + of dropping events during high-speed traffic bursts but uses
> + more kernel memory. Value is in Megabytes (MiB).
<snip>
Patch is totally corrupted with whitespace issues everywhere, making it
impossible to apply or even review :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-25 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 15:25 [PATCH] usb: gadget: Add gadgetmon traffic monitor Olivier Tuchon
2025-07-25 15:33 ` Greg KH [this message]
2025-07-25 20:51 ` Olivier Tuchon
2025-07-25 15:46 ` Alan Stern
2025-07-25 20:45 ` Olivier Tuchon
2025-07-26 2:10 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072527-entrust-childless-3ae9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tcn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).