Re: [PATCH 1/4] agents: add unified agent coding assistant configuration

Sasha Levin
2025-07-28T04:43:55Z

On Sun, Jul 27, 2025 at 07:37:31PM -0700, Kees Cook wrote:
>On Sun, Jul 27, 2025 at 03:57:59PM -0400, Sasha Levin wrote:
>> Create a single source of truth for agent instructions in
>> Documentation/AI/main.md with symlinks for all major coding
>> agents:
>> - CLAUDE.md (Claude Code)
>> - .github/copilot-instructions.md (GitHub Copilot)
>> - .cursorrules (Cursor)
>> - .codeium/instructions.md (Codeium)
>> - .continue/context.md (Continue)
>> - .windsurfrules (Windsurf)
>> - .aider.conf.yml (Aider)
>
>I *really* don't like this. I use the CLAUDE.md file as my instructions
>for my agent. I think all of these should be .gitignore entries.

Sorry, I might have misunderstood you: how does it play out if we add
these to .gitignore?

The tool will just end replacing whatever we put in there with something
customized that doesn't necessarily correspond to what the community
will consider a "standard" set of rules for agents?

>> diff --git a/Documentation/agents/index.rst b/Documentation/agents/index.rst
>> new file mode 100644
>> index 000000000000..109266ca91ec
>> --- /dev/null
>> +++ b/Documentation/agents/index.rst
>> @@ -0,0 +1,10 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +======
>> +Agents
>> +======
>> +
>> +.. toctree::
>> + :maxdepth: 1
>> +
>> + main
>> \ No newline at end of file
>> diff --git a/Documentation/agents/main.rst b/Documentation/agents/main.rst
>> new file mode 100644
>> index 000000000000..98aa8250be9d
>> --- /dev/null
>> +++ b/Documentation/agents/main.rst
>> @@ -0,0 +1,7 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +=====================================
>> +Linux Kernel Development Agent Instructions
>> +=====================================
>> +
>> +This is the Linux kernel repository. When working with this codebase, you must follow the Linux kernel development processes and coding standards.
>
>And now I start my "this is redundant, why do we have to repeat it in a
>new place?" part of my review comments. :)
>
>I *really* think Agent instructions should only be about stuff specific
>to the agent. It is _supposed_ to be able to find the rest of it on its
>own.

Right - I trimmed down most of these specific callouts, but I left a few
that I found necessary since in my testing the agent would sometime
forget about those. I'll comment more on the rest of your review.

--
Thanks,
Sasha