From: Sukrut Heroorkar <hsukrut3@gmail.com>
To: sean@poorly.run, "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Victor Skvortsov" <Victor.Skvortsov@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Lijo Lazar" <lijo.lazar@amd.com>,
"Srinivasan Shanmugam" <srinivasan.shanmugam@amd.com>,
"Jack Xiao" <Jack.Xiao@amd.com>, "Tony Yi" <Tony.Yi@amd.com>,
"Mirsad Todorovac" <mtodorovac69@gmail.com>,
"Sukrut Heroorkar" <hsukrut3@gmail.com>,
"Shaoyun Liu" <shaoyun.liu@amd.com>,
amd-gfx@lists.freedesktop.org (open list:RADEON and AMDGPU DRM
DRIVERS), dri-devel@lists.freedesktop.org (open list:DRM DRIVERS),
linux-kernel@vger.kernel.org (open list)
Cc: skhan@linuxfoundation.org, david.hunter.linux@gmail.com
Subject: [RFC PATCH] Replace dev_err with drm_err
Date: Mon, 28 Jul 2025 16:58:28 +0200 [thread overview]
Message-ID: <20250728145841.378172-1-hsukrut3@gmail.com> (raw)
Hello,
This patch converts dev_err logging to drm_err, as recommended
in gpu/todo.rst for drivers supporting multiple DRM instances.
Before proceeding further, I'd like to confirm if this is the
right direction for amdgpu.
The below change builds successfully. I am happy to send this
as a formal patch if it's acceptable.
Thank you.
Signed-off-by: Sukrut Heroorkar <hsukrut3@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 13f0cdeb59c4..effffba39b5a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -460,7 +460,7 @@ static int amdgpu_virt_read_pf2vf_data(struct amdgpu_device *adev)
return -EINVAL;
if (pf2vf_info->size > 1024) {
- dev_err(adev->dev, "invalid pf2vf message size: 0x%x\n", pf2vf_info->size);
+ drm_err(adev_to_drm(adev), "invalid pf2vf message size: 0x%x\n", pf2vf_info->size);
return -EINVAL;
}
@@ -471,7 +471,7 @@ static int amdgpu_virt_read_pf2vf_data(struct amdgpu_device *adev)
adev->virt.fw_reserve.p_pf2vf, pf2vf_info->size,
adev->virt.fw_reserve.checksum_key, checksum);
if (checksum != checkval) {
- dev_err(adev->dev,
+ drm_err(adev_to_drm(adev),
"invalid pf2vf message: header checksum=0x%x calculated checksum=0x%x\n",
checksum, checkval);
return -EINVAL;
--
2.43.0
reply other threads:[~2025-07-28 15:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728145841.378172-1-hsukrut3@gmail.com \
--to=hsukrut3@gmail.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Xiao@amd.com \
--cc=Tony.Yi@amd.com \
--cc=Victor.Skvortsov@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=david.hunter.linux@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtodorovac69@gmail.com \
--cc=sean@poorly.run \
--cc=shaoyun.liu@amd.com \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=srinivasan.shanmugam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox