From: Jakub Kicinski <kuba@kernel.org>
To: "Bence Csókás" <csokas.bence@prolan.hu>, "Andrew Lunn" <andrew@lunn.ch>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Csaba Buday <buday.csaba@prolan.hu>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: mdio_bus: Use devm for getting reset GPIO
Date: Wed, 30 Jul 2025 18:16:45 -0700 [thread overview]
Message-ID: <20250730181645.6d818d6a@kernel.org> (raw)
In-Reply-To: <20250728153455.47190-2-csokas.bence@prolan.hu>
On Mon, 28 Jul 2025 17:34:55 +0200 Bence Csókás wrote:
> Commit bafbdd527d56 ("phylib: Add device reset GPIO support") removed
> devm_gpiod_get_optional() in favor of the non-devres managed
> fwnode_get_named_gpiod(). When it was kind-of reverted by commit
> 40ba6a12a548 ("net: mdio: switch to using gpiod_get_optional()"), the devm
> functionality was not reinstated. Nor was the GPIO unclaimed on device
> remove. This leads to the GPIO being claimed indefinitely, even when the
> device and/or the driver gets removed.
>
> Fixes: bafbdd527d56 ("phylib: Add device reset GPIO support")
> Fixes: 40ba6a12a548 ("net: mdio: switch to using gpiod_get_optional()")
> Cc: Csaba Buday <buday.csaba@prolan.hu>
> Signed-off-by: Bence Csókás <csokas.bence@prolan.hu>
Looks like this is a v2 / rewrite of
https://lore.kernel.org/all/20250709133222.48802-3-buday.csaba@prolan.hu/
? Please try to include more of a change log / history of the changes
(under the --- marker)
Andrew, you acked what I'm guessing was the v1, still looks good?
next prev parent reply other threads:[~2025-07-31 1:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 15:34 [PATCH net] net: mdio_bus: Use devm for getting reset GPIO Bence Csókás
2025-07-31 1:16 ` Jakub Kicinski [this message]
2025-07-31 1:20 ` Andrew Lunn
2025-08-07 8:12 ` Csókás Bence
2025-07-31 2:20 ` patchwork-bot+netdevbpf
2025-08-01 12:34 ` Russell King (Oracle)
2025-08-01 12:01 ` Mark Brown
2025-08-01 12:25 ` Geert Uytterhoeven
2025-08-01 12:33 ` Russell King (Oracle)
2025-08-01 13:04 ` Csókás Bence
2025-08-01 13:15 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730181645.6d818d6a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=buday.csaba@prolan.hu \
--cc=csokas.bence@prolan.hu \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).