From: Petr Tesarik <ptesarik@suse.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)),
linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT
AND 64-BIT)), Petr Tesarik <ptesarik@suse.com>
Subject: [PATCH] x86/tsx: Get the tsx= command line parameter with core_param()
Date: Thu, 31 Jul 2025 10:34:33 +0200 [thread overview]
Message-ID: <20250731083433.3173437-1-ptesarik@suse.com> (raw)
Use core_param() to get the value of the tsx= command line parameter.
Although cmdline_find_option() works fine, the option is reported as
unknown and passed to user space. The latter is not a real issue, but
the former is confusing and makes people wonder if the tsx= parameter
had any effect and double-check for typos unnecessarily.
Signed-off-by: Petr Tesarik <ptesarik@suse.com>
---
arch/x86/kernel/cpu/tsx.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/cpu/tsx.c b/arch/x86/kernel/cpu/tsx.c
index 49782724a943..03e1f28cf9ec 100644
--- a/arch/x86/kernel/cpu/tsx.c
+++ b/arch/x86/kernel/cpu/tsx.c
@@ -156,11 +156,11 @@ static void tsx_dev_mode_disable(void)
}
}
+static char *tsx_cmdline_param __initdata;
+core_param(tsx, tsx_cmdline_param, charp, 0);
+
void __init tsx_init(void)
{
- char arg[5] = {};
- int ret;
-
tsx_dev_mode_disable();
/*
@@ -194,13 +194,12 @@ void __init tsx_init(void)
return;
}
- ret = cmdline_find_option(boot_command_line, "tsx", arg, sizeof(arg));
- if (ret >= 0) {
- if (!strcmp(arg, "on")) {
+ if (tsx_cmdline_param) {
+ if (!strcmp(tsx_cmdline_param, "on")) {
tsx_ctrl_state = TSX_CTRL_ENABLE;
- } else if (!strcmp(arg, "off")) {
+ } else if (!strcmp(tsx_cmdline_param, "off")) {
tsx_ctrl_state = TSX_CTRL_DISABLE;
- } else if (!strcmp(arg, "auto")) {
+ } else if (!strcmp(tsx_cmdline_param, "auto")) {
tsx_ctrl_state = x86_get_tsx_auto_mode();
} else {
tsx_ctrl_state = TSX_CTRL_DISABLE;
--
2.49.0
next reply other threads:[~2025-07-31 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 8:34 Petr Tesarik [this message]
2025-07-31 19:16 ` [PATCH] x86/tsx: Get the tsx= command line parameter with core_param() Pawan Gupta
2025-08-28 11:51 ` Petr Tesarik
2025-09-15 14:39 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731083433.3173437-1-ptesarik@suse.com \
--to=ptesarik@suse.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox