* [PATCH v2] rust: update error.rs documentation
@ 2025-07-30 12:04 Onur Özkan
2025-07-30 13:56 ` Daniel Almeida
0 siblings, 1 reply; 3+ messages in thread
From: Onur Özkan @ 2025-07-30 12:04 UTC (permalink / raw)
To: rust-for-linux
Cc: ojeda, alex.gaynor, boqun.feng, gary, bjorn3_gh, lossin,
a.hindborg, aliceryhl, tmgross, dakr, me, felipe_life,
abdiel.janulgue, dirk.behme, daniel, linux-kernel,
Onur Özkan
Adds missing header links.
Signed-off-by: Onur Özkan <work@onurozkan.dev>
---
rust/kernel/error.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
index 3dee3139fcd4..dd3e4224218d 100644
--- a/rust/kernel/error.rs
+++ b/rust/kernel/error.rs
@@ -2,6 +2,8 @@
//! Kernel errors.
//!
+//! C header: [`arch/mips/include/uapi/asm/errno.h`](srctree/arch/mips/include/uapi/asm/errno.h)
+//! C header: [`include/linux/errno.h`](srctree/include/linux/errno.h)
//! C header: [`include/uapi/asm-generic/errno-base.h`](srctree/include/uapi/asm-generic/errno-base.h)
use crate::{
--
2.50.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] rust: update error.rs documentation
2025-07-30 12:04 [PATCH v2] rust: update error.rs documentation Onur Özkan
@ 2025-07-30 13:56 ` Daniel Almeida
2025-07-31 6:10 ` Onur Özkan
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Almeida @ 2025-07-30 13:56 UTC (permalink / raw)
To: Onur Özkan
Cc: rust-for-linux, ojeda, alex.gaynor, boqun.feng, gary, bjorn3_gh,
lossin, a.hindborg, aliceryhl, tmgross, dakr, me, felipe_life,
abdiel.janulgue, dirk.behme, daniel, linux-kernel
Hi Onur,
> On 30 Jul 2025, at 09:04, Onur Özkan <work@onurozkan.dev> wrote:
>
> Adds missing header links.
>
> Signed-off-by: Onur Özkan <work@onurozkan.dev>
This is a v2 but there is no changelog.
Could you let us know what changed in future iterations, if any?
> ---
> rust/kernel/error.rs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 3dee3139fcd4..dd3e4224218d 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -2,6 +2,8 @@
>
> //! Kernel errors.
> //!
> +//! C header: [`arch/mips/include/uapi/asm/errno.h`](srctree/arch/mips/include/uapi/asm/errno.h)
Why is this mips file being referenced here? :)
> +//! C header: [`include/linux/errno.h`](srctree/include/linux/errno.h)
> //! C header: [`include/uapi/asm-generic/errno-base.h`](srctree/include/uapi/asm-generic/errno-base.h)
>
> use crate::{
> --
> 2.50.0
>
>
— Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] rust: update error.rs documentation
2025-07-30 13:56 ` Daniel Almeida
@ 2025-07-31 6:10 ` Onur Özkan
0 siblings, 0 replies; 3+ messages in thread
From: Onur Özkan @ 2025-07-31 6:10 UTC (permalink / raw)
To: Daniel Almeida
Cc: rust-for-linux, ojeda, alex.gaynor, boqun.feng, gary, bjorn3_gh,
lossin, a.hindborg, aliceryhl, tmgross, dakr, me, felipe_life,
abdiel.janulgue, dirk.behme, daniel, linux-kernel
On Wed, 30 Jul 2025 10:56:35 -0300
Daniel Almeida <daniel.almeida@collabora.com> wrote:
> Hi Onur,
>
> > On 30 Jul 2025, at 09:04, Onur Özkan <work@onurozkan.dev> wrote:
> >
> > Adds missing header links.
> >
> > Signed-off-by: Onur Özkan <work@onurozkan.dev>
>
> This is a v2 but there is no changelog.
>
> Could you let us know what changed in future iterations, if any?
I thought it wasn't necessary for short/simple patches, my bad.
I will make sure to do it for all patches from now on.
> > ---
> > rust/kernel/error.rs | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> > index 3dee3139fcd4..dd3e4224218d 100644
> > --- a/rust/kernel/error.rs
> > +++ b/rust/kernel/error.rs
> > @@ -2,6 +2,8 @@
> >
> > //! Kernel errors.
> > //!
> > +//! C header:
> > [`arch/mips/include/uapi/asm/errno.h`](srctree/arch/mips/include/uapi/asm/errno.h)
>
> Why is this mips file being referenced here? :)
I was looking for where EOVERFLOW is defined, it turns out it's
defined in multiple places (didn't know that yesterday). The one that
bindgen resolves to is from `srctree/include/uapi/asm-generic/errno.h`
header, I will send a v3 with the changelog at the end of the day.
Regards,
Onur
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-31 6:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-30 12:04 [PATCH v2] rust: update error.rs documentation Onur Özkan
2025-07-30 13:56 ` Daniel Almeida
2025-07-31 6:10 ` Onur Özkan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).