* [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round
@ 2025-08-01 11:18 Julien Massot
2025-08-01 11:18 ` [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property Julien Massot
` (9 more replies)
0 siblings, 10 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
This patch series continues the effort to address Device Tree validation warnings for MediaTek platforms, with a focus on MT8183. It follows the initial cleanup series by Angelo (https://www.spinics.net/lists/kernel/msg5780177.html)
The patches in this set eliminate several of the remaining warnings by improving or converting DT bindings to YAML, adding missing properties, and updating device tree files accordingly.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
Julien Massot (9):
dt-bindings: clock: mediatek: Add power-domains property
dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant
arm64: dts: mt8183: Rename nodes to match audiosys binding schema
ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML
dt-bindings: sound: Convert MT8183 DA7219 sound card bindings to YAML
ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names
arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
arm64: dts: mediatek: mt8183-pumkin: Fix pull-down/up-adv values
.../bindings/arm/mediatek/mediatek,audsys.yaml | 17 +-
.../devicetree/bindings/clock/mediatek,syscon.yaml | 3 +
.../bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 2 +
.../devicetree/bindings/sound/mt8183-afe-pcm.txt | 42 ----
.../devicetree/bindings/sound/mt8183-afe-pcm.yaml | 225 +++++++++++++++++++++
.../bindings/sound/mt8183-da7219-max98357.txt | 21 --
.../devicetree/bindings/sound/mt8183-da7219.yaml | 49 +++++
.../sound/mt8183-mt6358-ts3a227-max98357.txt | 25 ---
.../devicetree/bindings/sound/mt8183-mt6358.yaml | 59 ++++++
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 22 +-
arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 22 +-
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 +-
12 files changed, 378 insertions(+), 113 deletions(-)
---
base-commit: b9ddaa95fd283bce7041550ddbbe7e764c477110
change-id: 20250801-mtk-dtb-warnings-157d4fc10f77
Best regards,
--
Julien Massot <julien.massot@collabora.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-01 17:19 ` Rob Herring (Arm)
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant Julien Massot
` (8 subsequent siblings)
9 siblings, 2 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
The mt8183-mfgcfg node uses a power domain in its device tree node.
To prevent schema validation warnings, add the optional `power-domains`
property to the binding schema for mediatek syscon clocks.
Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
Documentation/devicetree/bindings/clock/mediatek,syscon.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
index a86a64893c675ac134af609b3a49242565db6ad8..1011bc46cfcb97b90b86019e95a7e4bc8a819342 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
@@ -76,6 +76,9 @@ properties:
- const: mediatek,mt2701-vdecsys
- const: syscon
+ power-domains:
+ maxItems: 1
+
reg:
maxItems: 1
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
2025-08-01 11:18 ` [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-01 17:21 ` Rob Herring
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 3/9] arm64: dts: mt8183: Rename nodes to match audiosys binding schema Julien Massot
` (7 subsequent siblings)
9 siblings, 2 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
Update the mediatek,audsys binding to support the mt8183-audiosys
compatible, which uses a different audio controller binding
(mt8183-afe-pcm.yaml) compared to the legacy mt2701-audio controller.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
.../bindings/arm/mediatek/mediatek,audsys.yaml | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
index 45d4a6620041b11cf6e943de49a42f3fcd91e1b9..5d9d91f9c5802240ac7d411c5632ae6663d15f29 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
@@ -23,6 +23,7 @@ properties:
- mediatek,mt7622-audsys
- mediatek,mt8167-audsys
- mediatek,mt8173-audsys
+ - mediatek,mt8183-audiosys
- mediatek,mt8183-audsys
- mediatek,mt8186-audsys
- mediatek,mt8192-audsys
@@ -41,7 +42,6 @@ properties:
const: 1
audio-controller:
- $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
type: object
required:
@@ -50,6 +50,21 @@ required:
additionalProperties: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mediatek,mt8183-audiosys
+ then:
+ properties:
+ audio-controller:
+ $ref: /schemas/sound/mt8183-afe-pcm.yaml#
+ else:
+ properties:
+ audio-controller:
+ $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
+
examples:
- |
#include <dt-bindings/interrupt-controller/arm-gic.h>
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 3/9] arm64: dts: mt8183: Rename nodes to match audiosys binding schema
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
2025-08-01 11:18 ` [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property Julien Massot
2025-08-01 11:18 ` [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML Julien Massot
` (6 subsequent siblings)
9 siblings, 1 reply; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
The binding for "mediatek,mt8183-audiosys" expects an audio-controller
node inside the audiosys block. Rename the nested AFE node from
"mt8183-afe-pcm" to "audio-controller" accordingly.
Also rename the audiosys node itself from "audio-controller" to
"clock-controller" to better reflect its function.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 3c1fe80e64b9c5e32703f1e8663942a24543cf23..e2500e3c3f66d12a6fd19f29fa9fd63a6f04821f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1445,11 +1445,11 @@ usb_host: usb@11200000 {
};
};
- audiosys: audio-controller@11220000 {
+ audiosys: clock-controller@11220000 {
compatible = "mediatek,mt8183-audiosys", "syscon";
reg = <0 0x11220000 0 0x1000>;
#clock-cells = <1>;
- afe: mt8183-afe-pcm {
+ afe: audio-controller {
compatible = "mediatek,mt8183-audio";
interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_LOW>;
resets = <&watchdog MT8183_TOPRGU_AUDIO_SW_RST>;
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
` (2 preceding siblings ...)
2025-08-01 11:18 ` [PATCH 3/9] arm64: dts: mt8183: Rename nodes to match audiosys binding schema Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-01 17:26 ` Rob Herring
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings " Julien Massot
` (5 subsequent siblings)
9 siblings, 2 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
Convert the MediaTek MT8183 AFE PCM Device Tree binding from the old
.txt format to YAML schema format to improve validation.
While converting, also document all clock inputs used by the AFE block.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
.../devicetree/bindings/sound/mt8183-afe-pcm.txt | 42 ----
.../devicetree/bindings/sound/mt8183-afe-pcm.yaml | 225 +++++++++++++++++++++
2 files changed, 225 insertions(+), 42 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.txt b/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.txt
deleted file mode 100644
index 1f1cba4152ceecbe61d0db0b972f98df7d5d91ac..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.txt
+++ /dev/null
@@ -1,42 +0,0 @@
-Mediatek AFE PCM controller for mt8183
-
-Required properties:
-- compatible = "mediatek,mt68183-audio";
-- reg: register location and size
-- interrupts: should contain AFE interrupt
-- resets: Must contain an entry for each entry in reset-names
- See ../reset/reset.txt for details.
-- reset-names: should have these reset names:
- "audiosys";
-- power-domains: should define the power domain
-- clocks: Must contain an entry for each entry in clock-names
-- clock-names: should have these clock names:
- "infra_sys_audio_clk",
- "mtkaif_26m_clk",
- "top_mux_audio",
- "top_mux_aud_intbus",
- "top_sys_pll3_d4",
- "top_clk26m_clk";
-
-Example:
-
- afe: mt8183-afe-pcm@11220000 {
- compatible = "mediatek,mt8183-audio";
- reg = <0 0x11220000 0 0x1000>;
- interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_LOW>;
- resets = <&watchdog MT8183_TOPRGU_AUDIO_SW_RST>;
- reset-names = "audiosys";
- power-domains = <&scpsys MT8183_POWER_DOMAIN_AUDIO>;
- clocks = <&infrasys CLK_INFRA_AUDIO>,
- <&infrasys CLK_INFRA_AUDIO_26M_BCLK>,
- <&topckgen CLK_TOP_MUX_AUDIO>,
- <&topckgen CLK_TOP_MUX_AUD_INTBUS>,
- <&topckgen CLK_TOP_SYSPLL_D2_D4>,
- <&clk26m>;
- clock-names = "infra_sys_audio_clk",
- "mtkaif_26m_clk",
- "top_mux_audio",
- "top_mux_aud_intbus",
- "top_sys_pll_d2_d4",
- "top_clk26m_clk";
- };
diff --git a/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..0f6ab43fa99e55a7572d962f61537c8ab31dcdb0
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.yaml
@@ -0,0 +1,225 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek AFE PCM controller for mt8183
+
+maintainers:
+ - Julien Massot <jmassot@collabora.com>
+
+properties:
+ compatible:
+ const: mediatek,mt8183-audio
+
+ interrupts:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
+ reset-names:
+ const: audiosys
+
+ power-domains:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: AFE clock
+ - description: ADDA DAC clock
+ - description: ADDA DAC pre-distortion clock
+ - description: ADDA ADC clock
+ - description: ADDA6 ADC clock
+ - description: Audio low-jitter 22.5792m clock
+ - description: Audio low-jitter 24.576m clock
+ - description: Audio PLL1 tuner clock
+ - description: Audio PLL2 tuner clock
+ - description: I2S1 bit clock
+ - description: I2S2 bit clock
+ - description: I2S3 bit clock
+ - description: I2S4 bit clock
+ - description: Audio Time-Division Multiplexing interface clock
+ - description: Powerdown Audio test model clock
+ - description: Audio infra sys clock
+ - description: Audio infra 26M clock
+ - description: Mux for audio clock
+ - description: Mux for audio internal bus clock
+ - description: Mux main divider by 4
+ - description: Primary audio mux
+ - description: Primary audio PLL
+ - description: Secondary audio mux
+ - description: Secondary audio PLL
+ - description: Primary audio en-generator clock
+ - description: Primary PLL divider by 4 for IEC
+ - description: Secondary audio en-generator clock
+ - description: Secondary PLL divider by 8 for IEC
+ - description: Mux selector for I2S port 0
+ - description: Mux selector for I2S port 1
+ - description: Mux selector for I2S port 2
+ - description: Mux selector for I2S port 3
+ - description: Mux selector for I2S port 4
+ - description: Mux selector for I2S port 5
+ - description: APLL1 and APLL2 divider for I2S port 0
+ - description: APLL1 and APLL2 divider for I2S port 1
+ - description: APLL1 and APLL2 divider for I2S port 2
+ - description: APLL1 and APLL2 divider for I2S port 3
+ - description: APLL1 and APLL2 divider for I2S port 4
+ - description: APLL1 and APLL2 divider for IEC
+ - description: 26MHz clock for audio subsystem
+
+ clock-names:
+ items:
+ - const: aud_afe_clk
+ - const: aud_dac_clk
+ - const: aud_dac_predis_clk
+ - const: aud_adc_clk
+ - const: aud_adc_adda6_clk
+ - const: aud_apll22m_clk
+ - const: aud_apll24m_clk
+ - const: aud_apll1_tuner_clk
+ - const: aud_apll2_tuner_clk
+ - const: aud_i2s1_bclk_sw
+ - const: aud_i2s2_bclk_sw
+ - const: aud_i2s3_bclk_sw
+ - const: aud_i2s4_bclk_sw
+ - const: aud_tdm_clk
+ - const: aud_tml_clk
+ - const: aud_infra_clk
+ - const: mtkaif_26m_clk
+ - const: top_mux_audio
+ - const: top_mux_aud_intbus
+ - const: top_syspll_d2_d4
+ - const: top_mux_aud_1
+ - const: top_apll1_ck
+ - const: top_mux_aud_2
+ - const: top_apll2_ck
+ - const: top_mux_aud_eng1
+ - const: top_apll1_d8
+ - const: top_mux_aud_eng2
+ - const: top_apll2_d8
+ - const: top_i2s0_m_sel
+ - const: top_i2s1_m_sel
+ - const: top_i2s2_m_sel
+ - const: top_i2s3_m_sel
+ - const: top_i2s4_m_sel
+ - const: top_i2s5_m_sel
+ - const: top_apll12_div0
+ - const: top_apll12_div1
+ - const: top_apll12_div2
+ - const: top_apll12_div3
+ - const: top_apll12_div4
+ - const: top_apll12_divb
+ - const: top_clk26m_clk
+
+required:
+ - compatible
+ - interrupts
+ - resets
+ - reset-names
+ - power-domains
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt8183-clk.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/power/mt8183-power.h>
+ #include <dt-bindings/reset/mt8183-resets.h>
+
+ afe: mt8183-afe-pcm {
+ compatible = "mediatek,mt8183-audio";
+ interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_LOW>;
+ resets = <&watchdog MT8183_TOPRGU_AUDIO_SW_RST>;
+ reset-names = "audiosys";
+ power-domains = <&spm MT8183_POWER_DOMAIN_AUDIO>;
+ clocks = <&audiosys CLK_AUDIO_AFE>,
+ <&audiosys CLK_AUDIO_DAC>,
+ <&audiosys CLK_AUDIO_DAC_PREDIS>,
+ <&audiosys CLK_AUDIO_ADC>,
+ <&audiosys CLK_AUDIO_PDN_ADDA6_ADC>,
+ <&audiosys CLK_AUDIO_22M>,
+ <&audiosys CLK_AUDIO_24M>,
+ <&audiosys CLK_AUDIO_APLL_TUNER>,
+ <&audiosys CLK_AUDIO_APLL2_TUNER>,
+ <&audiosys CLK_AUDIO_I2S1>,
+ <&audiosys CLK_AUDIO_I2S2>,
+ <&audiosys CLK_AUDIO_I2S3>,
+ <&audiosys CLK_AUDIO_I2S4>,
+ <&audiosys CLK_AUDIO_TDM>,
+ <&audiosys CLK_AUDIO_TML>,
+ <&infracfg CLK_INFRA_AUDIO>,
+ <&infracfg CLK_INFRA_AUDIO_26M_BCLK>,
+ <&topckgen CLK_TOP_MUX_AUDIO>,
+ <&topckgen CLK_TOP_MUX_AUD_INTBUS>,
+ <&topckgen CLK_TOP_SYSPLL_D2_D4>,
+ <&topckgen CLK_TOP_MUX_AUD_1>,
+ <&topckgen CLK_TOP_APLL1_CK>,
+ <&topckgen CLK_TOP_MUX_AUD_2>,
+ <&topckgen CLK_TOP_APLL2_CK>,
+ <&topckgen CLK_TOP_MUX_AUD_ENG1>,
+ <&topckgen CLK_TOP_APLL1_D8>,
+ <&topckgen CLK_TOP_MUX_AUD_ENG2>,
+ <&topckgen CLK_TOP_APLL2_D8>,
+ <&topckgen CLK_TOP_MUX_APLL_I2S0>,
+ <&topckgen CLK_TOP_MUX_APLL_I2S1>,
+ <&topckgen CLK_TOP_MUX_APLL_I2S2>,
+ <&topckgen CLK_TOP_MUX_APLL_I2S3>,
+ <&topckgen CLK_TOP_MUX_APLL_I2S4>,
+ <&topckgen CLK_TOP_MUX_APLL_I2S5>,
+ <&topckgen CLK_TOP_APLL12_DIV0>,
+ <&topckgen CLK_TOP_APLL12_DIV1>,
+ <&topckgen CLK_TOP_APLL12_DIV2>,
+ <&topckgen CLK_TOP_APLL12_DIV3>,
+ <&topckgen CLK_TOP_APLL12_DIV4>,
+ <&topckgen CLK_TOP_APLL12_DIVB>,
+ <&clk26m>;
+ clock-names = "aud_afe_clk",
+ "aud_dac_clk",
+ "aud_dac_predis_clk",
+ "aud_adc_clk",
+ "aud_adc_adda6_clk",
+ "aud_apll22m_clk",
+ "aud_apll24m_clk",
+ "aud_apll1_tuner_clk",
+ "aud_apll2_tuner_clk",
+ "aud_i2s1_bclk_sw",
+ "aud_i2s2_bclk_sw",
+ "aud_i2s3_bclk_sw",
+ "aud_i2s4_bclk_sw",
+ "aud_tdm_clk",
+ "aud_tml_clk",
+ "aud_infra_clk",
+ "mtkaif_26m_clk",
+ "top_mux_audio",
+ "top_mux_aud_intbus",
+ "top_syspll_d2_d4",
+ "top_mux_aud_1",
+ "top_apll1_ck",
+ "top_mux_aud_2",
+ "top_apll2_ck",
+ "top_mux_aud_eng1",
+ "top_apll1_d8",
+ "top_mux_aud_eng2",
+ "top_apll2_d8",
+ "top_i2s0_m_sel",
+ "top_i2s1_m_sel",
+ "top_i2s2_m_sel",
+ "top_i2s3_m_sel",
+ "top_i2s4_m_sel",
+ "top_i2s5_m_sel",
+ "top_apll12_div0",
+ "top_apll12_div1",
+ "top_apll12_div2",
+ "top_apll12_div3",
+ "top_apll12_div4",
+ "top_apll12_divb",
+ "top_clk26m_clk";
+ };
+
+...
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings to YAML
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
` (3 preceding siblings ...)
2025-08-01 11:18 ` [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-01 17:28 ` Rob Herring
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 " Julien Massot
` (4 subsequent siblings)
9 siblings, 2 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
Convert the Device Tree binding for MT8183-based boards using the
DA7219 headset codec and optional MAX98357, RT1015 or RT1015P speaker
amplifiers from the legacy .txt format to YAML schema.
This improves binding validation and removes DT schema warnings
for boards using these audio components.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
.../bindings/sound/mt8183-da7219-max98357.txt | 21 ----------
.../devicetree/bindings/sound/mt8183-da7219.yaml | 49 ++++++++++++++++++++++
2 files changed, 49 insertions(+), 21 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/mt8183-da7219-max98357.txt b/Documentation/devicetree/bindings/sound/mt8183-da7219-max98357.txt
deleted file mode 100644
index f276dfc74b4654deb0867f830e17a92638b39e23..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/sound/mt8183-da7219-max98357.txt
+++ /dev/null
@@ -1,21 +0,0 @@
-MT8183 with MT6358, DA7219, MAX98357, and RT1015 CODECS
-
-Required properties:
-- compatible : "mediatek,mt8183_da7219_max98357" for MAX98357A codec
- "mediatek,mt8183_da7219_rt1015" for RT1015 codec
- "mediatek,mt8183_da7219_rt1015p" for RT1015P codec
-- mediatek,headset-codec: the phandles of da7219 codecs
-- mediatek,platform: the phandle of MT8183 ASoC platform
-
-Optional properties:
-- mediatek,hdmi-codec: the phandles of HDMI codec
-
-Example:
-
- sound {
- compatible = "mediatek,mt8183_da7219_max98357";
- mediatek,headset-codec = <&da7219>;
- mediatek,hdmi-codec = <&it6505dptx>;
- mediatek,platform = <&afe>;
- };
-
diff --git a/Documentation/devicetree/bindings/sound/mt8183-da7219.yaml b/Documentation/devicetree/bindings/sound/mt8183-da7219.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..6c5098b450cd1b183c8e41325cbeedd9aec91b5d
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mt8183-da7219.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mt8183-da7219.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT8183 sound card with external codecs
+
+maintainers:
+ - Julien Massot <jmassot@collabora.com>
+
+description:
+ Binding for MediaTek MT8183 SoC-based sound cards with DA7219 as headset codec,
+ and MAX98357A, RT1015 or RT1015P as speaker amplifiers. Optionally includes HDMI codec.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8183_da7219_max98357
+ - mediatek,mt8183_da7219_rt1015
+ - mediatek,mt8183_da7219_rt1015p
+
+ mediatek,headset-codec:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the DA7219 headset codec.
+
+ mediatek,platform:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the MT8183 ASoC platform (e.g., AFE node).
+
+ mediatek,hdmi-codec:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Optional phandle to the HDMI codec (e.g., IT6505).
+
+required:
+ - compatible
+ - mediatek,headset-codec
+ - mediatek,platform
+
+additionalProperties: false
+
+examples:
+ - |
+ sound {
+ compatible = "mediatek,mt8183_da7219_max98357";
+ mediatek,headset-codec = <&da7219>;
+ mediatek,hdmi-codec = <&it6505dptx>;
+ mediatek,platform = <&afe>;
+ };
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
` (4 preceding siblings ...)
2025-08-01 11:18 ` [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings " Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-01 17:29 ` Rob Herring
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names Julien Massot
` (3 subsequent siblings)
9 siblings, 2 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
Convert the existing text-based DT binding for MT8183 sound cards using
MT6358 and various other codecs to a YAML schema.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
.../sound/mt8183-mt6358-ts3a227-max98357.txt | 25 ---------
.../devicetree/bindings/sound/mt8183-mt6358.yaml | 59 ++++++++++++++++++++++
2 files changed, 59 insertions(+), 25 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt b/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
deleted file mode 100644
index ecd46ed8eb98b99d0f2cc9eeca5f6d0aef6a5ada..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-MT8183 with MT6358, TS3A227, MAX98357, and RT1015 CODECS
-
-Required properties:
-- compatible : "mediatek,mt8183_mt6358_ts3a227_max98357" for MAX98357A codec
- "mediatek,mt8183_mt6358_ts3a227_max98357b" for MAX98357B codec
- "mediatek,mt8183_mt6358_ts3a227_rt1015" for RT1015 codec
- "mediatek,mt8183_mt6358_ts3a227_rt1015p" for RT1015P codec
-- mediatek,platform: the phandle of MT8183 ASoC platform
-
-Optional properties:
-- mediatek,headset-codec: the phandles of ts3a227 codecs
-- mediatek,ec-codec: the phandle of EC codecs.
- See google,cros-ec-codec.txt for more details.
-- mediatek,hdmi-codec: the phandles of HDMI codec
-
-Example:
-
- sound {
- compatible = "mediatek,mt8183_mt6358_ts3a227_max98357";
- mediatek,headset-codec = <&ts3a227>;
- mediatek,ec-codec = <&ec_codec>;
- mediatek,hdmi-codec = <&it6505dptx>;
- mediatek,platform = <&afe>;
- };
-
diff --git a/Documentation/devicetree/bindings/sound/mt8183-mt6358.yaml b/Documentation/devicetree/bindings/sound/mt8183-mt6358.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..a50dc109e8f307cfb08504a9143a178e880266c9
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mt8183-mt6358.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mt8183-mt6358.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT8183 sound card with MT6358, TS3A227, and MAX98357/RT1015 codecs
+
+maintainers:
+ - Julien Massot <julien.massot@collabora.com>
+
+description:
+ Binding for MediaTek MT8183 SoC-based sound cards using the MT6358 codec,
+ with optional TS3A227 headset codec, EC codec (via Chrome EC), and HDMI audio.
+ Speaker amplifier can be one of MAX98357A/B, RT1015, or RT1015P.
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8183_mt6358_ts3a227_max98357
+ - mediatek,mt8183_mt6358_ts3a227_max98357b
+ - mediatek,mt8183_mt6358_ts3a227_rt1015
+ - mediatek,mt8183_mt6358_ts3a227_rt1015p
+
+ mediatek,platform:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the MT8183 ASoC platform node (e.g., AFE).
+
+ mediatek,headset-codec:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the TS3A227 headset codec.
+
+ mediatek,ec-codec:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: |
+ Optional phandle to a ChromeOS EC codec node.
+ See bindings in google,cros-ec-codec.yaml.
+
+ mediatek,hdmi-codec:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Optional phandle to an HDMI audio codec node.
+
+required:
+ - compatible
+ - mediatek,platform
+
+additionalProperties: false
+
+examples:
+ - |
+ sound {
+ compatible = "mediatek,mt8183_mt6358_ts3a227_max98357";
+ mediatek,headset-codec = <&ts3a227>;
+ mediatek,ec-codec = <&ec_codec>;
+ mediatek,hdmi-codec = <&it6505dptx>;
+ mediatek,platform = <&afe>;
+ };
+
+...
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
` (5 preceding siblings ...)
2025-08-01 11:18 ` [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 " Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-01 17:30 ` Rob Herring (Arm)
` (2 more replies)
2025-08-01 11:18 ` [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values Julien Massot
` (2 subsequent siblings)
9 siblings, 3 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
Add support for the 'gpio-line-names' property in the MT8183 pinctrl
binding.
This allows naming the GPIOs, which is already done in several
device trees (e.g. mt8183-kukui-jacuzzi.dtsi, mt8183-kukui-kakadu.dtsi,
mt8183-kukui-krane.dtsi), but was previously generating DT schema
warnings.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml
index 464879274cae4c5389f1210ba65c316ce6c433f7..3db2438fadc78bb45ae7f137abfbab14e462d138 100644
--- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml
@@ -48,6 +48,8 @@ properties:
description:
GPIO valid number range.
+ gpio-line-names: true
+
interrupt-controller: true
interrupts:
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
` (6 preceding siblings ...)
2025-08-01 11:18 ` [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-06 6:38 ` Chen-Yu Tsai
2025-08-01 11:18 ` [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: " Julien Massot
2025-08-01 13:26 ` [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Rob Herring (Arm)
9 siblings, 2 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv`
were using incorrect values like `<10>` and `<01>`. These values
are parsed as decimal (10 and 1 respectively), not binary.
However, the driver interprets these as bitfields:
- BIT(0): R0
- BIT(1): R1
So valid values are:
- 0 => no pull
- 1 => enable R0
- 2 => enable R1
- 3 => enable R0 + R1
Using `<10>` is invalid as it exceeds the accepted range.
It was likely intended as binary `0b10` (i.e., `2`),
to enable R1 only.
This patch replaces incorrect values with the correct ones
and removes the leading zero from `<01>` to avoid confusion
with bitfield notation.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index 400c61d1103561db6ee0fb2d2e1c157529d03206..02bdfdb8e53c87dba0ba0024e0c69fcee825552b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -574,19 +574,19 @@ pins-cmd-dat {
<PINMUX_GPIO122__FUNC_MSDC0_CMD>;
input-enable;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-up-adv = <01>;
+ mediatek,pull-up-adv = <1>;
};
pins-clk {
pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
};
pins-rst {
pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-down-adv = <01>;
+ mediatek,pull-down-adv = <1>;
};
};
@@ -603,25 +603,25 @@ pins-cmd-dat {
<PINMUX_GPIO122__FUNC_MSDC0_CMD>;
input-enable;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-up-adv = <01>;
+ mediatek,pull-up-adv = <1>;
};
pins-clk {
pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
};
pins-ds {
pinmux = <PINMUX_GPIO131__FUNC_MSDC0_DSL>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
};
pins-rst {
pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-up-adv = <01>;
+ mediatek,pull-up-adv = <1>;
};
};
@@ -633,13 +633,13 @@ pins-cmd-dat {
<PINMUX_GPIO33__FUNC_MSDC1_DAT2>,
<PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
input-enable;
- mediatek,pull-up-adv = <10>;
+ mediatek,pull-up-adv = <2>;
};
pins-clk {
pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
input-enable;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
};
};
@@ -652,13 +652,13 @@ pins-cmd-dat {
<PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
drive-strength = <6>;
input-enable;
- mediatek,pull-up-adv = <10>;
+ mediatek,pull-up-adv = <2>;
};
pins-clk {
pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
drive-strength = <8>;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
input-enable;
};
};
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: Fix pull-down/up-adv values
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
` (7 preceding siblings ...)
2025-08-01 11:18 ` [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values Julien Massot
@ 2025-08-01 11:18 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 13:26 ` [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Rob Herring (Arm)
9 siblings, 1 reply; 38+ messages in thread
From: Julien Massot @ 2025-08-01 11:18 UTC (permalink / raw)
To: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio, Julien Massot
The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv`
were using incorrect values like `<10>` and `<01>`. These values
are parsed as decimal (10 and 1 respectively), not binary.
However, the driver interprets these as bitfields:
- BIT(0): R0
- BIT(1): R1
So valid values are:
- 0 => no pull
- 1 => enable R0
- 2 => enable R1
- 3 => enable R0 + R1
Using `<10>` is invalid as it exceeds the accepted range.
It was likely intended as binary `0b10` (i.e., `2`),
to enable R1 only.
This patch replaces incorrect values with the correct ones
and removes the leading zero from `<01>` to avoid confusion
with bitfield notation.
Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
index dbdee604edab4318c1ba87b9594ce52282b0c405..bbed369db986f3f24aea470a9ad63a7c1e2cb3c9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts
@@ -318,19 +318,19 @@ pins_cmd_dat {
<PINMUX_GPIO122__FUNC_MSDC0_CMD>;
input-enable;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-up-adv = <01>;
+ mediatek,pull-up-adv = <1>;
};
pins_clk {
pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
};
pins_rst {
pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-down-adv = <01>;
+ mediatek,pull-down-adv = <1>;
};
};
@@ -347,25 +347,25 @@ pins_cmd_dat {
<PINMUX_GPIO122__FUNC_MSDC0_CMD>;
input-enable;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-up-adv = <01>;
+ mediatek,pull-up-adv = <1>;
};
pins_clk {
pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
};
pins_ds {
pinmux = <PINMUX_GPIO131__FUNC_MSDC0_DSL>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
};
pins_rst {
pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>;
drive-strength = <MTK_DRIVE_14mA>;
- mediatek,pull-up-adv = <01>;
+ mediatek,pull-up-adv = <1>;
};
};
@@ -377,13 +377,13 @@ pins_cmd_dat {
<PINMUX_GPIO33__FUNC_MSDC1_DAT2>,
<PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
input-enable;
- mediatek,pull-up-adv = <10>;
+ mediatek,pull-up-adv = <2>;
};
pins_clk {
pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
input-enable;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
};
pins_pmu {
@@ -401,13 +401,13 @@ pins_cmd_dat {
<PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
drive-strength = <6>;
input-enable;
- mediatek,pull-up-adv = <10>;
+ mediatek,pull-up-adv = <2>;
};
pins_clk {
pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
drive-strength = <8>;
- mediatek,pull-down-adv = <10>;
+ mediatek,pull-down-adv = <2>;
input-enable;
};
};
--
2.50.1
^ permalink raw reply related [flat|nested] 38+ messages in thread
* Re: [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
` (8 preceding siblings ...)
2025-08-01 11:18 ` [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: " Julien Massot
@ 2025-08-01 13:26 ` Rob Herring (Arm)
9 siblings, 0 replies; 38+ messages in thread
From: Rob Herring (Arm) @ 2025-08-01 13:26 UTC (permalink / raw)
To: Julien Massot
Cc: Linus Walleij, linux-sound, Eugen Hristev, Ikjoon Jang,
Matthias Brugger, Michael Turquette, devicetree,
AngeloGioacchino Del Regno, kernel, linux-kernel, Stephen Boyd,
Liam Girdwood, linux-arm-kernel, linux-gpio, Julien Massot,
linux-mediatek, Enric Balletbo i Serra, Conor Dooley, linux-clk,
Krzysztof Kozlowski, Weiyi Lu, Chen-Yu Tsai, Mark Brown,
Sean Wang
On Fri, 01 Aug 2025 13:18:02 +0200, Julien Massot wrote:
> This patch series continues the effort to address Device Tree validation warnings for MediaTek platforms, with a focus on MT8183. It follows the initial cleanup series by Angelo (https://www.spinics.net/lists/kernel/msg5780177.html)
>
> The patches in this set eliminate several of the remaining warnings by improving or converting DT bindings to YAML, adding missing properties, and updating device tree files accordingly.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> Julien Massot (9):
> dt-bindings: clock: mediatek: Add power-domains property
> dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant
> arm64: dts: mt8183: Rename nodes to match audiosys binding schema
> ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML
> dt-bindings: sound: Convert MT8183 DA7219 sound card bindings to YAML
> ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
> dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names
> arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
> arm64: dts: mediatek: mt8183-pumkin: Fix pull-down/up-adv values
>
> .../bindings/arm/mediatek/mediatek,audsys.yaml | 17 +-
> .../devicetree/bindings/clock/mediatek,syscon.yaml | 3 +
> .../bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 2 +
> .../devicetree/bindings/sound/mt8183-afe-pcm.txt | 42 ----
> .../devicetree/bindings/sound/mt8183-afe-pcm.yaml | 225 +++++++++++++++++++++
> .../bindings/sound/mt8183-da7219-max98357.txt | 21 --
> .../devicetree/bindings/sound/mt8183-da7219.yaml | 49 +++++
> .../sound/mt8183-mt6358-ts3a227-max98357.txt | 25 ---
> .../devicetree/bindings/sound/mt8183-mt6358.yaml | 59 ++++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 22 +-
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts | 22 +-
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 +-
> 12 files changed, 378 insertions(+), 113 deletions(-)
> ---
> base-commit: b9ddaa95fd283bce7041550ddbbe7e764c477110
> change-id: 20250801-mtk-dtb-warnings-157d4fc10f77
>
> Best regards,
> --
> Julien Massot <julien.massot@collabora.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit b9ddaa95fd283bce7041550ddbbe7e764c477110
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/mediatek/' for 20250801-mtk-dtb-warnings-v1-0-6ba4e432427b@collabora.com:
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'da7219_pins', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'touchdefault', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'da7219_pins', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'da7219_pins', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'da7219_pins', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-makomo-sku1.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-makomo-sku1.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-makomo-sku1.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'touchdefault', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'da7219_pins', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'open_touch', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-makomo-sku0.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'da7219_pins', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-makomo-sku0.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-makomo-sku0.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'open_touch', 'peneject', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'touchdefault', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'open_touch', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'da7219_pins', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'open_touch', 'peneject', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-katsu-sku32.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'da7219_pins', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'open_touch', 'peneject', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-katsu-sku32.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-katsu-sku32.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1000-mipibrdg-en', 'pp1800-mipibrdg-en', 'pp3300-mipibrdg-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-katsu-sku38.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'open_touch', 'peneject', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb: pinctrl@10005000 (mediatek,mt8183-pinctrl): 'audiopins', 'audiotdmoutoff', 'audiotdmouton', 'ec-ap-int-odl', 'h1-int-od-l', 'i2c0', 'i2c1', 'i2c2', 'i2c3', 'i2c4', 'i2c5', 'i2c6', 'pp1800-lcd-en', 'ppvarn-lcd-en', 'ppvarp-lcd-en', 'pwm0-pin-default', 'scp', 'spi0', 'spi1', 'spi2', 'spi3', 'spi4', 'spi5', 'touchdefault', 'ts3a227e_pins' do not match any of the regexes: '-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8183-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-katsu-sku38.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-katsu-sku38.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb: clock-controller@11220000 (mediatek,mt8183-audiosys): audio-controller: 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/arm/mediatek/mediatek,audsys.yaml#
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb: audio-controller (mediatek,mt8183-audio): 'memory-region' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property
2025-08-01 11:18 ` [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property Julien Massot
@ 2025-08-01 17:19 ` Rob Herring (Arm)
2025-08-04 7:59 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 38+ messages in thread
From: Rob Herring (Arm) @ 2025-08-01 17:19 UTC (permalink / raw)
To: Julien Massot
Cc: Ikjoon Jang, linux-mediatek, linux-kernel, Mark Brown, linux-gpio,
Matthias Brugger, AngeloGioacchino Del Regno, Linus Walleij,
Julien Massot, Chen-Yu Tsai, Liam Girdwood, Conor Dooley,
Stephen Boyd, Weiyi Lu, Sean Wang, devicetree, kernel,
linux-sound, Michael Turquette, Eugen Hristev,
Krzysztof Kozlowski, Enric Balletbo i Serra, linux-arm-kernel,
linux-clk
On Fri, 01 Aug 2025 13:18:03 +0200, Julien Massot wrote:
> The mt8183-mfgcfg node uses a power domain in its device tree node.
> To prevent schema validation warnings, add the optional `power-domains`
> property to the binding schema for mediatek syscon clocks.
>
> Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> Documentation/devicetree/bindings/clock/mediatek,syscon.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant
2025-08-01 11:18 ` [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant Julien Massot
@ 2025-08-01 17:21 ` Rob Herring
2025-08-20 13:28 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 38+ messages in thread
From: Rob Herring @ 2025-08-01 17:21 UTC (permalink / raw)
To: Julien Massot
Cc: kernel, Michael Turquette, Stephen Boyd, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
On Fri, Aug 01, 2025 at 01:18:04PM +0200, Julien Massot wrote:
> Update the mediatek,audsys binding to support the mt8183-audiosys
> compatible, which uses a different audio controller binding
> (mt8183-afe-pcm.yaml) compared to the legacy mt2701-audio controller.
Looks like this one needs 'memory-region' added?
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> .../bindings/arm/mediatek/mediatek,audsys.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> index 45d4a6620041b11cf6e943de49a42f3fcd91e1b9..5d9d91f9c5802240ac7d411c5632ae6663d15f29 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> @@ -23,6 +23,7 @@ properties:
> - mediatek,mt7622-audsys
> - mediatek,mt8167-audsys
> - mediatek,mt8173-audsys
> + - mediatek,mt8183-audiosys
> - mediatek,mt8183-audsys
> - mediatek,mt8186-audsys
> - mediatek,mt8192-audsys
> @@ -41,7 +42,6 @@ properties:
> const: 1
>
> audio-controller:
> - $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
> type: object
>
> required:
> @@ -50,6 +50,21 @@ required:
>
> additionalProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8183-audiosys
> + then:
> + properties:
> + audio-controller:
> + $ref: /schemas/sound/mt8183-afe-pcm.yaml#
> + else:
> + properties:
> + audio-controller:
> + $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
> +
> examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML
2025-08-01 11:18 ` [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML Julien Massot
@ 2025-08-01 17:26 ` Rob Herring
2025-08-20 13:32 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 38+ messages in thread
From: Rob Herring @ 2025-08-01 17:26 UTC (permalink / raw)
To: Julien Massot
Cc: kernel, Michael Turquette, Stephen Boyd, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
On Fri, Aug 01, 2025 at 01:18:06PM +0200, Julien Massot wrote:
> Convert the MediaTek MT8183 AFE PCM Device Tree binding from the old
> .txt format to YAML schema format to improve validation.
>
> While converting, also document all clock inputs used by the AFE block.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> .../devicetree/bindings/sound/mt8183-afe-pcm.txt | 42 ----
> .../devicetree/bindings/sound/mt8183-afe-pcm.yaml | 225 +++++++++++++++++++++
> 2 files changed, 225 insertions(+), 42 deletions(-)
This should come before patch 2 since it is referenced there.
Use the compatible string for the filename.
Otherwise, looks good to me.
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings to YAML
2025-08-01 11:18 ` [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings " Julien Massot
@ 2025-08-01 17:28 ` Rob Herring
2025-08-20 13:33 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 38+ messages in thread
From: Rob Herring @ 2025-08-01 17:28 UTC (permalink / raw)
To: Julien Massot
Cc: kernel, Michael Turquette, Stephen Boyd, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
On Fri, Aug 01, 2025 at 01:18:07PM +0200, Julien Massot wrote:
> Convert the Device Tree binding for MT8183-based boards using the
> DA7219 headset codec and optional MAX98357, RT1015 or RT1015P speaker
> amplifiers from the legacy .txt format to YAML schema.
>
> This improves binding validation and removes DT schema warnings
> for boards using these audio components.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> .../bindings/sound/mt8183-da7219-max98357.txt | 21 ----------
> .../devicetree/bindings/sound/mt8183-da7219.yaml | 49 ++++++++++++++++++++++
mediatek,mt8183_da7219.yaml
> 2 files changed, 49 insertions(+), 21 deletions(-)
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
2025-08-01 11:18 ` [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 " Julien Massot
@ 2025-08-01 17:29 ` Rob Herring
2025-08-20 13:34 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 38+ messages in thread
From: Rob Herring @ 2025-08-01 17:29 UTC (permalink / raw)
To: Julien Massot
Cc: kernel, Michael Turquette, Stephen Boyd, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
On Fri, Aug 01, 2025 at 01:18:08PM +0200, Julien Massot wrote:
> Convert the existing text-based DT binding for MT8183 sound cards using
> MT6358 and various other codecs to a YAML schema.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> .../sound/mt8183-mt6358-ts3a227-max98357.txt | 25 ---------
> .../devicetree/bindings/sound/mt8183-mt6358.yaml | 59 ++++++++++++++++++++++
mediatek,mt8183_mt6358_ts3a227.yaml
> 2 files changed, 59 insertions(+), 25 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt b/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
> deleted file mode 100644
> index ecd46ed8eb98b99d0f2cc9eeca5f6d0aef6a5ada..0000000000000000000000000000000000000000
> --- a/Documentation/devicetree/bindings/sound/mt8183-mt6358-ts3a227-max98357.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -MT8183 with MT6358, TS3A227, MAX98357, and RT1015 CODECS
> -
> -Required properties:
> -- compatible : "mediatek,mt8183_mt6358_ts3a227_max98357" for MAX98357A codec
> - "mediatek,mt8183_mt6358_ts3a227_max98357b" for MAX98357B codec
> - "mediatek,mt8183_mt6358_ts3a227_rt1015" for RT1015 codec
> - "mediatek,mt8183_mt6358_ts3a227_rt1015p" for RT1015P codec
> -- mediatek,platform: the phandle of MT8183 ASoC platform
> -
> -Optional properties:
> -- mediatek,headset-codec: the phandles of ts3a227 codecs
> -- mediatek,ec-codec: the phandle of EC codecs.
> - See google,cros-ec-codec.txt for more details.
> -- mediatek,hdmi-codec: the phandles of HDMI codec
> -
> -Example:
> -
> - sound {
> - compatible = "mediatek,mt8183_mt6358_ts3a227_max98357";
> - mediatek,headset-codec = <&ts3a227>;
> - mediatek,ec-codec = <&ec_codec>;
> - mediatek,hdmi-codec = <&it6505dptx>;
> - mediatek,platform = <&afe>;
> - };
> -
> diff --git a/Documentation/devicetree/bindings/sound/mt8183-mt6358.yaml b/Documentation/devicetree/bindings/sound/mt8183-mt6358.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..a50dc109e8f307cfb08504a9143a178e880266c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mt8183-mt6358.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mt8183-mt6358.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT8183 sound card with MT6358, TS3A227, and MAX98357/RT1015 codecs
> +
> +maintainers:
> + - Julien Massot <julien.massot@collabora.com>
> +
> +description:
> + Binding for MediaTek MT8183 SoC-based sound cards using the MT6358 codec,
> + with optional TS3A227 headset codec, EC codec (via Chrome EC), and HDMI audio.
> + Speaker amplifier can be one of MAX98357A/B, RT1015, or RT1015P.
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt8183_mt6358_ts3a227_max98357
> + - mediatek,mt8183_mt6358_ts3a227_max98357b
> + - mediatek,mt8183_mt6358_ts3a227_rt1015
> + - mediatek,mt8183_mt6358_ts3a227_rt1015p
> +
> + mediatek,platform:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the MT8183 ASoC platform node (e.g., AFE).
> +
> + mediatek,headset-codec:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the TS3A227 headset codec.
> +
> + mediatek,ec-codec:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: |
> + Optional phandle to a ChromeOS EC codec node.
> + See bindings in google,cros-ec-codec.yaml.
> +
> + mediatek,hdmi-codec:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Optional phandle to an HDMI audio codec node.
> +
> +required:
> + - compatible
> + - mediatek,platform
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sound {
> + compatible = "mediatek,mt8183_mt6358_ts3a227_max98357";
> + mediatek,headset-codec = <&ts3a227>;
> + mediatek,ec-codec = <&ec_codec>;
> + mediatek,hdmi-codec = <&it6505dptx>;
> + mediatek,platform = <&afe>;
> + };
> +
> +...
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names
2025-08-01 11:18 ` [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names Julien Massot
@ 2025-08-01 17:30 ` Rob Herring (Arm)
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-18 15:16 ` Linus Walleij
2 siblings, 0 replies; 38+ messages in thread
From: Rob Herring (Arm) @ 2025-08-01 17:30 UTC (permalink / raw)
To: Julien Massot
Cc: kernel, Linus Walleij, linux-arm-kernel, Krzysztof Kozlowski,
Enric Balletbo i Serra, linux-gpio, linux-kernel, Liam Girdwood,
Mark Brown, Matthias Brugger, linux-mediatek, Weiyi Lu,
Chen-Yu Tsai, Michael Turquette, Julien Massot, devicetree,
linux-sound, Sean Wang, Ikjoon Jang, linux-clk, Eugen Hristev,
Conor Dooley, Stephen Boyd, AngeloGioacchino Del Regno
On Fri, 01 Aug 2025 13:18:09 +0200, Julien Massot wrote:
> Add support for the 'gpio-line-names' property in the MT8183 pinctrl
> binding.
> This allows naming the GPIOs, which is already done in several
> device trees (e.g. mt8183-kukui-jacuzzi.dtsi, mt8183-kukui-kakadu.dtsi,
> mt8183-kukui-krane.dtsi), but was previously generating DT schema
> warnings.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: Fix pull-down/up-adv values
2025-08-01 11:18 ` [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: " Julien Massot
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv`
> were using incorrect values like `<10>` and `<01>`. These values
> are parsed as decimal (10 and 1 respectively), not binary.
>
> However, the driver interprets these as bitfields:
> - BIT(0): R0
> - BIT(1): R1
>
> So valid values are:
> - 0 => no pull
> - 1 => enable R0
> - 2 => enable R1
> - 3 => enable R0 + R1
>
> Using `<10>` is invalid as it exceeds the accepted range.
> It was likely intended as binary `0b10` (i.e., `2`),
> to enable R1 only.
>
> This patch replaces incorrect values with the correct ones
> and removes the leading zero from `<01>` to avoid confusion
> with bitfield notation.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
2025-08-01 11:18 ` [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values Julien Massot
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-06 6:38 ` Chen-Yu Tsai
1 sibling, 0 replies; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv`
> were using incorrect values like `<10>` and `<01>`. These values
> are parsed as decimal (10 and 1 respectively), not binary.
>
> However, the driver interprets these as bitfields:
> - BIT(0): R0
> - BIT(1): R1
>
> So valid values are:
> - 0 => no pull
> - 1 => enable R0
> - 2 => enable R1
> - 3 => enable R0 + R1
>
> Using `<10>` is invalid as it exceeds the accepted range.
> It was likely intended as binary `0b10` (i.e., `2`),
> to enable R1 only.
>
> This patch replaces incorrect values with the correct ones
> and removes the leading zero from `<01>` to avoid confusion
> with bitfield notation.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
2025-08-01 11:18 ` [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 " Julien Massot
2025-08-01 17:29 ` Rob Herring
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> Convert the existing text-based DT binding for MT8183 sound cards using
> MT6358 and various other codecs to a YAML schema.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML
2025-08-01 11:18 ` [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML Julien Massot
2025-08-01 17:26 ` Rob Herring
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> Convert the MediaTek MT8183 AFE PCM Device Tree binding from the old
> .txt format to YAML schema format to improve validation.
>
> While converting, also document all clock inputs used by the AFE block.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Great!
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../devicetree/bindings/sound/mt8183-afe-pcm.txt | 42 ----
> .../devicetree/bindings/sound/mt8183-afe-pcm.yaml | 225 +++++++++++++++++++++
> 2 files changed, 225 insertions(+), 42 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.txt b/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.txt
> deleted file mode 100644
> index 1f1cba4152ceecbe61d0db0b972f98df7d5d91ac..0000000000000000000000000000000000000000
> --- a/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -Mediatek AFE PCM controller for mt8183
> -
> -Required properties:
> -- compatible = "mediatek,mt68183-audio";
> -- reg: register location and size
> -- interrupts: should contain AFE interrupt
> -- resets: Must contain an entry for each entry in reset-names
> - See ../reset/reset.txt for details.
> -- reset-names: should have these reset names:
> - "audiosys";
> -- power-domains: should define the power domain
> -- clocks: Must contain an entry for each entry in clock-names
> -- clock-names: should have these clock names:
> - "infra_sys_audio_clk",
> - "mtkaif_26m_clk",
> - "top_mux_audio",
> - "top_mux_aud_intbus",
> - "top_sys_pll3_d4",
> - "top_clk26m_clk";
> -
> -Example:
> -
> - afe: mt8183-afe-pcm@11220000 {
> - compatible = "mediatek,mt8183-audio";
> - reg = <0 0x11220000 0 0x1000>;
> - interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_LOW>;
> - resets = <&watchdog MT8183_TOPRGU_AUDIO_SW_RST>;
> - reset-names = "audiosys";
> - power-domains = <&scpsys MT8183_POWER_DOMAIN_AUDIO>;
> - clocks = <&infrasys CLK_INFRA_AUDIO>,
> - <&infrasys CLK_INFRA_AUDIO_26M_BCLK>,
> - <&topckgen CLK_TOP_MUX_AUDIO>,
> - <&topckgen CLK_TOP_MUX_AUD_INTBUS>,
> - <&topckgen CLK_TOP_SYSPLL_D2_D4>,
> - <&clk26m>;
> - clock-names = "infra_sys_audio_clk",
> - "mtkaif_26m_clk",
> - "top_mux_audio",
> - "top_mux_aud_intbus",
> - "top_sys_pll_d2_d4",
> - "top_clk26m_clk";
> - };
> diff --git a/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..0f6ab43fa99e55a7572d962f61537c8ab31dcdb0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mt8183-afe-pcm.yaml
> @@ -0,0 +1,225 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mt8183-afe-pcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek AFE PCM controller for mt8183
> +
> +maintainers:
> + - Julien Massot <jmassot@collabora.com>
> +
> +properties:
> + compatible:
> + const: mediatek,mt8183-audio
> +
> + interrupts:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: audiosys
> +
> + power-domains:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: AFE clock
> + - description: ADDA DAC clock
> + - description: ADDA DAC pre-distortion clock
> + - description: ADDA ADC clock
> + - description: ADDA6 ADC clock
> + - description: Audio low-jitter 22.5792m clock
> + - description: Audio low-jitter 24.576m clock
> + - description: Audio PLL1 tuner clock
> + - description: Audio PLL2 tuner clock
> + - description: I2S1 bit clock
> + - description: I2S2 bit clock
> + - description: I2S3 bit clock
> + - description: I2S4 bit clock
> + - description: Audio Time-Division Multiplexing interface clock
> + - description: Powerdown Audio test model clock
> + - description: Audio infra sys clock
> + - description: Audio infra 26M clock
> + - description: Mux for audio clock
> + - description: Mux for audio internal bus clock
> + - description: Mux main divider by 4
> + - description: Primary audio mux
> + - description: Primary audio PLL
> + - description: Secondary audio mux
> + - description: Secondary audio PLL
> + - description: Primary audio en-generator clock
> + - description: Primary PLL divider by 4 for IEC
> + - description: Secondary audio en-generator clock
> + - description: Secondary PLL divider by 8 for IEC
> + - description: Mux selector for I2S port 0
> + - description: Mux selector for I2S port 1
> + - description: Mux selector for I2S port 2
> + - description: Mux selector for I2S port 3
> + - description: Mux selector for I2S port 4
> + - description: Mux selector for I2S port 5
> + - description: APLL1 and APLL2 divider for I2S port 0
> + - description: APLL1 and APLL2 divider for I2S port 1
> + - description: APLL1 and APLL2 divider for I2S port 2
> + - description: APLL1 and APLL2 divider for I2S port 3
> + - description: APLL1 and APLL2 divider for I2S port 4
> + - description: APLL1 and APLL2 divider for IEC
> + - description: 26MHz clock for audio subsystem
> +
> + clock-names:
> + items:
> + - const: aud_afe_clk
> + - const: aud_dac_clk
> + - const: aud_dac_predis_clk
> + - const: aud_adc_clk
> + - const: aud_adc_adda6_clk
> + - const: aud_apll22m_clk
> + - const: aud_apll24m_clk
> + - const: aud_apll1_tuner_clk
> + - const: aud_apll2_tuner_clk
> + - const: aud_i2s1_bclk_sw
> + - const: aud_i2s2_bclk_sw
> + - const: aud_i2s3_bclk_sw
> + - const: aud_i2s4_bclk_sw
> + - const: aud_tdm_clk
> + - const: aud_tml_clk
> + - const: aud_infra_clk
> + - const: mtkaif_26m_clk
> + - const: top_mux_audio
> + - const: top_mux_aud_intbus
> + - const: top_syspll_d2_d4
> + - const: top_mux_aud_1
> + - const: top_apll1_ck
> + - const: top_mux_aud_2
> + - const: top_apll2_ck
> + - const: top_mux_aud_eng1
> + - const: top_apll1_d8
> + - const: top_mux_aud_eng2
> + - const: top_apll2_d8
> + - const: top_i2s0_m_sel
> + - const: top_i2s1_m_sel
> + - const: top_i2s2_m_sel
> + - const: top_i2s3_m_sel
> + - const: top_i2s4_m_sel
> + - const: top_i2s5_m_sel
> + - const: top_apll12_div0
> + - const: top_apll12_div1
> + - const: top_apll12_div2
> + - const: top_apll12_div3
> + - const: top_apll12_div4
> + - const: top_apll12_divb
> + - const: top_clk26m_clk
> +
> +required:
> + - compatible
> + - interrupts
> + - resets
> + - reset-names
> + - power-domains
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt8183-clk.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/power/mt8183-power.h>
> + #include <dt-bindings/reset/mt8183-resets.h>
> +
> + afe: mt8183-afe-pcm {
> + compatible = "mediatek,mt8183-audio";
> + interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_LOW>;
> + resets = <&watchdog MT8183_TOPRGU_AUDIO_SW_RST>;
> + reset-names = "audiosys";
> + power-domains = <&spm MT8183_POWER_DOMAIN_AUDIO>;
> + clocks = <&audiosys CLK_AUDIO_AFE>,
> + <&audiosys CLK_AUDIO_DAC>,
> + <&audiosys CLK_AUDIO_DAC_PREDIS>,
> + <&audiosys CLK_AUDIO_ADC>,
> + <&audiosys CLK_AUDIO_PDN_ADDA6_ADC>,
> + <&audiosys CLK_AUDIO_22M>,
> + <&audiosys CLK_AUDIO_24M>,
> + <&audiosys CLK_AUDIO_APLL_TUNER>,
> + <&audiosys CLK_AUDIO_APLL2_TUNER>,
> + <&audiosys CLK_AUDIO_I2S1>,
> + <&audiosys CLK_AUDIO_I2S2>,
> + <&audiosys CLK_AUDIO_I2S3>,
> + <&audiosys CLK_AUDIO_I2S4>,
> + <&audiosys CLK_AUDIO_TDM>,
> + <&audiosys CLK_AUDIO_TML>,
> + <&infracfg CLK_INFRA_AUDIO>,
> + <&infracfg CLK_INFRA_AUDIO_26M_BCLK>,
> + <&topckgen CLK_TOP_MUX_AUDIO>,
> + <&topckgen CLK_TOP_MUX_AUD_INTBUS>,
> + <&topckgen CLK_TOP_SYSPLL_D2_D4>,
> + <&topckgen CLK_TOP_MUX_AUD_1>,
> + <&topckgen CLK_TOP_APLL1_CK>,
> + <&topckgen CLK_TOP_MUX_AUD_2>,
> + <&topckgen CLK_TOP_APLL2_CK>,
> + <&topckgen CLK_TOP_MUX_AUD_ENG1>,
> + <&topckgen CLK_TOP_APLL1_D8>,
> + <&topckgen CLK_TOP_MUX_AUD_ENG2>,
> + <&topckgen CLK_TOP_APLL2_D8>,
> + <&topckgen CLK_TOP_MUX_APLL_I2S0>,
> + <&topckgen CLK_TOP_MUX_APLL_I2S1>,
> + <&topckgen CLK_TOP_MUX_APLL_I2S2>,
> + <&topckgen CLK_TOP_MUX_APLL_I2S3>,
> + <&topckgen CLK_TOP_MUX_APLL_I2S4>,
> + <&topckgen CLK_TOP_MUX_APLL_I2S5>,
> + <&topckgen CLK_TOP_APLL12_DIV0>,
> + <&topckgen CLK_TOP_APLL12_DIV1>,
> + <&topckgen CLK_TOP_APLL12_DIV2>,
> + <&topckgen CLK_TOP_APLL12_DIV3>,
> + <&topckgen CLK_TOP_APLL12_DIV4>,
> + <&topckgen CLK_TOP_APLL12_DIVB>,
> + <&clk26m>;
> + clock-names = "aud_afe_clk",
> + "aud_dac_clk",
> + "aud_dac_predis_clk",
> + "aud_adc_clk",
> + "aud_adc_adda6_clk",
> + "aud_apll22m_clk",
> + "aud_apll24m_clk",
> + "aud_apll1_tuner_clk",
> + "aud_apll2_tuner_clk",
> + "aud_i2s1_bclk_sw",
> + "aud_i2s2_bclk_sw",
> + "aud_i2s3_bclk_sw",
> + "aud_i2s4_bclk_sw",
> + "aud_tdm_clk",
> + "aud_tml_clk",
> + "aud_infra_clk",
> + "mtkaif_26m_clk",
> + "top_mux_audio",
> + "top_mux_aud_intbus",
> + "top_syspll_d2_d4",
> + "top_mux_aud_1",
> + "top_apll1_ck",
> + "top_mux_aud_2",
> + "top_apll2_ck",
> + "top_mux_aud_eng1",
> + "top_apll1_d8",
> + "top_mux_aud_eng2",
> + "top_apll2_d8",
> + "top_i2s0_m_sel",
> + "top_i2s1_m_sel",
> + "top_i2s2_m_sel",
> + "top_i2s3_m_sel",
> + "top_i2s4_m_sel",
> + "top_i2s5_m_sel",
> + "top_apll12_div0",
> + "top_apll12_div1",
> + "top_apll12_div2",
> + "top_apll12_div3",
> + "top_apll12_div4",
> + "top_apll12_divb",
> + "top_clk26m_clk";
> + };
> +
> +...
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names
2025-08-01 11:18 ` [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names Julien Massot
2025-08-01 17:30 ` Rob Herring (Arm)
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-18 15:16 ` Linus Walleij
2 siblings, 0 replies; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> Add support for the 'gpio-line-names' property in the MT8183 pinctrl
> binding.
> This allows naming the GPIOs, which is already done in several
> device trees (e.g. mt8183-kukui-jacuzzi.dtsi, mt8183-kukui-kakadu.dtsi,
> mt8183-kukui-krane.dtsi), but was previously generating DT schema
> warnings.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings to YAML
2025-08-01 11:18 ` [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings " Julien Massot
2025-08-01 17:28 ` Rob Herring
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> Convert the Device Tree binding for MT8183-based boards using the
> DA7219 headset codec and optional MAX98357, RT1015 or RT1015P speaker
> amplifiers from the legacy .txt format to YAML schema.
>
> This improves binding validation and removes DT schema warnings
> for boards using these audio components.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 3/9] arm64: dts: mt8183: Rename nodes to match audiosys binding schema
2025-08-01 11:18 ` [PATCH 3/9] arm64: dts: mt8183: Rename nodes to match audiosys binding schema Julien Massot
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> The binding for "mediatek,mt8183-audiosys" expects an audio-controller
> node inside the audiosys block. Rename the nested AFE node from
> "mt8183-afe-pcm" to "audio-controller" accordingly.
>
> Also rename the audiosys node itself from "audio-controller" to
> "clock-controller" to better reflect its function.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant
2025-08-01 11:18 ` [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant Julien Massot
2025-08-01 17:21 ` Rob Herring
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-20 13:30 ` Julien Massot
1 sibling, 1 reply; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> Update the mediatek,audsys binding to support the mt8183-audiosys
> compatible, which uses a different audio controller binding
> (mt8183-afe-pcm.yaml) compared to the legacy mt2701-audio controller.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> .../bindings/arm/mediatek/mediatek,audsys.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> index 45d4a6620041b11cf6e943de49a42f3fcd91e1b9..5d9d91f9c5802240ac7d411c5632ae6663d15f29 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> @@ -23,6 +23,7 @@ properties:
> - mediatek,mt7622-audsys
> - mediatek,mt8167-audsys
> - mediatek,mt8173-audsys
> + - mediatek,mt8183-audiosys
> - mediatek,mt8183-audsys
> - mediatek,mt8186-audsys
> - mediatek,mt8192-audsys
> @@ -41,7 +42,6 @@ properties:
> const: 1
>
> audio-controller:
> - $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
> type: object
>
> required:
> @@ -50,6 +50,21 @@ required:
>
> additionalProperties: false
>
> +allOf:
I think you can do it without the allOf here as well.
if:
properties:
compatible:
contains...
then:
properties
...
else:
... etc
after which
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8183-audiosys
> + then:
> + properties:
> + audio-controller:
> + $ref: /schemas/sound/mt8183-afe-pcm.yaml#
> + else:
> + properties:
> + audio-controller:
> + $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
> +
> examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property
2025-08-01 11:18 ` [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property Julien Massot
2025-08-01 17:19 ` Rob Herring (Arm)
@ 2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-20 13:27 ` Julien Massot
1 sibling, 1 reply; 38+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-08-04 7:59 UTC (permalink / raw)
To: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Il 01/08/25 13:18, Julien Massot ha scritto:
> The mt8183-mfgcfg node uses a power domain in its device tree node.
> To prevent schema validation warnings, add the optional `power-domains`
> property to the binding schema for mediatek syscon clocks.
>
> Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
Is MT8183 the only one?
if:
properties:
compatible:
contains:
- const: mediatek,mt8183-mfgcfg
^^^^^^^(if it's not just mt8183, this should be an enum)
then:
properties:
power-domains: true
else:
properties:
power-domains: false
(check if the above is correct, don't blindly trust what I wrote! :P)
after which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
(if it's not only mt8183, keep the R-b on this commit regardless)
Cheers,
Angelo
> ---
> Documentation/devicetree/bindings/clock/mediatek,syscon.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
> index a86a64893c675ac134af609b3a49242565db6ad8..1011bc46cfcb97b90b86019e95a7e4bc8a819342 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,syscon.yaml
> @@ -76,6 +76,9 @@ properties:
> - const: mediatek,mt2701-vdecsys
> - const: syscon
>
> + power-domains:
> + maxItems: 1
> +
> reg:
> maxItems: 1
>
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
2025-08-01 11:18 ` [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
@ 2025-08-06 6:38 ` Chen-Yu Tsai
2025-08-18 15:22 ` Linus Walleij
1 sibling, 1 reply; 38+ messages in thread
From: Chen-Yu Tsai @ 2025-08-06 6:38 UTC (permalink / raw)
To: Julien Massot
Cc: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
On Fri, Aug 1, 2025 at 7:18 PM Julien Massot
<julien.massot@collabora.com> wrote:
>
> The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv`
> were using incorrect values like `<10>` and `<01>`. These values
> are parsed as decimal (10 and 1 respectively), not binary.
>
> However, the driver interprets these as bitfields:
> - BIT(0): R0
> - BIT(1): R1
>
> So valid values are:
> - 0 => no pull
> - 1 => enable R0
> - 2 => enable R1
> - 3 => enable R0 + R1
>
> Using `<10>` is invalid as it exceeds the accepted range.
> It was likely intended as binary `0b10` (i.e., `2`),
> to enable R1 only.
>
> This patch replaces incorrect values with the correct ones
> and removes the leading zero from `<01>` to avoid confusion
> with bitfield notation.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 400c61d1103561db6ee0fb2d2e1c157529d03206..02bdfdb8e53c87dba0ba0024e0c69fcee825552b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -574,19 +574,19 @@ pins-cmd-dat {
> <PINMUX_GPIO122__FUNC_MSDC0_CMD>;
> input-enable;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-up-adv = <01>;
> + mediatek,pull-up-adv = <1>;
I suggest we just convert them to the standard bias-* properties:
bias-pull-up = <MTK_PUPD_SET_R1R0_01>;
> };
>
> pins-clk {
> pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
and so on.
ChenYu
> };
>
> pins-rst {
> pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <01>;
> + mediatek,pull-down-adv = <1>;
> };
> };
>
> @@ -603,25 +603,25 @@ pins-cmd-dat {
> <PINMUX_GPIO122__FUNC_MSDC0_CMD>;
> input-enable;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-up-adv = <01>;
> + mediatek,pull-up-adv = <1>;
> };
>
> pins-clk {
> pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins-ds {
> pinmux = <PINMUX_GPIO131__FUNC_MSDC0_DSL>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
>
> pins-rst {
> pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>;
> drive-strength = <MTK_DRIVE_14mA>;
> - mediatek,pull-up-adv = <01>;
> + mediatek,pull-up-adv = <1>;
> };
> };
>
> @@ -633,13 +633,13 @@ pins-cmd-dat {
> <PINMUX_GPIO33__FUNC_MSDC1_DAT2>,
> <PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
> input-enable;
> - mediatek,pull-up-adv = <10>;
> + mediatek,pull-up-adv = <2>;
> };
>
> pins-clk {
> pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
> input-enable;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> };
> };
>
> @@ -652,13 +652,13 @@ pins-cmd-dat {
> <PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
> drive-strength = <6>;
> input-enable;
> - mediatek,pull-up-adv = <10>;
> + mediatek,pull-up-adv = <2>;
> };
>
> pins-clk {
> pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
> drive-strength = <8>;
> - mediatek,pull-down-adv = <10>;
> + mediatek,pull-down-adv = <2>;
> input-enable;
> };
> };
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names
2025-08-01 11:18 ` [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names Julien Massot
2025-08-01 17:30 ` Rob Herring (Arm)
2025-08-04 7:59 ` AngeloGioacchino Del Regno
@ 2025-08-18 15:16 ` Linus Walleij
2 siblings, 0 replies; 38+ messages in thread
From: Linus Walleij @ 2025-08-18 15:16 UTC (permalink / raw)
To: Julien Massot
Cc: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
On Fri, Aug 1, 2025 at 1:18 PM Julien Massot
<julien.massot@collabora.com> wrote:
> Add support for the 'gpio-line-names' property in the MT8183 pinctrl
> binding.
> This allows naming the GPIOs, which is already done in several
> device trees (e.g. mt8183-kukui-jacuzzi.dtsi, mt8183-kukui-kakadu.dtsi,
> mt8183-kukui-krane.dtsi), but was previously generating DT schema
> warnings.
>
> Signed-off-by: Julien Massot <julien.massot@collabora.com>
This patch 7/9 applied to the pinctrl tree.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
2025-08-06 6:38 ` Chen-Yu Tsai
@ 2025-08-18 15:22 ` Linus Walleij
2025-08-19 5:27 ` Chen-Yu Tsai
0 siblings, 1 reply; 38+ messages in thread
From: Linus Walleij @ 2025-08-18 15:22 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
On Wed, Aug 6, 2025 at 8:38 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
> On Fri, Aug 1, 2025 at 7:18 PM Julien Massot wrote
> > pins-clk {
> > pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> > drive-strength = <MTK_DRIVE_14mA>;
> > - mediatek,pull-down-adv = <10>;
> > + mediatek,pull-down-adv = <2>;
>
> bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
>
> and so on.
>
> ChenYu
I agree with ChenYu, the more standardized properties are the better it is.
All the custom properties makes sense for an engineer working with just
that one SoC (like the SoC vendor...) but for field engineers who have
to use different SoCs every day this is just a big mess for the mind.
The standard properties are clear, concise and tell you exactly what
they are about.
The argument should be in Ohms though, according to the standard
bindings, but maybe the value of MTK_PUPD_SET_R1R0_10 is
something like that?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
2025-08-18 15:22 ` Linus Walleij
@ 2025-08-19 5:27 ` Chen-Yu Tsai
2025-08-19 5:29 ` Chen-Yu Tsai
0 siblings, 1 reply; 38+ messages in thread
From: Chen-Yu Tsai @ 2025-08-19 5:27 UTC (permalink / raw)
To: Linus Walleij
Cc: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
On Mon, Aug 18, 2025 at 11:22 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Wed, Aug 6, 2025 at 8:38 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
> > On Fri, Aug 1, 2025 at 7:18 PM Julien Massot wrote
>
> > > pins-clk {
> > > pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> > > drive-strength = <MTK_DRIVE_14mA>;
> > > - mediatek,pull-down-adv = <10>;
> > > + mediatek,pull-down-adv = <2>;
> >
> > bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
> >
> > and so on.
> >
> > ChenYu
>
> I agree with ChenYu, the more standardized properties are the better it is.
>
> All the custom properties makes sense for an engineer working with just
> that one SoC (like the SoC vendor...) but for field engineers who have
> to use different SoCs every day this is just a big mess for the mind.
>
> The standard properties are clear, concise and tell you exactly what
> they are about.
>
> The argument should be in Ohms though, according to the standard
> bindings, but maybe the value of MTK_PUPD_SET_R1R0_10 is
> something like that?
For reasons I can't recall clearly these are just placeholder values
that the driver then maps to the R1 and R0 settings. But at least they
use the standard properties.
The reason was either one of the following or both:
a. not every group of pins had the same resistance values for R1 & R0
b. there are no known precise values; the values depend on the process
and batch
ChenYu
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
2025-08-19 5:27 ` Chen-Yu Tsai
@ 2025-08-19 5:29 ` Chen-Yu Tsai
2025-08-19 9:12 ` Julien Massot
0 siblings, 1 reply; 38+ messages in thread
From: Chen-Yu Tsai @ 2025-08-19 5:29 UTC (permalink / raw)
To: Linus Walleij
Cc: Julien Massot, kernel, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
On Tue, Aug 19, 2025 at 1:27 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Mon, Aug 18, 2025 at 11:22 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > On Wed, Aug 6, 2025 at 8:38 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
> > > On Fri, Aug 1, 2025 at 7:18 PM Julien Massot wrote
> >
> > > > pins-clk {
> > > > pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> > > > drive-strength = <MTK_DRIVE_14mA>;
> > > > - mediatek,pull-down-adv = <10>;
> > > > + mediatek,pull-down-adv = <2>;
> > >
> > > bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
> > >
> > > and so on.
> > >
> > > ChenYu
> >
> > I agree with ChenYu, the more standardized properties are the better it is.
> >
> > All the custom properties makes sense for an engineer working with just
> > that one SoC (like the SoC vendor...) but for field engineers who have
> > to use different SoCs every day this is just a big mess for the mind.
> >
> > The standard properties are clear, concise and tell you exactly what
> > they are about.
> >
> > The argument should be in Ohms though, according to the standard
> > bindings, but maybe the value of MTK_PUPD_SET_R1R0_10 is
> > something like that?
>
> For reasons I can't recall clearly these are just placeholder values
> that the driver then maps to the R1 and R0 settings. But at least they
> use the standard properties.
>
> The reason was either one of the following or both:
>
> a. not every group of pins had the same resistance values for R1 & R0
> b. there are no known precise values; the values depend on the process
> and batch
Also, their customers seemed more accustomed to dealing with toggling
R1 & R0 vs setting some actual value. I presume that comes with the
uncertainty of the actual hardware value, and they just try which
combination works better.
ChenYu
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
2025-08-19 5:29 ` Chen-Yu Tsai
@ 2025-08-19 9:12 ` Julien Massot
0 siblings, 0 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-19 9:12 UTC (permalink / raw)
To: Chen-Yu Tsai, Linus Walleij
Cc: kernel, Michael Turquette, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Ikjoon Jang, Enric Balletbo i Serra,
Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Hi,
On Tue, 2025-08-19 at 13:29 +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 19, 2025 at 1:27 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
> >
> > On Mon, Aug 18, 2025 at 11:22 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > >
> > > On Wed, Aug 6, 2025 at 8:38 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
> > > > On Fri, Aug 1, 2025 at 7:18 PM Julien Massot wrote
> > >
> > > > > pins-clk {
> > > > > pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
> > > > > drive-strength = <MTK_DRIVE_14mA>;
> > > > > - mediatek,pull-down-adv = <10>;
> > > > > + mediatek,pull-down-adv = <2>;
> > > >
> > > > bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
> > > >
> > > > and so on.
> > > >
> > > > ChenYu
> > >
> > > I agree with ChenYu, the more standardized properties are the better it is.
> > >
> > > All the custom properties makes sense for an engineer working with just
> > > that one SoC (like the SoC vendor...) but for field engineers who have
> > > to use different SoCs every day this is just a big mess for the mind.
> > >
> > > The standard properties are clear, concise and tell you exactly what
> > > they are about.
> > >
> > > The argument should be in Ohms though, according to the standard
> > > bindings, but maybe the value of MTK_PUPD_SET_R1R0_10 is
> > > something like that?
> >
> > For reasons I can't recall clearly these are just placeholder values
> > that the driver then maps to the R1 and R0 settings. But at least they
> > use the standard properties.
> >
> > The reason was either one of the following or both:
> >
> > a. not every group of pins had the same resistance values for R1 & R0
> > b. there are no known precise values; the values depend on the process
> > and batch
>
> I don't know for (b), but no there is a lot of different values for R1 & R0
>
From what I saw in the register table
We can have for the pull up resistors
75K / 200K
2K / 75K
5K / 20K
50k / 10K
And for the pull down ones:
75k/2k
75k/75k
10k/50k
And we can have a combination of both resistors that will give odd values
(e.g 1948 Ohm for 2k/75K, 545454 Ohm for 75k/200k) to express in the device tree
>
> Also, their customers seemed more accustomed to dealing with toggling
> R1 & R0 vs setting some actual value. I presume that comes with the
> uncertainty of the actual hardware value, and they just try which
> combination works better.
>
> ChenYu
Regards,
Julien
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property
2025-08-04 7:59 ` AngeloGioacchino Del Regno
@ 2025-08-20 13:27 ` Julien Massot
0 siblings, 0 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-20 13:27 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, kernel, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Hi Angelo,
On Mon, 2025-08-04 at 09:59 +0200, AngeloGioacchino Del Regno wrote:
> Il 01/08/25 13:18, Julien Massot ha scritto:
> > The mt8183-mfgcfg node uses a power domain in its device tree node.
> > To prevent schema validation warnings, add the optional `power-domains`
> > property to the binding schema for mediatek syscon clocks.
> >
> > Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
>
> Is MT8183 the only one?
>
> if:
> properties:
> compatible:
> contains:
> - const: mediatek,mt8183-mfgcfg
> ^^^^^^^(if it's not just mt8183, this should be an enum)
>
> then:
> properties:
> power-domains: true
> else:
> properties:
> power-domains: false
>
> (check if the above is correct, don't blindly trust what I wrote! :P)
>
>
Verified on my side 'mediatek,mt8183-mfgcfg' is the only one with a power-domain
property.
I will add the if/else and disable the power-domains property for other compatible
as suggested.
>
> after which:
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> (if it's not only mt8183, keep the R-b on this commit regardless)
Thanks,
Julien
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant
2025-08-01 17:21 ` Rob Herring
@ 2025-08-20 13:28 ` Julien Massot
0 siblings, 0 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-20 13:28 UTC (permalink / raw)
To: Rob Herring
Cc: kernel, Michael Turquette, Stephen Boyd, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
Hi Rob,
On Fri, 2025-08-01 at 12:21 -0500, Rob Herring wrote:
> On Fri, Aug 01, 2025 at 01:18:04PM +0200, Julien Massot wrote:
> > Update the mediatek,audsys binding to support the mt8183-audiosys
> > compatible, which uses a different audio controller binding
> > (mt8183-afe-pcm.yaml) compared to the legacy mt2701-audio controller.
>
> Looks like this one needs 'memory-region' added?
Correct, I will add 'memory-region' in v2.
Regards,
Julien
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant
2025-08-04 7:59 ` AngeloGioacchino Del Regno
@ 2025-08-20 13:30 ` Julien Massot
0 siblings, 0 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-20 13:30 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, kernel, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Matthias Brugger, Ikjoon Jang, Enric Balletbo i Serra,
Chen-Yu Tsai, Weiyi Lu, Eugen Hristev, Liam Girdwood, Mark Brown,
Julien Massot, Sean Wang, Linus Walleij
Cc: linux-clk, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-sound, linux-gpio
Hi Angelo,
On Mon, 2025-08-04 at 09:59 +0200, AngeloGioacchino Del Regno wrote:
> Il 01/08/25 13:18, Julien Massot ha scritto:
> > Update the mediatek,audsys binding to support the mt8183-audiosys
> > compatible, which uses a different audio controller binding
> > (mt8183-afe-pcm.yaml) compared to the legacy mt2701-audio controller.
> >
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > ---
> > .../bindings/arm/mediatek/mediatek,audsys.yaml | 17 ++++++++++++++++-
> > 1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> > index 45d4a6620041b11cf6e943de49a42f3fcd91e1b9..5d9d91f9c5802240ac7d411c5632ae6663d15f29 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,audsys.yaml
> > @@ -23,6 +23,7 @@ properties:
> > - mediatek,mt7622-audsys
> > - mediatek,mt8167-audsys
> > - mediatek,mt8173-audsys
> > + - mediatek,mt8183-audiosys
> > - mediatek,mt8183-audsys
> > - mediatek,mt8186-audsys
> > - mediatek,mt8192-audsys
> > @@ -41,7 +42,6 @@ properties:
> > const: 1
> >
> > audio-controller:
> > - $ref: /schemas/sound/mediatek,mt2701-audio.yaml#
> > type: object
> >
> > required:
> > @@ -50,6 +50,21 @@ required:
> >
> > additionalProperties: false
> >
> > +allOf:
>
> I think you can do it without the allOf here as well.
>
> if:
> properties:
> compatible:
> contains...
> then:
> properties
> ...
> else:
> ... etc
>
> after which
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Indeed allOf is not needed here, will be fixed in v2 and will add your R-B.
Regards,
Julien
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML
2025-08-01 17:26 ` Rob Herring
@ 2025-08-20 13:32 ` Julien Massot
0 siblings, 0 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-20 13:32 UTC (permalink / raw)
To: Rob Herring
Cc: kernel, Michael Turquette, Stephen Boyd, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
Hi Rob,
On Fri, 2025-08-01 at 12:26 -0500, Rob Herring wrote:
> On Fri, Aug 01, 2025 at 01:18:06PM +0200, Julien Massot wrote:
> > Convert the MediaTek MT8183 AFE PCM Device Tree binding from the old
> > .txt format to YAML schema format to improve validation.
> >
> > While converting, also document all clock inputs used by the AFE block.
> >
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > ---
> > .../devicetree/bindings/sound/mt8183-afe-pcm.txt | 42 ----
> > .../devicetree/bindings/sound/mt8183-afe-pcm.yaml | 225 +++++++++++++++++++++
> > 2 files changed, 225 insertions(+), 42 deletions(-)
>
> This should come before patch 2 since it is referenced there.
>
> Yes, I will swap the patches in the v2.
>
> Use the compatible string for the filename.
>
Ok
>
> Otherwise, looks good to me.
Thank you,
Julien
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings to YAML
2025-08-01 17:28 ` Rob Herring
@ 2025-08-20 13:33 ` Julien Massot
0 siblings, 0 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-20 13:33 UTC (permalink / raw)
To: Rob Herring
Cc: kernel, Michael Turquette, Stephen Boyd, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
On Fri, 2025-08-01 at 12:28 -0500, Rob Herring wrote:
> On Fri, Aug 01, 2025 at 01:18:07PM +0200, Julien Massot wrote:
> > Convert the Device Tree binding for MT8183-based boards using the
> > DA7219 headset codec and optional MAX98357, RT1015 or RT1015P speaker
> > amplifiers from the legacy .txt format to YAML schema.
> >
> > This improves binding validation and removes DT schema warnings
> > for boards using these audio components.
> >
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > ---
> > .../bindings/sound/mt8183-da7219-max98357.txt | 21 ----------
> > .../devicetree/bindings/sound/mt8183-da7219.yaml | 49 ++++++++++++++++++++++
>
> mediatek,mt8183_da7219.yaml
>
Ok, Fixed in v2.
Thanks,
Julien
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 bindings to YAML
2025-08-01 17:29 ` Rob Herring
@ 2025-08-20 13:34 ` Julien Massot
0 siblings, 0 replies; 38+ messages in thread
From: Julien Massot @ 2025-08-20 13:34 UTC (permalink / raw)
To: Rob Herring
Cc: kernel, Michael Turquette, Stephen Boyd, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Ikjoon Jang, Enric Balletbo i Serra, Chen-Yu Tsai, Weiyi Lu,
Eugen Hristev, Liam Girdwood, Mark Brown, Julien Massot,
Sean Wang, Linus Walleij, linux-clk, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-sound, linux-gpio
On Fri, 2025-08-01 at 12:29 -0500, Rob Herring wrote:
> On Fri, Aug 01, 2025 at 01:18:08PM +0200, Julien Massot wrote:
> > Convert the existing text-based DT binding for MT8183 sound cards using
> > MT6358 and various other codecs to a YAML schema.
> >
> > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > ---
> > .../sound/mt8183-mt6358-ts3a227-max98357.txt | 25 ---------
> > .../devicetree/bindings/sound/mt8183-mt6358.yaml | 59 ++++++++++++++++++++++
>
> mediatek,mt8183_mt6358_ts3a227.yaml
Ok, Thanks for the review.
Julien
^ permalink raw reply [flat|nested] 38+ messages in thread
end of thread, other threads:[~2025-08-20 13:34 UTC | newest]
Thread overview: 38+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
2025-08-01 11:18 ` [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property Julien Massot
2025-08-01 17:19 ` Rob Herring (Arm)
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-20 13:27 ` Julien Massot
2025-08-01 11:18 ` [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant Julien Massot
2025-08-01 17:21 ` Rob Herring
2025-08-20 13:28 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-20 13:30 ` Julien Massot
2025-08-01 11:18 ` [PATCH 3/9] arm64: dts: mt8183: Rename nodes to match audiosys binding schema Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML Julien Massot
2025-08-01 17:26 ` Rob Herring
2025-08-20 13:32 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings " Julien Massot
2025-08-01 17:28 ` Rob Herring
2025-08-20 13:33 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 " Julien Massot
2025-08-01 17:29 ` Rob Herring
2025-08-20 13:34 ` Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names Julien Massot
2025-08-01 17:30 ` Rob Herring (Arm)
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-18 15:16 ` Linus Walleij
2025-08-01 11:18 ` [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-06 6:38 ` Chen-Yu Tsai
2025-08-18 15:22 ` Linus Walleij
2025-08-19 5:27 ` Chen-Yu Tsai
2025-08-19 5:29 ` Chen-Yu Tsai
2025-08-19 9:12 ` Julien Massot
2025-08-01 11:18 ` [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: " Julien Massot
2025-08-04 7:59 ` AngeloGioacchino Del Regno
2025-08-01 13:26 ` [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).