From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C831926CE13 for ; Fri, 1 Aug 2025 13:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056287; cv=none; b=JhgTWqGZrpoLjAhj2/I56g4txd8h4uUkyOjgEWlIWfDHYy1d/KzWDCjvqqfiTrSRSbfM3tqGOGMpfYTRg9tWhceU1tV/tE8SxUG1sIETNReF1wuIeCFCcJQf7Tg7dq7q756EngK4ToqkMxVWR+PLlI990ZJZv11Pu15vuKQu/Ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754056287; c=relaxed/simple; bh=P1Z0Gdm80qNJHt3MSy/BfGrhTCWZS7Xn/sS5jUPkuZY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=msAXH8fmJB6xouGoaBpsz1eWCYJsldjCzAp43ReYepB7B9DhsAqGtGM58VqUOyVSxybJd1w30d1+MLOhu9rkrJz3FXJmPM+OQO8g6V1QIe3VXgp3/bIs1DLO42ZCtTCkigh8+LDrjUZzHcttyJ/l5az/q/vKMu1/HfmiClX1D7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B5XaPGSC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B5XaPGSC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5718YpDl004997 for ; Fri, 1 Aug 2025 13:51:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tVawR6mCQAAJds4EZ/RayxaIa/tzB6nlBY+m3oTR/UI=; b=B5XaPGSCzoY8/OEL nKR5SEJSQqDyUZCNVdUUJx5GkkDzxCIQUiR84wJQY/a2C82x0AGoGUkvBbCDJdyg 9jC7I7Ppe5ZxSl41lmDWQiYGA+pK0uQbETAcfyB/oJZ2ckfzE9BjzXbLHUki/Opw lbFK9gXG7eN10zogPdA4kysRBnZyIZArwfdoUwDeWzusSXIWJLJ44+3OBfQ/Dbj4 AfPPrIBn4GmZai08pEL/cCb6vvK4cj1cKsTIkCqxi9/f5KfkxdQP/Ps7tzMos5km cur9oiL6PuZWEZKuN/NWQqsETFA/iPtLc2KwtXGgLZR2CL7Ks+iMColNLasS37U9 L1zpuA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484q86cbbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 13:51:23 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ab684d3b55so46875471cf.0 for ; Fri, 01 Aug 2025 06:51:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754056282; x=1754661082; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tVawR6mCQAAJds4EZ/RayxaIa/tzB6nlBY+m3oTR/UI=; b=mryu3o8xNusDyt7dAI31C0Bb+8fAbl2GSsBz3GS0JTrNKX6Eh8Iu3NkzHxxZhhLZv7 N+EFKdkLzxYgh1p7MTuKFJ4AGgEg36+I3qqK/Ce3A71FKqTK2IxhoivvO/4GxiS+8XoS uA2rQRHy+WU3N30Nig6zLaMflQQsqOSrtov1p55FR/d4KOfBzSmXMWhrZLlnJLFltmxS zSx45c4fMOFGJK4VIjlF9TvzogXt2HtIvpquwl+g0ogsCfEtTCbjHW387hrAqZSy4V2T XS1a/4cm3UmRxNCqWQJzQUCLdRT82/8wnEp+dqY+aTVAZ5t8WBCaa0oFdZzjJvsvR39b qEGA== X-Forwarded-Encrypted: i=1; AJvYcCUxMr2FxTufDBvf+V+VNLVbD3kDDjQYfnbatyLS1YpAWjXA1U0UbDDWJUrblkraCqHop0fTVvXEmsGLiu0=@vger.kernel.org X-Gm-Message-State: AOJu0YyawdY+FZcMIZDoQI456qsrZQHYGgfM/OlYdP7IIwXA/rH54pRt 340Pl9IXXjHVdjxwEWWimUo1CGA2J5QjHrFcuDv4YHfzwOT1Zs/ZDVdIcSY5TFph8PDxHHFyg52 ILcXxP33hd3o5l1yAvR3N+81LGbei1m/9XqVFNlQqDyb9+sBJiZbeNeUUEVoWxoO4Zd4= X-Gm-Gg: ASbGncvnbG6t/LNZlqLeVY1sUzxwQdHb9PPGfwxbUm/1xWcKFmFyiwyfuI5esetfR0Q UQ8UdUAl/McnVUwa0szvHUD62DCzM09oTbJosserckHWnRgE4ImjLo/TdAPy6Hqb6MA6Kz6CbXW vxG+wTCAT0EAh2UdwNxoqt8/Vcvh1tYv1pxzBBK+fodN4MZRSNXY2g6cFPCWgdRdWKN66VDo5/W wK65iLshlcUo0XNsuIjwlJz4w2fePduaKChZt90SMTqrBsmvAz21zVO5wornWlRbUByddDSeGLG E7nWaONQLWg9pPuNufhcwKhH/mgz267QXc2EJ9aubBc/AMTfjjO+OJrcb3Cn/Xs244ESi/uPTPQ ImQrJzlUqB+anbHmULDDpS8xPcX4QugM++7thW8QL0aWUc24RPzHr X-Received: by 2002:ac8:59c9:0:b0:4ab:722c:ff15 with SMTP id d75a77b69052e-4aef16d926emr76618491cf.8.1754056282331; Fri, 01 Aug 2025 06:51:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHinZAK6zgz67gxcBa5Qc+o9XL/d6M0vzQBd+as2iX1dHhTo8v0oERF1BzFlbp7qnq1jXNRzQ== X-Received: by 2002:ac8:59c9:0:b0:4ab:722c:ff15 with SMTP id d75a77b69052e-4aef16d926emr76617941cf.8.1754056281863; Fri, 01 Aug 2025 06:51:21 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-33238273006sm5917801fa.9.2025.08.01.06.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 06:51:21 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 01 Aug 2025 16:51:11 +0300 Subject: [PATCH 3/8] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250801-wb-drop-encoder-v1-3-824646042f7d@oss.qualcomm.com> References: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> In-Reply-To: <20250801-wb-drop-encoder-v1-0-824646042f7d@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2517; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=P1Z0Gdm80qNJHt3MSy/BfGrhTCWZS7Xn/sS5jUPkuZY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBojMZTgNmCXsFmzp+S17Kx+aqN4yS4VmhyhMxrP aqLrBUR/VWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaIzGUwAKCRCLPIo+Aiko 1Tt8B/416/YgM3zYyZ0WB5DeZyBJzXBjPQXXAaToCtg+qCkd5fJZPLQ3Vr5YUNhMTw/2trGwgAn fJVDfQrkMZQOKG2PrGGMHGUx5GIEUMqir/XjCmlH23+lEtuIWOzNBJHF22ojkfLtYI8VvBHTeIN vq4mYfMW7gxKtXuUdM5N7VFzD5teZBSYI86b7FMVT2/Xyk57ul4HjqmR2QyPSrWBPKiX9TcQLTe h9+6W2wC/ey3qnTTaz9jqTEWseyUjwxc0/MvAkor8AplA/Ef/FrUP70IG5LHH00Mq8S/Y00DaLH RGajsMZxfRPOEJpeRd2dJiyB7BHKG9eahphZY27/p3NrY5dt X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDEwMyBTYWx0ZWRfX0Kgj+NNbd8F/ EbQlT1ga/N9ZQup9MmUDNrnKyLLzVIGa6qaAx1tOfqqO9vZ478TKzKznpKvnkmBBOkx0sX8WUEh SdCkf/c062ryQ7y9L75RZER5miMYOXWdUPGKJrS/vaEDZCS+h7hBdif6GYO9QvFNvawzNssPDj+ TnhsWyyyJzlqrAbv35U4AHzl5O1aw/l37SbUM+VQtVKn1k1Hw8l7+biRHr2PQEssbhOVfvJXmVU 5maM3EHEumb3YoOGYmxFvQm/Z1gdgUVYPA/mfn8Hk51/PYUwc/tTsHHSS/oqrIPHnqc239K1yDm rfHpzqlob5Zwa3WiDvCkBdMbhvt+r+XY3B4JAKywFvBcJZbVWzwKd4vjecp9MmIPrDfwPawBhqq ph89oNK3S9oWftymVwAXiGycAiLdAOJqc6dxAaBabYBmxRvBCP79LCJZ8FtdxcCr8XL1R51a X-Authority-Analysis: v=2.4 cv=TqLmhCXh c=1 sm=1 tr=0 ts=688cc65b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=mhD89yN676IZukTL2GQA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: yvv5fF_5-_UNCiDCU_P_urk-LkHD0Bfj X-Proofpoint-GUID: yvv5fF_5-_UNCiDCU_P_urk-LkHD0Bfj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_04,2025-08-01_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 mlxlogscore=770 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010103 Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c index 600af5ad81b15d0c30f9f79588f40cca07437ed8..182275c0c29cd8527c85dfb3e7317561da392c46 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -84,11 +84,6 @@ malidp_mw_connector_detect(struct drm_connector *connector, bool force) return connector_status_connected; } -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -114,7 +109,6 @@ static const struct drm_connector_funcs malidp_mw_connector_funcs = { .reset = malidp_mw_connector_reset, .detect = malidp_mw_connector_detect, .fill_modes = drm_helper_probe_single_connector_modes, - .destroy = malidp_mw_connector_destroy, .atomic_duplicate_state = malidp_mw_connector_duplicate_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, }; @@ -211,6 +205,7 @@ static u32 *get_writeback_formats(struct malidp_drm *malidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp = drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; @@ -224,11 +219,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; - ret = drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder = drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs = 1 << drm_crtc_index(&malidp->crtc); + + ret = drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; -- 2.39.5