[PATCH] Revert "gpio: pxa: Make irq_chip immutable"

[PATCH] Revert "gpio: pxa: Make irq_chip immutable"

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This reverts commit 20117cf426b6 ("gpio: pxa: Make irq_chip immutableas")
as it caused a regression on samsung coreprimevelte and we've not been
able to fix it so far.

Reported-by: Duje Mihanović <duje@dujemihanovic.xyz>
Closes: https://lore.kernel.org/all/3367665.aeNJFYEL58@radijator/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpio-pxa.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 13f7da2a9486..cbcdd416f8b9 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -499,8 +499,6 @@ static void pxa_mask_muxed_gpio(struct irq_data *d)
 	gfer = readl_relaxed(base + GFER_OFFSET) & ~GPIO_bit(gpio);
 	writel_relaxed(grer, base + GRER_OFFSET);
 	writel_relaxed(gfer, base + GFER_OFFSET);
-
-	gpiochip_disable_irq(&pchip->chip, gpio);
 }
 
 static int pxa_gpio_set_wake(struct irq_data *d, unsigned int on)
@@ -520,21 +518,17 @@ static void pxa_unmask_muxed_gpio(struct irq_data *d)
 	unsigned int gpio = irqd_to_hwirq(d);
 	struct pxa_gpio_bank *c = gpio_to_pxabank(&pchip->chip, gpio);
 
-	gpiochip_enable_irq(&pchip->chip, gpio);
-
 	c->irq_mask |= GPIO_bit(gpio);
 	update_edge_detect(c);
 }
 
-static const struct irq_chip pxa_muxed_gpio_chip = {
+static struct irq_chip pxa_muxed_gpio_chip = {
 	.name		= "GPIO",
 	.irq_ack	= pxa_ack_muxed_gpio,
 	.irq_mask	= pxa_mask_muxed_gpio,
 	.irq_unmask	= pxa_unmask_muxed_gpio,
 	.irq_set_type	= pxa_gpio_irq_type,
 	.irq_set_wake	= pxa_gpio_set_wake,
-	.flags = IRQCHIP_IMMUTABLE,
-	GPIOCHIP_IRQ_RESOURCE_HELPERS,
 };
 
 static int pxa_gpio_nums(struct platform_device *pdev)
-- 
2.48.1

Re: [PATCH] Revert "gpio: pxa: Make irq_chip immutable"

[Duje Mihanović]

On Friday, 1 August 2025 09:18:58 Central European Summer Time Bartosz 
Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> This reverts commit 20117cf426b6 ("gpio: pxa: Make irq_chip immutableas")
> as it caused a regression on samsung coreprimevelte and we've not been
> able to fix it so far.
> 

Tested-by: Duje Mihanović <duje@dujemihanovic.xyz>

Could the fix be backported to v6.16.y?

Regards,
--
Duje

Re: [PATCH] Revert "gpio: pxa: Make irq_chip immutable"

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Fri, 01 Aug 2025 09:18:58 +0200, Bartosz Golaszewski wrote:
> This reverts commit 20117cf426b6 ("gpio: pxa: Make irq_chip immutableas")
> as it caused a regression on samsung coreprimevelte and we've not been
> able to fix it so far.
> 
> 

Applied, thanks!

[1/1] Revert "gpio: pxa: Make irq_chip immutable"
      https://git.kernel.org/brgl/linux/c/b644c640923b625340c603cdb8d8f456406eb4de

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>